Attachment 87976 Details for Bug 208260 – Nitpicking

[patch] Nitpicking

208260_patch.txt (text/plain), 6.81 KB, created by Markus Keller

on 2008-01-27 14:16:48 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Markus Keller

Created: 2008-01-27 14:16:48 EST

Size: 6.81 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: search/org/eclipse/jdt/core/search/SearchPattern.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/search/org/eclipse/jdt/core/search/SearchPattern.java,v
>retrieving revision 1.75
>diff -u -r1.75 SearchPattern.java
>--- search/org/eclipse/jdt/core/search/SearchPattern.java	25 Jan 2008 21:16:18 -0000	1.75
>+++ search/org/eclipse/jdt/core/search/SearchPattern.java	27 Jan 2008 19:08:14 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2007 IBM Corporation and others.
>+ * Copyright (c) 2000, 2008 IBM Corporation and others.
> * All rights reserved. This program and the accompanying materials
> * are made available under the terms of the Eclipse Public License v1.0
> * which accompanies this distribution, and is available at
>@@ -1264,16 +1264,16 @@
> *	Examples:
> *	<ul>
> * 		<li>search for case insensitive references to <code>Object</code>:
>- *			<code>createSearchPattern("Object", TYPE, REFERENCES, false);</code></li>
>+ *			<code>createSearchPattern("Object", IJavaSearchConstants.TYPE, IJavaSearchConstants.REFERENCES, false);</code></li>
> * 	<li>search for case sensitive references to exact <code>Object()</code> constructor:
>- *			<code>createSearchPattern("java.lang.Object()", CONSTRUCTOR, REFERENCES, true);</code></li>
>+ *			<code>createSearchPattern("java.lang.Object()", IJavaSearchConstants.CONSTRUCTOR, IJavaSearchConstants.REFERENCES, true);</code></li>
> * 	<li>search for implementers of <code>java.lang.Runnable</code>:
>- *			<code>createSearchPattern("java.lang.Runnable", TYPE, IMPLEMENTORS, true);</code></li>
>+ *			<code>createSearchPattern("java.lang.Runnable", IJavaSearchConstants.TYPE, IJavaSearchConstants.IMPLEMENTORS, true);</code></li>
> * </ul>
> * @param stringPattern the given pattern
> * <ul>
>- * 	<li>Type pattern can have the following syntax:
>- * 		<code>[qualification '.']type ['&lt;' typeArguments '&gt;']</code>
>+ * 	<li>Type patterns have the following syntax:
>+ * 		<code>[qualification '.']typeName ['&lt;' typeArguments '&gt;']</code>
> *			Some samples:<code>
> *			<ul>
> * 			<li>java.lang.Object</li>
>@@ -1282,7 +1282,7 @@
> *			</ul>
> *			</code>
> *			
>- *			Type arguments can be specified to search references to parameterized types
>+ *			Type arguments can be specified to search for references to parameterized types
> * 		using following syntax:
> * 		<code>'&lt;' { [ '?' {'extends'|'super'} ] type ( ',' [ '?' {'extends'|'super'} ] type )* | '?' } '&gt;'</code>
> * 		
>@@ -1293,10 +1293,10 @@
> * 		</ul>
> * 		
> * 	</li>
>- * 	<li>Method pattern can have the following syntax:
>- * 		<code>[declaringType '.'] ['&lt;' typeArguments '&gt;'] selector ['(' parameterTypes ')'] [returnType]</code>
>- *			 Type arguments have the same pattern that for type patterns
>-	 *		Some samples:<code>
>+ * 	<li>Method patterns have the following syntax:
>+ * 		<code>[declaringType '.'] ['&lt;' typeArguments '&gt;'] methodName ['(' parameterTypes ')'] [returnType]</code>
>+ *			Type arguments have the same syntax as explained in the type patterns section
>+ *			Some samples:<code>
> *			<ul>
> *				<li>java.lang.Runnable.run() void</li>
> *				<li>main(*)</li>
>@@ -1305,9 +1305,9 @@
> *			</code>
> *			
> *		</li>
>- * 	<li>Constructor pattern can have the following syntax:
>- *			<code>['&lt;' typeArguments '&gt;'] [declaringQualification '.'] type ['(' parameterTypes ')']</code>
>- *			Type arguments have the same pattern that for type patterns
>+ * 	<li>Constructor patterns have the following syntax:
>+ *			<code>['&lt;' typeArguments '&gt;'] [declaringQualification '.'] typeName ['(' parameterTypes ')']</code>
>+ *			Type arguments have the same syntax as explained in the type patterns section
> *			Some samples:<code>
> *			<ul>
> *				<li>java.lang.Object()</li>
>@@ -1317,8 +1317,8 @@
> *			</code>
> *			 
> * 	</li>
>- * 	<li>Field pattern can have the following syntax:
>- *			<code>[declaringType.]name[ type]</code>
>+ * 	<li>Field patterns have the following syntax:
>+ *			<code>[declaringType '.'] fieldName [fieldType]</code>
> *			Some samples:<code>
> *			<ul>
> *				<li>java.lang.String.serialVersionUID long</li>
>@@ -1327,6 +1327,16 @@
> *			</code>
> *			
> * 	</li>
>+ * 	<li>Package patterns have the following syntax:
>+ *			<code>packageNameSegment {'.' packageNameSegment}</code>
>+ *			Some samples:<code>
>+ *			<ul>
>+ *				<li>java.lang</li>
>+ *				<li>org.e*.jdt.c*e</li>
>+ *			</ul>
>+ *			</code>
>+ *			
>+ * 	</li>
> * </ul>
> * @param searchFor determines the nature of the searched elements
> *	<ul>
>@@ -1363,7 +1373,7 @@
> *		<li>TODO (frederic) add specification for fine grain flags
> *		</li>
> *	</ul>
>- * @param matchRule one of the following match rule
>+ * @param matchRule one of the following match rules
> * 	<ul>
> * 		<li>{@link #R_EXACT_MATCH}</li>
> * 		<li>{@link #R_PREFIX_MATCH}</li>
>@@ -1372,7 +1382,7 @@
> * 		<li>{@link #R_CAMELCASE_MATCH}</li>
> * 		<li>{@link #R_CAMELCASE_SAME_PART_COUNT_MATCH}</li>
> * 	</ul>
>- * 	which may be also combined with one of the following flag:
>+ * 	, which may be also combined with one of the following flags:
> * 	<ul>
> * 		<li>{@link #R_CASE_SENSITIVE}</li>
> * 		<li>{@link #R_ERASURE_MATCH}</li>
>@@ -1389,7 +1399,7 @@
> * 	Note that {@link #R_ERASURE_MATCH} or {@link #R_EQUIVALENT_MATCH} has no effect
> * 	on non-generic types/methods search.
> * 	
>- * 	Note also that default behavior for generic types/methods search is to find exact matches.
>+ * 	Note also that the default behavior for generic types/methods search is to find exact matches.
> * @return a search pattern on the given string pattern, or <code>null</code> if the string pattern is ill-formed
> */
> public static SearchPattern createPattern(String stringPattern, int searchFor, int limitTo, int matchRule) {
>@@ -1530,7 +1540,7 @@
> *		<li>TODO (frederic) add specification for fine grain flags
> *		</li>
> *	</ul>
>- * @param matchRule one of the following match rule
>+ * @param matchRule one of the following match rules:
> * 	<ul>
> * 		<li>{@link #R_EXACT_MATCH}</li>
> * 		<li>{@link #R_PREFIX_MATCH}</li>
>@@ -1539,7 +1549,7 @@
> * 		<li>{@link #R_CAMELCASE_MATCH}</li>
> * 		<li>{@link #R_CAMELCASE_SAME_PART_COUNT_MATCH}</li>
> * 	</ul>
>- * 	which may be also combined with one of the following flag:
>+ * 	, which may be also combined with one of the following flags:
> * 	<ul>
> * 		<li>{@link #R_CASE_SENSITIVE}</li>
> * 		<li>{@link #R_ERASURE_MATCH}</li>

Actions: View | Diff

Attachments on bug 208260: 87887 | 87976