Attachment 85253 Details for Bug 207982 – Adds extended debug events support

[patch] Adds extended debug events support

fix_207982.txt (text/plain), 5.97 KB, created by Timur Shipilov

on 2007-12-14 01:51:52 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Timur Shipilov

Created: 2007-12-14 01:51:52 EST

Size: 5.97 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dltk.debug
>Index: src/org/eclipse/dltk/internal/debug/core/model/ScriptThread.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.debug/src/org/eclipse/dltk/internal/debug/core/model/ScriptThread.java,v
>retrieving revision 1.15
>diff -u -r1.15 ScriptThread.java
>--- src/org/eclipse/dltk/internal/debug/core/model/ScriptThread.java	5 Dec 2007 09:51:22 -0000	1.15
>+++ src/org/eclipse/dltk/internal/debug/core/model/ScriptThread.java	14 Dec 2007 06:50:25 -0000
>@@ -28,6 +28,7 @@
> import org.eclipse.dltk.dbgp.internal.IDbgpTerminationListener;
> import org.eclipse.dltk.debug.core.DLTKDebugPlugin;
> import org.eclipse.dltk.debug.core.DebugPreferenceConstants;
>+import org.eclipse.dltk.debug.core.ExtendedDebugEventDetails;
> import org.eclipse.dltk.debug.core.ISmartStepEvaluator;
> import org.eclipse.dltk.debug.core.eval.IScriptEvaluationEngine;
> import org.eclipse.dltk.debug.core.model.IScriptDebugTarget;
>@@ -63,6 +64,9 @@
> 
> 	// ScriptThreadStateManager.IStateChangeHandler
> 	public void handleSuspend(int detail) {
>+		DebugEventHelper.fireExtendedEvent(this,
>+				ExtendedDebugEventDetails.BEFORE_SUSPEND);
>+
> 		stack.update();
> 
> 		if( handleSmartStepInto() ) {
>@@ -101,6 +105,9 @@
> 	}
> 
> 	public void handleResume(int detail) {
>+		DebugEventHelper.fireExtendedEvent(this,
>+				ExtendedDebugEventDetails.BEFORE_RESUME);
>+
> 		DebugEventHelper.fireResumeEvent(this, detail);
> 		DebugEventHelper.fireChangeEvent(this);
> 	}
>Index: src/org/eclipse/dltk/internal/debug/core/model/DebugEventHelper.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.debug/src/org/eclipse/dltk/internal/debug/core/model/DebugEventHelper.java,v
>retrieving revision 1.2
>diff -u -r1.2 DebugEventHelper.java
>--- src/org/eclipse/dltk/internal/debug/core/model/DebugEventHelper.java	12 Jun 2007 10:04:21 -0000	1.2
>+++ src/org/eclipse/dltk/internal/debug/core/model/DebugEventHelper.java	14 Dec 2007 06:50:25 -0000
>@@ -41,4 +41,9 @@
> 	public static void fireChangeEvent(IDebugElement element) {
> 		fireEvent(new DebugEvent(element, DebugEvent.CHANGE));
> 	}
>+
>+	public static void fireExtendedEvent(Object eventSource, int details) {
>+		fireEvent(new DebugEvent(eventSource, DebugEvent.MODEL_SPECIFIC,
>+				details));
>+	}
> }
>Index: src/org/eclipse/dltk/internal/debug/core/model/ScriptDebugTarget.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.debug/src/org/eclipse/dltk/internal/debug/core/model/ScriptDebugTarget.java,v
>retrieving revision 1.21
>diff -u -r1.21 ScriptDebugTarget.java
>--- src/org/eclipse/dltk/internal/debug/core/model/ScriptDebugTarget.java	13 Dec 2007 16:04:10 -0000	1.21
>+++ src/org/eclipse/dltk/internal/debug/core/model/ScriptDebugTarget.java	14 Dec 2007 06:50:25 -0000
>@@ -37,6 +37,7 @@
> import org.eclipse.dltk.core.IDLTKLanguageToolkit;
> import org.eclipse.dltk.core.IScriptProject;
> import org.eclipse.dltk.debug.core.DLTKDebugPlugin;
>+import org.eclipse.dltk.debug.core.ExtendedDebugEventDetails;
> import org.eclipse.dltk.debug.core.IDbgpService;
> import org.eclipse.dltk.debug.core.model.IScriptDebugTarget;
> import org.eclipse.dltk.debug.core.model.IScriptDebugTargetListener;
>@@ -297,6 +298,9 @@
> 	// IDbgpThreadManagerListener
> 	public void threadAccepted(IScriptThread thread, boolean first) {
> 		if (first) {
>+			DebugEventHelper.fireExtendedEvent(this,
>+					ExtendedDebugEventDetails.BEFORE_CODE_LOADED);
>+
> 			breakpointManager.setupDeferredBreakpoints();
> 
> 			IBreakpointManager manager = DebugPlugin.getDefault()
>Index: src/org/eclipse/dltk/debug/core/ExtendedDebugEventDetails.java
>===================================================================
>RCS file: src/org/eclipse/dltk/debug/core/ExtendedDebugEventDetails.java
>diff -N src/org/eclipse/dltk/debug/core/ExtendedDebugEventDetails.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/dltk/debug/core/ExtendedDebugEventDetails.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,8 @@
>+package org.eclipse.dltk.debug.core;
>+
>+public class ExtendedDebugEventDetails {
>+	public static final int BEFORE_VM_STARTED = 1;
>+	public static final int BEFORE_CODE_LOADED = 2;
>+	public static final int BEFORE_SUSPEND = 3;
>+	public static final int BEFORE_RESUME= 4;
>+}
>#P org.eclipse.dltk.launching
>Index: src/org/eclipse/dltk/launching/DebuggingEngineRunner.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/core/plugins/org.eclipse.dltk.launching/src/org/eclipse/dltk/launching/DebuggingEngineRunner.java,v
>retrieving revision 1.20
>diff -u -r1.20 DebuggingEngineRunner.java
>--- src/org/eclipse/dltk/launching/DebuggingEngineRunner.java	5 Dec 2007 09:51:34 -0000	1.20
>+++ src/org/eclipse/dltk/launching/DebuggingEngineRunner.java	14 Dec 2007 06:50:27 -0000
>@@ -9,9 +9,11 @@
> import org.eclipse.debug.core.model.IProcess;
> import org.eclipse.dltk.dbgp.DbgpSessionIdGenerator;
> import org.eclipse.dltk.debug.core.DLTKDebugPlugin;
>+import org.eclipse.dltk.debug.core.ExtendedDebugEventDetails;
> import org.eclipse.dltk.debug.core.IDbgpService;
> import org.eclipse.dltk.debug.core.ScriptDebugManager;
> import org.eclipse.dltk.debug.core.model.IScriptDebugTarget;
>+import org.eclipse.dltk.internal.debug.core.model.DebugEventHelper;
> import org.eclipse.dltk.internal.debug.core.model.ScriptDebugTarget;
> import org.eclipse.dltk.internal.launching.InterpreterMessages;
> import org.eclipse.dltk.launching.debug.DbgpInterpreterConfig;
>@@ -96,6 +98,9 @@
> 			// Starting debugging engine
> 			IProcess process = null;
> 			try {
>+				DebugEventHelper.fireExtendedEvent(newConfig,
>+						ExtendedDebugEventDetails.BEFORE_VM_STARTED);
>+
> 				// Running
> 				monitor.subTask("Running");
> 				process = rawRun(launch, newConfig);

Flags:

alex.panchenko: iplog+

Actions: View | Diff

Attachments on bug 207982: 85253