Attachment 82977 Details for Bug 209983 – patch for fixes that go in the eclipselink.core project

[patch] patch for fixes that go in the eclipselink.core project

209983-eclipselink.core.patch (text/plain), 2.38 KB, created by Tom Ware

on 2007-11-15 11:46:27 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Tom Ware

Created: 2007-11-15 11:46:27 EST

Size: 2.38 KB

patch

obsolete

>Index: src/org/eclipse/persistence/internal/databaseaccess/DatabasePlatform.java
>===================================================================
>--- src/org/eclipse/persistence/internal/databaseaccess/DatabasePlatform.java	(revision 3767)
>+++ src/org/eclipse/persistence/internal/databaseaccess/DatabasePlatform.java	(working copy)
>@@ -582,7 +582,7 @@
>             String name = (String)call.getProcedureArgumentNames().elementAt(index);
>             Object parameter = call.getParameters().elementAt(index);
>             Integer parameterType = (Integer)call.getParameterTypes().elementAt(index);
>-            if (name != null) {
>+            if (name != null && shouldPrintStoredProcedureArgumentNameInCall()) {
>                 writer.write(getProcedureArgumentString());
>                 writer.write(name);
>                 writer.write(getProcedureArgumentSetter());
>@@ -1581,6 +1581,17 @@
>         return false;
>     }
>     
>+    
>+    /**
>+     * INTERNAL:
>+     * Should the variable name of a stored procedure call be printed as part of the procedure call
>+     * e.g. EXECUTE PROCEDURE MyStoredProc(myvariable = ?)
>+     * @return
>+     */
>+    public boolean shouldPrintStoredProcedureArgumentNameInCall(){
>+	    return false;
>+    }
>+    
>     public boolean shouldTrimStrings() {
>         return shouldTrimStrings;
>     }
>Index: src/org/eclipse/persistence/platform/database/MySQL4Platform.java
>===================================================================
>--- src/org/eclipse/persistence/platform/database/MySQL4Platform.java	(revision 3767)
>+++ src/org/eclipse/persistence/platform/database/MySQL4Platform.java	(working copy)
>@@ -380,6 +380,16 @@
>     
>     /**
>      * INTERNAL:
>+     * MySQL stored procedure calls do not require the argument name be printed in the call string
>+     * e.g. call MyStoredProc(?) instead of call MyStoredProc(myvariable = ?)
>+     * @return
>+     */
>+    public boolean shouldPrintStoredProcedureArgumentNameInCall(){
>+	    return false;
>+    }
>+   
>+    /**
>+     * INTERNAL:
>      * MySQL uses ' to allow identifier to have spaces.
>      */
>     public String getIdentifierQuoteCharacter() {
>@@ -402,6 +412,13 @@
>     }
>     
>     /**
>+     * Used for sp calls.
>+     */
>+    public String getProcedureCallHeader() {
>+        return "CALL ";
>+    }
>+    
>+    /**
>      * INTERNAL:
>      * MySQL requires the direction at the start of the argument.
>      */

Actions: View | Diff

Attachments on bug 209983: 82976 | 82977 | 82988