Attachment 8118 Details for Bug 48990 – Part two of the patch for handling of if(false)

[patch] Part two of the patch for handling of if(false)

patch.txt (text/plain), 1.18 KB, created by Eric Bodden

on 2004-02-24 03:53:57 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Bodden

Created: 2004-02-24 03:53:57 EST

Size: 1.18 KB

patch

obsolete

>Index: IfPseudoToken.java
>===================================================================
>retrieving revision 1.4
>diff -u -r1.4 IfPseudoToken.java
>--- IfPseudoToken.java	26 Feb 2003 10:57:59 -0000	1.4
>+++ IfPseudoToken.java	24 Feb 2004 08:40:16 -0000
>@@ -23,6 +23,7 @@
> import org.eclipse.jdt.internal.compiler.CompilationResult;
> import org.eclipse.jdt.internal.compiler.ast.Argument;
> import org.eclipse.jdt.internal.compiler.ast.Expression;
>+import org.eclipse.jdt.internal.compiler.ast.FalseLiteral;
> import org.eclipse.jdt.internal.compiler.ast.MethodDeclaration;
> import org.eclipse.jdt.internal.compiler.ast.ReturnStatement;
> import org.eclipse.jdt.internal.compiler.ast.Statement;
>@@ -77,6 +78,10 @@
> //			"if pcd is not implemented in 1.1alpha1");
> 		//XXX need to implement correctly
> 		if (pointcut == null) return;
>+		//if the expression is just "false", then there is no need to
>+		//generate that method
>+		//hint: This behaviour here is also exploited by IfPointcut.fastMatch !
>+		if (this.expr.getClass()==FalseLiteral.class) return;
> 		testMethod = makeMethod(enclosingDec.compilationResult, enclosingDec);
> 		AstUtil.addMethodDeclaration(typeDec, testMethod);
> 	}

Flags:

wayne.beaton: iplog+

Actions: View | Diff

Attachments on bug 48990: 8114 | 8118