Attachment 80059 Details for Bug 195823 – Proposed fix

[patch] Proposed fix

patch_195823.txt (text/plain), 2.16 KB, created by Olivier Thomann

on 2007-10-10 11:40:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2007-10-10 11:40:32 EDT

Size: 2.16 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: search/org/eclipse/jdt/internal/core/search/indexing/BinaryIndexer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/BinaryIndexer.java,v
>retrieving revision 1.62
>diff -u -r1.62 BinaryIndexer.java
>--- search/org/eclipse/jdt/internal/core/search/indexing/BinaryIndexer.java	27 Apr 2007 15:51:39 -0000	1.62
>+++ search/org/eclipse/jdt/internal/core/search/indexing/BinaryIndexer.java	10 Oct 2007 15:39:20 -0000
>@@ -10,6 +10,7 @@
>  *******************************************************************************/
> package org.eclipse.jdt.internal.core.search.indexing;
> 
>+import org.eclipse.jdt.core.JavaCore;
> import org.eclipse.jdt.core.Signature;
> import org.eclipse.jdt.core.compiler.CharOperation;
> import org.eclipse.jdt.core.search.SearchDocument;
>@@ -749,13 +750,17 @@
> 		} catch (ClassFormatException e) {
> 			// ignore
> 			this.document.removeAllIndexEntries();
>-			Util.log(e, "ClassFormatException in " + this.document.getPath() + ". Please report this issue to JDT/Core including the problematic document"); //$NON-NLS-1$ //$NON-NLS-2$
>+			if (JavaCore.getPlugin().isDebugging()) {
>+				Util.log(e, "ClassFormatException in " + this.document.getPath() + ". Please report this issue to JDT/Core including the problematic document"); //$NON-NLS-1$ //$NON-NLS-2$
>+			}
> 		} catch (RuntimeException e) {
> 			// https://bugs.eclipse.org/bugs/show_bug.cgi?id=182154
> 			// logging the entry that could not be indexed and continue with the next one
> 			// we remove all entries relative to the boggus document
> 			this.document.removeAllIndexEntries();
>-			Util.log(e, "Indexer crashed on document " + this.document.getPath() + ". Please report this issue to JDT/Core including the problematic document"); //$NON-NLS-1$ //$NON-NLS-2$
>+			if (JavaCore.getPlugin().isDebugging()) {
>+				Util.log(e, "Indexer crashed on document " + this.document.getPath() + ". Please report this issue to JDT/Core including the problematic document"); //$NON-NLS-1$ //$NON-NLS-2$
>+			}
> 		}
> 	}
> 	/*

Actions: View | Diff

Attachments on bug 195823: 73490 | 73491 | 80059