Attachment 79438 Details for Bug 91047 – Patch to wrap the dialog code within BusyIndicator's showWhile(Display, Runnable) method.

[patch] Patch to wrap the dialog code within BusyIndicator's showWhile(Display, Runnable) method.

about-dialog-patch.txt (text/plain), 1.97 KB, created by Remy Suen

on 2007-09-29 09:07:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2007-09-29 09:07:27 EDT

Size: 1.97 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java,v
>retrieving revision 1.25
>diff -u -r1.25 AboutDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java	8 May 2006 20:55:46 -0000	1.25
>+++ Eclipse UI/org/eclipse/ui/internal/dialogs/AboutDialog.java	29 Sep 2007 13:06:16 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2006 IBM Corporation and others.
>+ * Copyright (c) 2000, 2007 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -110,14 +110,22 @@
>     protected void buttonPressed(int buttonId) {
>         switch (buttonId) {
>         case FEATURES_ID:
>-            new AboutFeaturesDialog(getShell(), productName, bundleGroupInfos)
>-                    .open();
>+			BusyIndicator.showWhile(getShell().getDisplay(), new Runnable() {
>+				public void run() {
>+		            new AboutFeaturesDialog(getShell(), productName, bundleGroupInfos)
>+		                    .open();
>+				}
>+			});
>             break;
>         case PLUGINS_ID:
>-            new AboutPluginsDialog(getShell(), productName).open();
>+			BusyIndicator.showWhile(getShell().getDisplay(), new Runnable() {
>+				public void run() {
>+		            new AboutPluginsDialog(getShell(), productName).open();
>+				}
>+			});
>             break;
>         case INFO_ID:
>-			BusyIndicator.showWhile(null, new Runnable() {
>+			BusyIndicator.showWhile(getShell().getDisplay(), new Runnable() {
> 				public void run() {
> 		            new AboutSystemDialog(getShell()).open();
> 				}

Actions: View | Diff

Attachments on bug 91047: 79438