Attachment 79140 Details for Bug 204564 – creating the right watch expression

[patch] creating the right watch expression

patch.txt (text/plain), 1.49 KB, created by Johan Compagner

on 2007-09-25 11:39:56 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Johan Compagner

Created: 2007-09-25 11:39:56 EDT

Size: 1.49 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.dltk.javascript.debug.ui
>Index: src/org/eclipse/dltk/javascript/internal/debug/ui/JavaScriptToggleBreakpointAdapter.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.dltk/javascript/plugins/org.eclipse.dltk.javascript.debug.ui/src/org/eclipse/dltk/javascript/internal/debug/ui/JavaScriptToggleBreakpointAdapter.java,v
>retrieving revision 1.2
>diff -u -r1.2 JavaScriptToggleBreakpointAdapter.java
>--- src/org/eclipse/dltk/javascript/internal/debug/ui/JavaScriptToggleBreakpointAdapter.java	24 Jul 2007 08:08:58 -0000	1.2
>+++ src/org/eclipse/dltk/javascript/internal/debug/ui/JavaScriptToggleBreakpointAdapter.java	25 Sep 2007 15:32:03 -0000
>@@ -168,14 +168,18 @@
> 								.getLength());
> 
> 						int index = string.indexOf('=');
>-						string = string.substring(0, index);
>-						index = string.lastIndexOf('.') + 1;
>+						if (index != -1)
>+						{
>+							string = string.substring(0, index);
>+						}
>+						index = string.lastIndexOf('.');
> 						if (index != -1) {
>-							string = string.substring(index);
>+							string = string.substring(index + 1);
> 						}
>-						index = string.lastIndexOf(' ' + 1);
>+						string = string.trim();
>+						index = string.lastIndexOf(' ');
> 						if (index != -1) {
>-							string = string.substring(index).trim();
>+							string = string.substring(index + 1).trim();
> 						}
> 
> 						BreakpointUtils.addWatchPoint(textEditor, lineNumber,

Flags:

alex.panchenko: iplog+

Actions: View | Diff

Attachments on bug 204564: 79140 | 79141