Attachment 73623 Details for Bug 192329 – patch that meets the additional requirement in comment 3

[patch] patch that meets the additional requirement in comment 3

patch192329b.txt (text/plain), 1.72 KB, created by Adam Archer

on 2007-07-12 00:10:56 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adam Archer

Created: 2007-07-12 00:10:56 EDT

Size: 1.72 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.ui
>Index: src/org/eclipse/pde/internal/ui/editor/schema/SchemaElementDetails.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/schema/SchemaElementDetails.java,v
>retrieving revision 1.20
>diff -u -r1.20 SchemaElementDetails.java
>--- src/org/eclipse/pde/internal/ui/editor/schema/SchemaElementDetails.java	11 Jul 2007 22:41:46 -0000	1.20
>+++ src/org/eclipse/pde/internal/ui/editor/schema/SchemaElementDetails.java	12 Jul 2007 04:09:50 -0000
>@@ -98,11 +98,12 @@
> 		fDepTrue.setSelection(fElement.isDeprecated());
> 		fDepFalse.setSelection(!fElement.isDeprecated());
> 		
>-		boolean hasCompositor = false;
>-		if (fElement.getType() instanceof ISchemaComplexType &&
>-				((ISchemaComplexType)fElement.getType()).getCompositor() != null)
>-			hasCompositor = true;
>-		if (hasCompositor)
>+		boolean isTranslatable = true;
>+		if ((fElement.getType() instanceof ISchemaComplexType &&
>+				((ISchemaComplexType)fElement.getType()).getCompositor() != null) ||
>+				fElement.getAttributeCount() != 0)
>+			isTranslatable = false;
>+		if (!isTranslatable)
> 			fElement.setTranslatableProperty(false);
> 		fTransTrue.setSelection(fElement.hasTranslatableContent());
> 		fTransFalse.setSelection(!fElement.hasTranslatableContent());
>@@ -114,8 +115,8 @@
> 		
> 		fDepTrue.setEnabled(editable);
> 		fDepFalse.setEnabled(editable);
>-		fTransTrue.setEnabled(editable && !hasCompositor);
>-		fTransFalse.setEnabled(editable && !hasCompositor);
>+		fTransTrue.setEnabled(editable && isTranslatable);
>+		fTransFalse.setEnabled(editable && isTranslatable);
> 	}
> 
> 	public void hookListeners() {

Flags:

mike.pawlowski: review+

Actions: View | Diff

Attachments on bug 192329: 73600 | 73623