Attachment 70432 Details for Bug 191391 – Proposed fix

[patch] Proposed fix

properties_multiselect_copy_191391.txt (text/plain), 2.47 KB, created by Ted Williams

on 2007-06-06 18:02:50 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ted Williams

Created: 2007-06-06 18:02:50 EDT

Size: 2.47 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.views
>Index: src/org/eclipse/ui/views/properties/PropertySheetViewer.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetViewer.java,v
>retrieving revision 1.32
>diff -u -r1.32 PropertySheetViewer.java
>--- src/org/eclipse/ui/views/properties/PropertySheetViewer.java	8 May 2006 20:53:18 -0000	1.32
>+++ src/org/eclipse/ui/views/properties/PropertySheetViewer.java	6 Jun 2007 22:01:47 -0000
>@@ -115,8 +115,7 @@
>      *            the parent control
>      */
>     public PropertySheetViewer(Composite parent) {
>-        tree = new Tree(parent, SWT.FULL_SELECTION | SWT.SINGLE
>-                | SWT.HIDE_SELECTION);
>+        tree = new Tree(parent, SWT.FULL_SELECTION | SWT.MULTI);
> 
>         // configure the widget
>         tree.setLinesVisible(true);
>Index: src/org/eclipse/ui/views/properties/CopyPropertyAction.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/CopyPropertyAction.java,v
>retrieving revision 1.14
>diff -u -r1.14 CopyPropertyAction.java
>--- src/org/eclipse/ui/views/properties/CopyPropertyAction.java	8 May 2006 20:53:18 -0000	1.14
>+++ src/org/eclipse/ui/views/properties/CopyPropertyAction.java	6 Jun 2007 22:01:46 -0000
>@@ -55,15 +55,23 @@
>         if (selection.isEmpty()) {
> 			return;
> 		}
>-        // Assume single selection
>-        IPropertySheetEntry entry = (IPropertySheetEntry) selection
>-                .getFirstElement();
>-
>-        // Place text on the clipboard
>+        
>         StringBuffer buffer = new StringBuffer();
>-        buffer.append(entry.getDisplayName());
>-        buffer.append("\t"); //$NON-NLS-1$
>-        buffer.append(entry.getValueAsString());
>+        
>+        Object selectionItems[] = selection.toArray();
>+        for(int i = 0; i < selectionItems.length; i++)
>+        {
>+        	// Each entry should start on a new line
>+        	if(buffer.length() > 0)
>+        		buffer.append("\n"); //$NON-NLS-1$
>+        	
>+	        IPropertySheetEntry entry = (IPropertySheetEntry) selectionItems[i];
>+	
>+	        // Place text on the clipboard
>+	        buffer.append(entry.getDisplayName());
>+	        buffer.append("\t"); //$NON-NLS-1$
>+	        buffer.append(entry.getValueAsString());
>+        }
> 
>         setClipboard(buffer.toString());
>     }

Actions: View | Diff

Attachments on bug 191391: 70432