Attachment 63763 Details for Bug 181729 – patch to address the stack (re)ordering issue

patch to address the stack (re)ordering issue

patch(181729) (text/plain), 2.20 KB, created by Eric Moffatt

on 2007-04-13 11:21:20 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Moffatt

Created: 2007-04-13 11:21:20 EDT

Size: 2.20 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/PartStack.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartStack.java,v
>retrieving revision 1.99
>diff -u -r1.99 PartStack.java
>--- Eclipse UI/org/eclipse/ui/internal/PartStack.java	11 Apr 2007 13:09:53 -0000	1.99
>+++ Eclipse UI/org/eclipse/ui/internal/PartStack.java	13 Apr 2007 15:19:26 -0000
>@@ -1077,22 +1077,31 @@
>                     .getCompoundId());
> 		}
> 
>-        Iterator iter = children.iterator();
>+        // Write out the presentable parts (in order)
>+        Iterator iter = getPresentableParts().iterator();
>         while (iter.hasNext()) {
>-            LayoutPart next = (LayoutPart) iter.next();
>+            PresentablePart presPart = (PresentablePart) iter.next();
> 
>             IMemento childMem = memento
>                     .createChild(IWorkbenchConstants.TAG_PAGE);
>+            PartPane part = presPart.getPane();
>+            String tabText = part.getPartReference().getPartName();
> 
>-            PartPane part = null;
>-            if (next instanceof PartPane) {
>-                part = (PartPane)next;
>-            }
>+            childMem.putString(IWorkbenchConstants.TAG_LABEL, tabText);
>+            childMem.putString(IWorkbenchConstants.TAG_CONTENT, presPart.getPane().getPlaceHolderId());
>+        }
>+
>+        // Write out the placeholders
>+        Iterator layoutIiter = children.iterator();
>+        while (layoutIiter.hasNext()) {
>+            LayoutPart next = (LayoutPart) layoutIiter.next();
>+            if (next instanceof PartPane)
>+            	continue;
>+            
>+            IMemento childMem = memento
>+                    .createChild(IWorkbenchConstants.TAG_PAGE);
> 
>             String tabText = "LabelNotFound"; //$NON-NLS-1$ 
>-            if (part != null) {
>-                tabText = part.getPartReference().getPartName();
>-            }
>             childMem.putString(IWorkbenchConstants.TAG_LABEL, tabText);
>             childMem.putString(IWorkbenchConstants.TAG_CONTENT, next
>                     .getCompoundId());

Actions: View

Attachments on bug 181729: 63763