Attachment 57830 Details for Bug 172204 – patch to LegacyCompletionProposalComputer

[patch] patch to LegacyCompletionProposalComputer

patch172204v1.txt (text/plain), 1.71 KB, created by Bryan Wilkinson

on 2007-01-30 13:53:26 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Bryan Wilkinson

Created: 2007-01-30 13:53:26 EST

Size: 1.71 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.cdt.ui
>Index: src/org/eclipse/cdt/internal/ui/text/contentassist/LegacyCompletionProposalComputer.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/text/contentassist/LegacyCompletionProposalComputer.java,v
>retrieving revision 1.1
>diff -u -r1.1 LegacyCompletionProposalComputer.java
>--- src/org/eclipse/cdt/internal/ui/text/contentassist/LegacyCompletionProposalComputer.java	24 Jan 2007 16:11:48 -0000	1.1
>+++ src/org/eclipse/cdt/internal/ui/text/contentassist/LegacyCompletionProposalComputer.java	30 Jan 2007 18:44:21 -0000
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     Anton Leherbauer (Wind River Systems) - initial API and implementation
>+ *     Bryan Wilkinson (QNX)
>  *******************************************************************************/
> 
> package org.eclipse.cdt.internal.ui.text.contentassist;
>@@ -137,13 +138,17 @@
> 			int paren= scanner.findOpeningPeer(pos, bound, '(', ')');
> 			if (paren == CHeuristicScanner.NOT_FOUND)
> 				break;
>-			int token= scanner.previousToken(paren - 1, bound);
>+			paren= scanner.findNonWhitespaceBackward(paren - 1, bound);
>+			if (paren == CHeuristicScanner.NOT_FOUND) {
>+				break;
>+			}
>+			int token= scanner.previousToken(paren, bound);
> 			// next token must be a method name (identifier) or the closing angle of a
> 			// constructor call of a template type.
> 			if (token == Symbols.TokenIDENT || token == Symbols.TokenGREATERTHAN) {
>-				return paren - 1;
>+				return paren + 1;
> 			}
>-			pos= paren - 1;
>+			pos= paren;
> 		} while (true);
> 		
> 		return context.getInvocationOffset();

Flags:

bjorn.freeman-benson: iplog+

Actions: View | Diff

Attachments on bug 172204: 57830