Attachment 54642 Details for Bug 166068 – Patch for ColorsAndFontsPropertySection

[patch] Patch for ColorsAndFontsPropertySection

colorsandfontspropertysectionreadonly (text/plain), 1.97 KB, created by Wayne

on 2006-11-28 11:13:10 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Wayne

Created: 2006-11-28 11:13:10 EST

Size: 1.97 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gmf.runtime.diagram.ui.properties
>Index: src/org/eclipse/gmf/runtime/diagram/ui/properties/sections/appearance/ColorsAndFontsPropertySection.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.diagram.ui.properties/src/org/eclipse/gmf/runtime/diagram/ui/properties/sections/appearance/ColorsAndFontsPropertySection.java,v
>retrieving revision 1.19
>diff -u -r1.19 ColorsAndFontsPropertySection.java
>--- src/org/eclipse/gmf/runtime/diagram/ui/properties/sections/appearance/ColorsAndFontsPropertySection.java	23 Nov 2006 21:11:54 -0000	1.19
>+++ src/org/eclipse/gmf/runtime/diagram/ui/properties/sections/appearance/ColorsAndFontsPropertySection.java	28 Nov 2006 16:08:11 -0000
>@@ -307,15 +307,6 @@
>         });
> 		fillColorButton.setEnabled(false);
> 
>-		if (isReadOnly()) {
>-			lineColorButton.setEnabled(false);
>-			fontFamilyCombo.setEnabled(false);
>-			fontSizeCombo.setEnabled(false);
>-			fontBoldButton.setEnabled(false);
>-			fontItalicButton.setEnabled(false);
>-			fontColorButton.setEnabled(false);
>-		}
>-
> 		return toolBar;
> 	}
> 
>@@ -593,10 +584,14 @@
> 				IGraphicalEditPart ep = getSingleInput();
> 				if (ep != null) {
> 
>+                    boolean isReadOnly = isReadOnly();
>+                    lineColorButton.setEnabled(!isReadOnly);
>+                    fillColorButton.setEnabled(!isReadOnly);
>+
> 					Style style = ep.getNotationView().getStyle(NotationPackage.eINSTANCE.getFontStyle());
>-					boolean enableFontWidgets = style != null;
>-					
>-					fontFamilyCombo.setEnabled(enableFontWidgets);
>+					boolean enableFontWidgets = (style != null) && !isReadOnly;
>+                    
>+                    fontFamilyCombo.setEnabled(enableFontWidgets);
> 					fontSizeCombo.setEnabled(enableFontWidgets);
> 					fontBoldButton.setEnabled(enableFontWidgets);
> 					fontItalicButton.setEnabled(enableFontWidgets);

Actions: View | Diff

Attachments on bug 166068: 54642