Attachment 42047 Details for Bug 142808 – Possible update to the AbstractEditHelper

[patch] Possible update to the AbstractEditHelper

edit-helper-update.patch (text/plain), 1.33 KB, created by Christian Damus

on 2006-05-19 13:39:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Damus

Created: 2006-05-19 13:39:27 EDT

Size: 1.33 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gmf.runtime.emf.type.core
>Index: src/org/eclipse/gmf/runtime/emf/type/core/edithelper/AbstractEditHelper.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.emf.type.core/src/org/eclipse/gmf/runtime/emf/type/core/edithelper/AbstractEditHelper.java,v
>retrieving revision 1.12
>diff -u -r1.12 AbstractEditHelper.java
>--- src/org/eclipse/gmf/runtime/emf/type/core/edithelper/AbstractEditHelper.java	17 May 2006 14:00:28 -0000	1.12
>+++ src/org/eclipse/gmf/runtime/emf/type/core/edithelper/AbstractEditHelper.java	19 May 2006 17:40:23 -0000
>@@ -320,7 +320,9 @@
> 	 */
> 	protected ICompositeCommand createCommand(IEditCommandRequest req) {
> 		
>-		return new CompositeTransactionalCommand(req.getEditingDomain(), req.getLabel()) {
>+		CompositeTransactionalCommand result = new CompositeTransactionalCommand(
>+				req.getEditingDomain(),
>+				req.getLabel()) {
> 			
> 			/**
> 			 * Extracts the first return value out of the collection of return
>@@ -352,6 +354,12 @@
> 				return result;
> 			};
> 		};
>+		
>+		// commands (esp. destroy) are expected to be large nested structures,
>+		//   because there can be many discrete particles of advice
>+		result.setTransactionNestingEnabled(false);
>+		
>+		return result;
> 	}
> 
> 	/**

Actions: View | Diff

Attachments on bug 142808: 42047