Attachment 38987 Details for Bug 137613 – Patch to DataModelSynchHelper

[patch] Patch to DataModelSynchHelper

patch.txt (text/plain), 1.52 KB, created by Daniel Berg

on 2006-04-19 17:33:36 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Berg

Created: 2006-04-19 17:33:36 EDT

Size: 1.52 KB

patch

obsolete

>Index: wtp_ui/org/eclipse/wst/common/frameworks/internal/datamodel/ui/DataModelSynchHelper.java
>===================================================================
>RCS file: /cvsroot/webtools/wst/components/common/plugins/org.eclipse.wst.common.frameworks.ui/wtp_ui/org/eclipse/wst/common/frameworks/internal/datamodel/ui/DataModelSynchHelper.java,v
>retrieving revision 1.8
>diff -u -r1.8 DataModelSynchHelper.java
>--- wtp_ui/org/eclipse/wst/common/frameworks/internal/datamodel/ui/DataModelSynchHelper.java	5 Apr 2006 19:39:27 -0000	1.8
>+++ wtp_ui/org/eclipse/wst/common/frameworks/internal/datamodel/ui/DataModelSynchHelper.java	19 Apr 2006 21:20:53 -0000
>@@ -214,6 +214,9 @@
> 					try {
> 						currentWidget = (Widget) propertyToWidgetHash.get(propertyName);
> 						if (currentWidget != null && currentWidget != currentWidgetFromEvent) {
>+							//We must hold a copy in a temp variable because setting the widget value
>+							//may trigger an event that will cause this method to be called again.
>+							Widget widget = currentWidget;
> 							try {
> 								if (currentWidget instanceof Text)
> 									setWidgetValue(propertyName, flag, (Text) currentWidget);
>@@ -232,7 +235,8 @@
> 							} finally {
> 								ignoreModifyEvent = false;
> 							}
>-							setEnablement((Control) currentWidget, dataModel.isPropertyEnabled(propertyName));
>+							//Pass the copy of the currentWidget
>+							setEnablement((Control) widget, dataModel.isPropertyEnabled(propertyName));
> 						}
> 					} finally {
> 						currentWidget = null;

Actions: View | Diff

Attachments on bug 137613: 38987