Attachment 36337 Details for Bug 131762 – Reconciler tests: Explicitly specify user changes that can not be handled correctly now

[patch] Reconciler tests: Explicitly specify user changes that can not be handled correctly now

patch_131762_tests.txt (text/plain), 2.27 KB, created by Michael Golubev

on 2006-03-15 10:26:03 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Golubev

Created: 2006-03-15 10:26:03 EST

Size: 2.27 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.gmf.tests
>Index: src/org/eclipse/gmf/tests/gen/CodegenReconcileTest.java
>===================================================================
>RCS file: /cvsroot/technology/org.eclipse.gmf/tests/org.eclipse.gmf.tests/src/org/eclipse/gmf/tests/gen/CodegenReconcileTest.java,v
>retrieving revision 1.2
>diff -u -r1.2 CodegenReconcileTest.java
>--- src/org/eclipse/gmf/tests/gen/CodegenReconcileTest.java	15 Mar 2006 15:17:01 -0000	1.2
>+++ src/org/eclipse/gmf/tests/gen/CodegenReconcileTest.java	15 Mar 2006 15:26:00 -0000
>@@ -105,9 +105,10 @@
> 		myEditorGen = diaGenSetup.getGenDiagram().getEditorGen();
> 			
> 		class ListLayoutChange extends Assert implements UserChange {
>-			//FIXME: "MyCanonicalEditPolicy" or "MyGraphiclNodeEditPolicy" will break the magic
> 			private final String NEW_CANONICAL_EP = "MyCanonicalPolicy";
> 			private final String NEW_GRAPHICAL_EP = "MyGraphicalPolicy";
>+			private final String BAD_CANONICAL_EP = "MyCanonicalEditPolicy"; //changed but still follows "(.*)CanonicalEditPolicy" pattern
>+			private final String BAD_GRAPHICAL_EP = "MyGraphicalNodeEditPolicy"; //changed but still follows "(.*)GraphicalNodeEditPolicy" pattern
> 			
> 			public void applyChanges(GenEditorGenerator old) {
> 				EList oldNodes = old.getDiagram().getAllNodes();
>@@ -120,6 +121,9 @@
> 				
> 				nodeA.setCanonicalEditPolicyClassName(NEW_CANONICAL_EP);
> 				nodeA.setGraphicalNodeEditPolicyClassName(NEW_GRAPHICAL_EP);
>+				
>+				nodeB.setCanonicalEditPolicyClassName(BAD_CANONICAL_EP);
>+				nodeB.setGraphicalNodeEditPolicyClassName(BAD_GRAPHICAL_EP);
> 			}
> 			
> 			public void assertChangesPreserved(GenEditorGenerator current) {
>@@ -133,6 +137,11 @@
> 				
> 				assertEquals(NEW_CANONICAL_EP, nodeA.getCanonicalEditPolicyClassName());
> 				assertEquals(NEW_GRAPHICAL_EP, nodeA.getGraphicalNodeEditPolicyClassName());
>+				
>+				//FIXME: the checks below handle the problem with string-pattern reconciling approach
>+				//remove this checks when we will be able to reconcile this correctly
>+				assertFalse(BAD_CANONICAL_EP.equals(nodeB.getCanonicalEditPolicyClassName()));
>+				assertFalse(BAD_GRAPHICAL_EP.equals(nodeB.getGraphicalNodeEditPolicyClassName()));
> 			}
> 			
> 			public ReconcilerConfigBase getReconcilerConfig() {

Actions: View | Diff

Attachments on bug 131762: 36259 | 36337