Attachment 286014 Details for Bug 570670 – 7_fix_handle_garbagecleaner_overflow_on_large_dumps

[patch] 7_fix_handle_garbagecleaner_overflow_on_large_dumps

7_fix_handle_garbagecleaner_overflow_on_large_dumps.patch (text/plain), 1.29 KB, created by Jason Koch

on 2021-04-01 00:26:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jason Koch

Created: 2021-04-01 00:26:33 EDT

Size: 1.29 KB

patch

obsolete

>diff --git a/plugins/org.eclipse.mat.parser/src/org/eclipse/mat/parser/internal/GarbageCleaner.java b/plugins/org.eclipse.mat.parser/src/org/eclipse/mat/parser/internal/GarbageCleaner.java
>index eff72754..2f917a0e 100644
>--- a/plugins/org.eclipse.mat.parser/src/org/eclipse/mat/parser/internal/GarbageCleaner.java
>+++ b/plugins/org.eclipse.mat.parser/src/org/eclipse/mat/parser/internal/GarbageCleaner.java
>@@ -587,9 +587,10 @@ import org.eclipse.mat.util.SilentProgressListener;
>                 return directCompute();
> 
>             // fork to left/right half, then merge
>-            int middle = (start + end) / 2;
>-            GarbageHistogramTask left = new GarbageHistogramTask(idx, reachable, start, middle);
>-            GarbageHistogramTask right = new GarbageHistogramTask(idx, reachable, middle, end);
>+            // do this calc as a long, otherwise, overflow causes problems
>+            long middle = ((long)start + (long)end) / 2L;
>+            GarbageHistogramTask left = new GarbageHistogramTask(idx, reachable, start, (int)middle);
>+            GarbageHistogramTask right = new GarbageHistogramTask(idx, reachable, (int)middle, end);
>             left.fork();
>             HashMap<Integer, Record> rightMap = right.compute();
>             HashMap<Integer, Record> leftMap = left.join();

Actions: View | Diff

Attachments on bug 570670: 285390 | 285391 | 285392 | 285393 | 285394 | 285395 | 286012 | 286013 | 286014 | 286359 | 286512