Attachment 279097 Details for Bug 539637 – Adding all bundles for the same id can cause problems

[patch] Adding all bundles for the same id can cause problems

temp_code.patch (text/plain), 1.39 KB, created by Vikas Chandra

on 2019-06-26 08:36:43 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Vikas Chandra

Created: 2019-06-26 08:36:43 EDT

Size: 1.39 KB

patch

obsolete

>diff --git a/ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java b/ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java
>index 811c9ef..9f4472b 100644
>--- a/ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java
>+++ b/ui/org.eclipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java
>@@ -164,14 +164,23 @@
> 
> 			// Get all required plugins
> 			Set<String> additionalIds = DependencyManager.getDependencies(launchPlugins.toArray(), false, null);
>+			IPluginModelBase[] allModels = PluginModelManager.getInstance().getAllModels();
> 			Iterator<String> it = additionalIds.iterator();
> 			while (it.hasNext()) {
> 				String id = it.next();
> 				ModelEntry modelEntry = PluginRegistry.findEntry(id);
> 				if (modelEntry != null) {
> 					IPluginModelBase model = findModel(modelEntry, null, defaultPluginResolution);
>-					if (model != null)
>+					if (model != null) {
> 						launchPlugins.add(model);
>+						for (int i = 0; i < allModels.length; i++) {
>+							IPluginModelBase iPluginModelBase = allModels[i];
>+							String modelId = iPluginModelBase.getPluginBase().getId();
>+							if (modelId.equals(id) && !launchPlugins.contains(iPluginModelBase)) {
>+								launchPlugins.add(iPluginModelBase);
>+							}
>+						}
>+					}
> 				}
> 			}
>

Actions: View | Diff

Attachments on bug 539637: 276849 | 279097 | 287201