Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 270265 Details for
Bug 377169
[1.5][compiler] Doesn't report name clash error in weird code that overrides erased method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
[patch]
experimental change for illustration
MethodVerifier15.patch (text/plain), 1.42 KB, created by
Stephan Herrmann
on 2017-09-19 11:08:06 EDT
(
hide
)
Description:
experimental change for illustration
Filename:
MIME Type:
Creator:
Stephan Herrmann
Created:
2017-09-19 11:08:06 EDT
Size:
1.42 KB
patch
obsolete
>diff --git a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java >index 5f5c784..d1822d7 100644 >--- a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java >+++ b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java >@@ -803,12 +803,12 @@ > return false; > // skip it if otherInherited is defined by a subtype of inherited's declaringClass or vice versa. > // avoid being order sensitive and check with the roles reversed also. >- if (TypeBinding.notEquals(inherited.declaringClass.erasure(), otherInherited.declaringClass.erasure())) { >- if (inherited.declaringClass.findSuperTypeOriginatingFrom(otherInherited.declaringClass) != null) >- return false; >- if (otherInherited.declaringClass.findSuperTypeOriginatingFrom(inherited.declaringClass) != null) >- return false; >- } >+// if (TypeBinding.notEquals(inherited.declaringClass.erasure(), otherInherited.declaringClass.erasure())) { >+// if (inherited.declaringClass.findSuperTypeOriginatingFrom(otherInherited.declaringClass) != null) >+// return false; >+// if (otherInherited.declaringClass.findSuperTypeOriginatingFrom(inherited.declaringClass) != null) >+// return false; >+// } > > problemReporter().inheritedMethodsHaveNameClash(this.type, inherited, otherInherited); > return true;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 377169
: 270265