Attachment 26124 Details for Bug 89599 – org.eclipse.ui.workbench.texteditor.patch

[patch] org.eclipse.ui.workbench.texteditor.patch

org.eclipse.ui.workbench.texteditor.patch (text/plain), 1.56 KB, created by Susan McCourt

on 2005-08-15 15:58:13 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Susan McCourt

Created: 2005-08-15 15:58:13 EDT

Size: 1.56 KB

patch

obsolete

>Index: src/org/eclipse/ui/texteditor/AbstractTextEditor.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java,v
>retrieving revision 1.182
>diff -u -r1.182 AbstractTextEditor.java
>--- src/org/eclipse/ui/texteditor/AbstractTextEditor.java	1 Jun 2005 13:21:30 -0000	1.182
>+++ src/org/eclipse/ui/texteditor/AbstractTextEditor.java	15 Aug 2005 19:52:58 -0000
>@@ -2643,10 +2643,16 @@
> 
> 		createNavigationActions();
> 		createAccessibilityActions();
>-		createUndoRedoActions();
> 		createActions();
> 
> 		initializeSourceViewer(getEditorInput());
>+		
>+		/* since 3.2 - undo redo actions should be created after 
>+		 * the source viewer is initialized, so that the undo manager
>+		 * can obtain its undo context from its document.
>+		 */
>+		createUndoRedoActions();
>+
> 
> 		JFaceResources.getFontRegistry().addListener(fFontPropertyChangeListener);
> 	}
>@@ -3013,6 +3019,9 @@
> 				initializeSourceViewer(input);
> 
> 				// Reset the undo context for the undo and redo action handlers
>+				// Since 3.2 this must occur after the source viewer is initialized
>+				// for the new input, so that the undo context is obtained from the
>+				// new document.
> 				IAction undoAction= getAction(ITextEditorActionConstants.UNDO);
> 				IAction redoAction= getAction(ITextEditorActionConstants.REDO);
> 				boolean areOperationActionHandlersInstalled= undoAction instanceof OperationHistoryActionHandler && redoAction instanceof OperationHistoryActionHandler;

Actions: View | Diff

Attachments on bug 89599: 26122 | 26123 | 26124 | 26125 | 26126 | 26127 | 26542 | 26543 | 26544