Attachment 227312 Details for Bug 346230 – Patch

[patch] Patch

Bug-346230-clean-up-.patch (text/plain), 1.54 KB, created by Noopur Gupta

on 2013-02-20 00:48:09 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Noopur Gupta

Created: 2013-02-20 00:48:09 EST

Size: 1.54 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeStyleFix.java b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeStyleFix.java
>index b9c8f56..6af7932 100644
>--- a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeStyleFix.java
>+++ b/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/fix/CodeStyleFix.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2011 IBM Corporation and others.
>+ * Copyright (c) 2000, 2013 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -12,6 +12,7 @@
> 
> import java.util.ArrayList;
> import java.util.HashMap;
>+import java.util.Iterator;
> import java.util.List;
> 
> import org.eclipse.core.runtime.CoreException;
>@@ -655,6 +656,14 @@
> 
> 					Expression qualifier= op.fQualifier;
> 					if (!(qualifier instanceof MethodInvocation) || !isMethodArgument(qualifier)) {
>+						for (Iterator<CompilationUnitRewriteOperation> it= result.iterator(); it.hasNext();) { // see bug: 346230
>+							CompilationUnitRewriteOperation oper= it.next();
>+							if (oper instanceof CodeStyleFix.AddThisQualifierOperation
>+									&& ((CodeStyleFix.AddThisQualifierOperation) oper).fName.equals(qualifier)) {
>+								result.remove(oper);
>+								break;
>+							}
>+						}
> 						result.add(op);
> 					}
> 				}

Actions: View | Diff

Attachments on bug 346230: 195957 | 195958 | 195959 | 195960 | 195961 | 195962 | 195966 | 227312