Attachment 227236 Details for Bug 393143 – Proposed Fix.

[patch] Proposed Fix.

eclipse.jdt.ui.393143_20130219.patch (text/plain), 2.06 KB, created by Martin Mathew

on 2013-02-19 04:12:06 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Mathew

Created: 2013-02-19 04:12:06 EST

Size: 2.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>diff --git ui/org/eclipse/jdt/internal/ui/infoviews/AbstractInfoView.java ui/org/eclipse/jdt/internal/ui/infoviews/AbstractInfoView.java
>index 76559d3..390d80f 100644
>--- ui/org/eclipse/jdt/internal/ui/infoviews/AbstractInfoView.java
>+++ ui/org/eclipse/jdt/internal/ui/infoviews/AbstractInfoView.java
>@@ -410,8 +410,8 @@
> 	protected void setLinkingEnabled(boolean enabled) {
> 		fLinking= enabled;
> 
>-		if (fLinking && fLastSelectionProvider != null) {
>-			computeAndSetInput(fLastSelectionProvider);
>+		if (fLinking && fCurrentViewInput != null) {
>+			setInput(fCurrentViewInput);
> 		}
> 	}
> 
>@@ -434,6 +434,8 @@
> 
> 		fLastSelectionProvider= part;
> 
>+		if (!selection.isEmpty())
>+			fCurrentViewInput= findSelectedJavaElement(part, selection);
> 		if (fLinking)
> 			computeAndSetInput(part);
> 	}
>diff --git ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java
>index 7a11720..7e9cb8d 100644
>--- ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java
>+++ ui/org/eclipse/jdt/internal/ui/infoviews/JavadocView.java
>@@ -321,9 +321,28 @@
> 		@Override
> 		public void run() {
> 			setLinkingEnabled(!isLinkingEnabled());
>+			JavaPluginImages.setLocalImageDescriptors(fToggleLinkAction, "synced.gif"); //$NON-NLS-1$
> 		}
> 	}
> 
>+	@Override
>+	public void selectionChanged(IWorkbenchPart part, ISelection selection) {
>+		super.selectionChanged(part, selection);
>+		updateLinkActionImage();
>+	}
>+
>+
>+	private void updateLinkActionImage() {
>+		if (isLinkingEnabled()) {
>+			//for an invalid input, change the icon
>+			if (fCurrentViewInput != null && !fCurrentViewInput.exists()) {
>+				JavaPluginImages.setLocalImageDescriptors(fToggleLinkAction, "sync_broken.gif"); //$NON-NLS-1$
>+			} else {
>+				JavaPluginImages.setLocalImageDescriptors(fToggleLinkAction, "synced.gif"); //$NON-NLS-1$
>+			}
>+		}
>+	}
>+	
> 	/**
> 	 * Action to open the selection in an external browser. If the selection is a java element its
> 	 * corresponding javadoc is shown if possible. If it is an URL the URL's content is shown.

Actions: View | Diff

Attachments on bug 393143: 227236 | 227237 | 227243 | 227314 | 227403 | 227542 | 227582