Attachment 218470 Details for Bug 383400 – change to take into account review

[patch] change to take into account review

ChangeId-I7222e16b9edfda161e34fad37338a35217916c7d.patch (text/plain), 2.62 KB, created by Carsten Hammer

on 2012-07-09 18:22:41 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carsten Hammer

Created: 2012-07-09 18:22:41 EDT

Size: 2.62 KB

patch

obsolete

>From afe6e929109f62957db6a3dceb161a3942791f7f Tue, 10 Jul 2012 00:21:52 +0200
>From: carsten hammer <carsten.hammer@oce.com>
>Date: Tue, 10 Jul 2012 00:03:44 +0200
>Subject: [PATCH] Change-Id: I7222e16b9edfda161e34fad37338a35217916c7d
>
>
>diff --git a/org.eclipse.mylyn.wikitext.mediawiki.core/src/org/eclipse/mylyn/internal/wikitext/mediawiki/core/tasks/MediaWikiApiImageFetchingStrategy.java b/org.eclipse.mylyn.wikitext.mediawiki.core/src/org/eclipse/mylyn/internal/wikitext/mediawiki/core/tasks/MediaWikiApiImageFetchingStrategy.java
>index 3c32ca5..efaa2d0 100644
>--- a/org.eclipse.mylyn.wikitext.mediawiki.core/src/org/eclipse/mylyn/internal/wikitext/mediawiki/core/tasks/MediaWikiApiImageFetchingStrategy.java
>+++ b/org.eclipse.mylyn.wikitext.mediawiki.core/src/org/eclipse/mylyn/internal/wikitext/mediawiki/core/tasks/MediaWikiApiImageFetchingStrategy.java
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2007, 2010 David Green and others.
>+ * Copyright (c) 2007, 2012 David Green and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -75,6 +75,7 @@
> 		final SAXParserFactory parserFactory = SAXParserFactory.newInstance();
> 		parserFactory.setNamespaceAware(true);
> 		parserFactory.setValidating(false);
>+		int maxloop = 100;
> 		do {
> 			contentHandler.setGimcontinue(null);
> 			URL apiUrl;
>@@ -119,7 +120,7 @@
> 				throw new BuildException("Cannot configure SAX parser", e); //$NON-NLS-1$
> 			}
> 
>-		} while (gimcontinue != null);
>+		} while (gimcontinue != null && maxloop-- > 0);
> 		int fileCount = 0;
> 		for (Map.Entry<String, String> ent : contentHandler.imageTitleToUrl.entrySet()) {
> 			String title = ent.getKey();
>@@ -181,14 +182,6 @@
> 
> 	private class ImageFetchingContentHandler implements ContentHandler {
> 
>-		public void setGimcontinue(String gimcontinue) {
>-			this.gimcontinue = gimcontinue;
>-		}
>-
>-		public String getGimcontinue() {
>-			return gimcontinue;
>-		}
>-
> 		private final Map<String, String> imageTitleToUrl = new HashMap<String, String>();
> 
> 		private String currentPage = null;
>@@ -197,6 +190,14 @@
> 
> 		private String gimcontinue = null;
> 
>+		public void setGimcontinue(String gimcontinue) {
>+			this.gimcontinue = gimcontinue;
>+		}
>+
>+		public String getGimcontinue() {
>+			return gimcontinue;
>+		}
>+
> 		public void startElement(String uri, String localName, String qName, Attributes atts) throws SAXException {
> 			if ("page".equals(localName)) { //$NON-NLS-1$
> 				currentPage = atts.getValue("title"); //$NON-NLS-1$

Actions: View | Diff

Attachments on bug 383400: 218470 | 218471