Attachment 21631 Details for Bug 96140 – cleaned up code, ignore previous patch please

[patch] cleaned up code, ignore previous patch please

[b#96140][052405]org.eclipse.pde.ui_[DependenciesView]_patch.txt (text/plain), 2.33 KB, created by Janek Lasocki-Biczysko

on 2005-05-24 11:35:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Janek Lasocki-Biczysko

Created: 2005-05-24 11:35:46 EDT

Size: 2.33 KB

patch

obsolete

>Index: src/org/eclipse/pde/internal/ui/view/DependenciesView.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/view/DependenciesView.java,v
>retrieving revision 1.28
>diff -u -r1.28 DependenciesView.java
>--- src/org/eclipse/pde/internal/ui/view/DependenciesView.java	13 Apr 2005 18:51:49 -0000	1.28
>+++ src/org/eclipse/pde/internal/ui/view/DependenciesView.java	24 May 2005 15:35:12 -0000
>@@ -14,12 +14,10 @@
> import java.util.HashMap;
> import java.util.Map;
> 
>-import org.eclipse.core.runtime.IConfigurationElement;
> import org.eclipse.core.runtime.Preferences;
> import org.eclipse.jface.action.Action;
> import org.eclipse.jface.action.IToolBarManager;
> import org.eclipse.jface.action.Separator;
>-import org.eclipse.osgi.util.NLS;
> import org.eclipse.pde.core.plugin.IPlugin;
> import org.eclipse.pde.core.plugin.IPluginModel;
> import org.eclipse.pde.core.plugin.IPluginModelBase;
>@@ -530,31 +528,7 @@
> 	}
> 
> 	void updateTitle(Object newInput) {
>-		if (newInput == null
>-				|| newInput.equals(PDECore.getDefault().getModelManager())) {
>-			IConfigurationElement config = getConfigurationElement();
>-			if (config == null)
>-				return;
>-			String viewName = config.getAttribute("name"); //$NON-NLS-1$
>-			setContentDescription(viewName);
>-		} else {
>-			String name = PDEPlugin.getDefault().getLabelProvider().getText(
>-					newInput);
>-			String title;
>-			if (getCurrentContributingPart() == PART_CALLEES_TREE) {
>-				title = NLS.bind(PDEUIMessages.DependenciesView_callees_tree_title, name); //$NON-NLS-1$
>-			} else if (getCurrentContributingPart() == PART_CALLEES_LIST) {
>-				title = NLS.bind(PDEUIMessages.DependenciesView_callees_list_title, name); //$NON-NLS-1$
>-			} else if (getCurrentContributingPart() == PART_CALLERS_TREE) {
>-				title = NLS.bind(PDEUIMessages.DependenciesView_callers_tree_title, name); //$NON-NLS-1$
>-			} else {
>-				title = NLS.bind(PDEUIMessages.DependenciesView_callers_list_title, name); //$NON-NLS-1$
>-			}
>-			if(fLoops != NO_LOOPS){
>-				title = title + " " + PDEUIMessages.DependenciesView_cycles_title; //$NON-NLS-1$
>-			}
>-			setContentDescription(title); //$NON-NLS-1$
>-		}
>+		// Not setting content title since it is a duplicate of the actual title
> 		setTitleToolTip(getTitle());
> 	}
>

Actions: View | Diff

Attachments on bug 96140: 21520 | 21626 | 21631 | 21649