Attachment 212874 Details for Bug 372319 – proposed fix

[patch] proposed fix

Bug_372319.patch (text/plain), 1.39 KB, created by Stephan Herrmann

on 2012-03-19 15:25:22 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Stephan Herrmann

Created: 2012-03-19 15:25:22 EDT

Size: 1.39 KB

patch

obsolete

>diff --git a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/FakedTrackingVariable.java b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/FakedTrackingVariable.java
>index 4ac6c2f..404f065 100644
>--- a/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/FakedTrackingVariable.java
>+++ b/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/FakedTrackingVariable.java
>@@ -529,15 +529,17 @@
> 	 */
> 	private int getNullStatusAggressively(LocalVariableBinding local, FlowInfo flowInfo) {
> 		int reachMode = flowInfo.reachMode();
>-		int status = 0;
>-		try {
>-			// unreachable flowInfo is too shy in reporting null-issues, temporarily forget reachability:
>-			if (reachMode != FlowInfo.REACHABLE)
>-				flowInfo.tagBits &= ~FlowInfo.UNREACHABLE;
>-			status = flowInfo.nullStatus(local);
>-		} finally {
>-			// reset
>-			flowInfo.tagBits |= reachMode;
>+		int status = FlowInfo.UNKNOWN;
>+		if (flowInfo != FlowInfo.DEAD_END) {
>+			try {
>+				// unreachable flowInfo is too shy in reporting null-issues, temporarily forget reachability:
>+				if (reachMode != FlowInfo.REACHABLE)
>+					flowInfo.tagBits &= ~FlowInfo.UNREACHABLE;
>+				status = flowInfo.nullStatus(local);
>+			} finally {
>+				// reset
>+				flowInfo.tagBits |= reachMode;
>+			}
> 		}
> 		// at this point some combinations are not useful so flatten to a single bit:
> 		if ((status & FlowInfo.NULL) != 0) {

Actions: View | Diff

Attachments on bug 372319: 211937 | 212011 | 212154 | 212156 | 212432 | 212620 | 212729 | 212822 | 212874 | 212880 | 212884