Attachment 210187 Details for Bug 296631 – Fixes missing updates on change of debug options

[patch] Fixes missing updates on change of debug options

UpdateOptionChange.patch (text/plain), 1.42 KB, created by Christian Georgi

on 2012-01-27 10:05:08 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Christian Georgi

Created: 2012-01-27 10:05:08 EST

Size: 1.42 KB

patch

obsolete

>From 8dcf5c782416e52a72805e2ce1a7ed8a79ca1a1c Fri, 27 Jan 2012 15:59:04 +0100
>From: Christian Georgi <christian.georgi@sap.com>
>Date: Fri, 27 Jan 2012 15:58:49 +0100
>Subject: [PATCH] Update debug options state correctly in case of boolean option change
>
>diff --git a/ui/org.eclipse.ui.trace/src/org/eclipse/ui/trace/internal/datamodel/ModifiedDebugOptions.java b/ui/org.eclipse.ui.trace/src/org/eclipse/ui/trace/internal/datamodel/ModifiedDebugOptions.java
>index 0f9f2d9..809df9e 100644
>--- a/ui/org.eclipse.ui.trace/src/org/eclipse/ui/trace/internal/datamodel/ModifiedDebugOptions.java
>+++ b/ui/org.eclipse.ui.trace/src/org/eclipse/ui/trace/internal/datamodel/ModifiedDebugOptions.java
>@@ -64,10 +64,9 @@
> 			if (isBeingRemoved) {
> 				// remove it from the list of debug options to remove
> 				this.debugOptionsToRemove.remove(option);
>-			} else {
>-				// add it to the list of debug options to add
>-				this.debugOptionsToAdd.add(option);
> 			}
>+			// add it to the list of debug options to add
>+			this.debugOptionsToAdd.add(option);
> 		}
> 	}
> 
>@@ -84,10 +83,9 @@
> 			if (isBeingAdded) {
> 				// remove it from the list of debug options to add
> 				this.debugOptionsToAdd.remove(option);
>-			} else {
>-				// add it to the list of debug options to remove
>-				this.debugOptionsToRemove.add(option);
> 			}
>+			// add it to the list of debug options to remove
>+			this.debugOptionsToRemove.add(option);
> 		}
> 	}
>

Actions: View | Diff

Attachments on bug 296631: 153534 | 153535 | 153536 | 158239 | 158757 | 161156 | 161203 | 161204 | 210187