Attachment 200400 Details for Bug 351509 – Proposed patch and testcase

[patch] Proposed patch and testcase

Bug351509.patch (text/plain), 4.68 KB, created by David Minsky

on 2011-07-26 17:16:11 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Minsky

Created: 2011-07-26 17:16:11 EDT

Size: 4.68 KB

patch

obsolete

>Index: foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/QueryFrameworkTestSuite.java
>===================================================================
>--- foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/QueryFrameworkTestSuite.java	(revision 9783)
>+++ foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/QueryFrameworkTestSuite.java	(working copy)
>@@ -63,6 +63,8 @@
>         addTest(buildArgumentValuesTest());
>         addTest(new ScrollableCursorForwardOnlyResultSetTest()); // Bug 309142
>         addTest(new ConformResultsSubclassesTest()); // Bug 327900
>+        // Bug 351509
>+        addTest(new ScrollableCursorJoinedAttributeTest());
>     }
> 
>     //SRG test set is maintained by QA only, do NOT add any new test cases into it.
>Index: foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/ScrollableCursorJoinedAttributeTest.java
>===================================================================
>--- foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/ScrollableCursorJoinedAttributeTest.java	(revision 0)
>+++ foundation/eclipselink.core.test/src/org/eclipse/persistence/testing/tests/queries/ScrollableCursorJoinedAttributeTest.java	(revision 0)
>@@ -0,0 +1,57 @@
>+package org.eclipse.persistence.testing.tests.queries;
>+
>+import java.util.Vector;
>+
>+import org.eclipse.persistence.queries.ReadAllQuery;
>+import org.eclipse.persistence.queries.ScrollableCursor;
>+
>+import org.eclipse.persistence.testing.framework.TestCase;
>+import org.eclipse.persistence.testing.models.employee.domain.Employee;
>+
>+/**
>+ * Test using a Scrollable Cursor with a simple joined attribute.
>+ * Bug 351509 - Null Pointer Exception when using Scrollable Cursor on a OneToMany Mapping 
>+ */
>+public class ScrollableCursorJoinedAttributeTest extends TestCase {
>+    
>+    protected ReadAllQuery query;
>+    protected int nonCursoredResults;
>+    protected int cursoredResults;
>+    
>+    public ScrollableCursorJoinedAttributeTest() {
>+        super();
>+        setDescription("Scrollable Cursor Test incorporating a joined attribute");
>+    }
>+    
>+    public void setup() {
>+        query = new ReadAllQuery(Employee.class);
>+        query.dontCheckCache();
>+        query.doNotCacheQueryResults();
>+        query.addJoinedAttribute(query.getExpressionBuilder().anyOfAllowingNone("phoneNumbers"));
>+        Vector results = (Vector)getSession().executeQuery(query);
>+        nonCursoredResults = results.size();
>+    }
>+    
>+    public void test() {
>+        query.useScrollableCursor();
>+        ScrollableCursor results = (ScrollableCursor)getSession().executeQuery(query);
>+        while (results.hasNext()) {
>+            Object result = results.next();
>+            cursoredResults++;
>+        }
>+        results.close();
>+    }
>+    
>+    public void verify() {
>+        assertNotSame("Test data for non-cursored results should be nonzero", 0, nonCursoredResults);
>+        assertNotSame("Test data for cursored results should be nonzero", 0, cursoredResults);
>+        assertEquals("cursored and non-cursored results should be the same",  nonCursoredResults, cursoredResults) ;
>+    }
>+    
>+    public void reset() {
>+        this.query = null;
>+        this.cursoredResults = 0;
>+        this.nonCursoredResults = 0;
>+    }
>+
>+}
>Index: foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/queries/ScrollableCursor.java
>===================================================================
>--- foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/queries/ScrollableCursor.java	(revision 9783)
>+++ foundation/org.eclipse.persistence.core/src/org/eclipse/persistence/queries/ScrollableCursor.java	(working copy)
>@@ -550,6 +550,12 @@
>                 row = this.nextRow;
>                 this.nextRow = null;
>             }
>+            
>+            this.position = currentPosition + 1;  // bug 309142
>+            if (row == null) {
>+                return null;
>+            }
>+            
>             // If using 1-m joining need to fetch 1-m rows as well.
>             if (this.query.isObjectLevelReadQuery() && ((ObjectLevelReadQuery)this.query).hasJoining()) {
>                 JoinedAttributeManager joinManager = ((ObjectLevelReadQuery)this.query).getJoinedAttributeManager();
>@@ -558,12 +564,6 @@
>                 }
>             }
>             
>-            this.position = currentPosition + 1;  // bug 309142
>-            
>-            if (row == null) { 
>-                return null;
>-            }
>-
>             Object object = buildAndRegisterObject(row);
>             if (object == InvalidObject.instance) {
>                 continue;

Actions: View | Diff

Attachments on bug 351509: 199306 | 200400 | 205852 | 205859 | 205864