Attachment 197852 Details for Bug 349003 – Patch fixing this bug

[patch] Patch fixing this bug

clipboard.txt (text/plain), 2.20 KB, created by Abner Ballardo

on 2011-06-12 02:34:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Abner Ballardo

Created: 2011-06-12 02:34:51 EDT

Size: 2.20 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java,v
>retrieving revision 1.26
>diff -u -r1.26 OpenTaskAction.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java	8 Jun 2010 23:10:08 -0000	1.26
>+++ src/org/eclipse/mylyn/internal/tasks/ui/actions/OpenTaskAction.java	12 Jun 2011 06:32:35 -0000
>@@ -43,13 +43,14 @@
> 			return;
> 		}
> 
>-		Object result = dlg.getFirstResult();
>-		if (result instanceof ITask) {
>-			AbstractTask task = (AbstractTask) result;
>-			if (dlg.getOpenInBrowser()) {
>-				TasksUiUtil.openWithBrowser(task);
>-			} else {
>-				TasksUiInternal.refreshAndOpenTaskListElement(task);
>+		for (Object result : dlg.getResult()) {
>+			if (result instanceof ITask) {
>+				AbstractTask task = (AbstractTask) result;
>+				if (dlg.getOpenInBrowser()) {
>+					TasksUiUtil.openWithBrowser(task);
>+				} else {
>+					TasksUiInternal.refreshAndOpenTaskListElement(task);
>+				}
> 			}
> 		}
> 	}
>Index: src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java,v
>retrieving revision 1.57
>diff -u -r1.57 TaskSelectionDialog.java
>--- src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java	3 Mar 2011 00:27:54 -0000	1.57
>+++ src/org/eclipse/mylyn/internal/tasks/ui/actions/TaskSelectionDialog.java	12 Jun 2011 06:32:37 -0000
>@@ -429,7 +429,7 @@
> 	private final TaskActivationHistory taskActivationHistory;
> 
> 	public TaskSelectionDialog(Shell parent) {
>-		super(parent);
>+		super(parent, true);
> 		this.taskActivationHistory = TasksUiPlugin.getTaskActivityManager().getTaskActivationHistory();
> 		this.history = new LinkedHashSet<AbstractTask>(taskActivationHistory.getPreviousTasks());
> 		this.itemsComparator = new TaskHistoryItemsComparator(new ArrayList<AbstractTask>(history));

Flags:

eclipse: iplog+

Actions: View | Diff

Attachments on bug 349003: 197852 | 197853 | 197874 | 197875 | 211217