Attachment 19197 Details for Bug 69647 – The patch with getExternalBrowser()

[patch] The patch with getExternalBrowser()

org.eclipse.ui.workbench-patch.txt (text/plain), 4.30 KB, created by Dejan Glozic

on 2005-03-25 14:03:54 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Dejan Glozic

Created: 2005-03-25 14:03:54 EST

Size: 4.30 KB

patch

obsolete

>Index: Eclipse UI/org/eclipse/ui/browser/AbstractWorkbenchBrowserSupport.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/browser/AbstractWorkbenchBrowserSupport.java,v
>retrieving revision 1.1
>diff -u -r1.1 AbstractWorkbenchBrowserSupport.java
>--- Eclipse UI/org/eclipse/ui/browser/AbstractWorkbenchBrowserSupport.java	23 Mar 2005 16:42:49 -0000	1.1
>+++ Eclipse UI/org/eclipse/ui/browser/AbstractWorkbenchBrowserSupport.java	25 Mar 2005 19:00:43 -0000
>@@ -10,6 +10,8 @@
>  *******************************************************************************/
> package org.eclipse.ui.browser;
> 
>+import org.eclipse.ui.PartInitException;
>+
> /**
>  * Implements <code>IWorkbenchBrowserSupport</code> while leaving some methods
>  * to the implementors. Classes that extend this abstract class are meant to be
>@@ -19,10 +21,17 @@
>  */
> public abstract class AbstractWorkbenchBrowserSupport implements
> 		IWorkbenchBrowserSupport {
>-
>+	private static final String SHARED_EXTERNAL_BROWSER_ID = "org.eclipse.ui.externalBrowser"; //$NON-NLS-1$
> 	/**
> 	 * The default constructor.
> 	 */
> 	public AbstractWorkbenchBrowserSupport() {
> 	}
>-}
>+
>+	/* (non-Javadoc)
>+	 * @see org.eclipse.ui.browser.IWorkbenchBrowserSupport#getExternalBrowser()
>+	 */
>+	public IWebBrowser getExternalBrowser() throws PartInitException {
>+		return createBrowser(AS_EXTERNAL, SHARED_EXTERNAL_BROWSER_ID, null, null);
>+	}
>+}
>\ No newline at end of file
>Index: Eclipse UI/org/eclipse/ui/browser/IWorkbenchBrowserSupport.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/browser/IWorkbenchBrowserSupport.java,v
>retrieving revision 1.2
>diff -u -r1.2 IWorkbenchBrowserSupport.java
>--- Eclipse UI/org/eclipse/ui/browser/IWorkbenchBrowserSupport.java	25 Mar 2005 16:03:23 -0000	1.2
>+++ Eclipse UI/org/eclipse/ui/browser/IWorkbenchBrowserSupport.java	25 Mar 2005 19:00:43 -0000
>@@ -99,12 +99,6 @@
> 	 * browsers and the user didn't set the preference to external browsers.
> 	 */
> 	int AS_EXTERNAL = 1 << 7;
>-	
>-	/**
>-	 * A unique identifier that can be used when reusing an shared default web
>-	 * browser is desirable (value &quot;org.eclipse.ui.defualtBrowser&quot;).
>-	 */
>-	String DEFAULT_BROWSER_ID = "org.eclipse.ui.defaultBrowser"; //$NON-NLS-1$
> 
> 	/**
> 	 * Creates the new web browser instance. If the user has chosen to use the
>@@ -166,4 +160,19 @@
> 	 *                if the operation failed for some reason
> 	 */
> 	IWebBrowser createBrowser(String browserId) throws PartInitException;
>-}
>+
>+	/**
>+	 * Returns a shared instance of the external web browser. Clients can use it
>+	 * to share one external browser. The external browser that will be used is
>+	 * subject to browser support implementation. A suggested implementation is
>+	 * to use the operating system's default browser. Implementations that offer
>+	 * users a choice of the web browser should honour the users choice of
>+	 * external browser, with the initial selection being the system default
>+	 * browser.
>+	 * 
>+	 * @return the shared instance of the external browser
>+	 * @exception PartInitException
>+	 *                if the operation failed for some reason
>+	 */
>+	IWebBrowser getExternalBrowser() throws PartInitException;
>+}
>\ No newline at end of file
>Index: Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java,v
>retrieving revision 1.2
>diff -u -r1.2 WorkbenchBrowserSupport.java
>--- Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java	24 Mar 2005 21:24:11 -0000	1.2
>+++ Eclipse UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java	25 Mar 2005 19:00:44 -0000
>@@ -33,7 +33,7 @@
>  * 
>  * @since 3.1
>  */
>-public class WorkbenchBrowserSupport implements IWorkbenchBrowserSupport {
>+public class WorkbenchBrowserSupport extends AbstractWorkbenchBrowserSupport {
> 	private static final String BROWSER_SUPPORT_EXTENSION_ID = "org.eclipse.ui.browserSupport"; //$NON-NLS-1$
> 
> 	private static final String EL_SUPPORT = "support"; //$NON-NLS-1$

Actions: View | Diff

Attachments on bug 69647: 19084 | 19086 | 19187 | 19197 | 19262