Attachment 189232 Details for Bug 175655 – delay drawing when mouse is moving fast

[patch] delay drawing when mouse is moving fast

clipboard.txt (text/plain), 2.94 KB, created by Sam Davis

on 2011-02-17 16:29:40 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Davis

Created: 2011-02-17 16:29:40 EST

Size: 2.94 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.context.ui
>Index: src/org/eclipse/mylyn/internal/context/ui/FilteredChildrenDecorationDrawer.java
>===================================================================
>RCS file: /cvsroot/mylyn/org.eclipse.mylyn.contexts/org.eclipse.mylyn.context.ui/src/org/eclipse/mylyn/internal/context/ui/FilteredChildrenDecorationDrawer.java,v
>retrieving revision 1.4
>diff -u -r1.4 FilteredChildrenDecorationDrawer.java
>--- src/org/eclipse/mylyn/internal/context/ui/FilteredChildrenDecorationDrawer.java	16 Feb 2011 00:38:17 -0000	1.4
>+++ src/org/eclipse/mylyn/internal/context/ui/FilteredChildrenDecorationDrawer.java	17 Feb 2011 21:20:19 -0000
>@@ -18,6 +18,7 @@
> import org.eclipse.swt.widgets.ToolTip;
> import org.eclipse.swt.widgets.Tree;
> import org.eclipse.swt.widgets.TreeItem;
>+import org.eclipse.ui.PlatformUI;
> 
> /**
>  * @author Mik Kersten
>@@ -29,6 +30,12 @@
> 
> 		private TreeItem lastItem;
> 
>+		private TreeItem currentItem;
>+
>+		private long lastMoveTime;
>+
>+		private long startMoveTime;
>+
> 		private final TreeViewer viewer;
> 
> 		private final BrowseFilteredListener browseFilteredListener;
>@@ -114,23 +126,41 @@
> 				return;
> 			}
> 			Tree tree = (Tree) e.widget;
>-			TreeItem item = findItem(tree, e.y);
>+			final TreeItem item = findItem(tree, e.y);
> 			if (item != null && !item.isDisposed()) {
> 				if (lastItem != null && !lastItem.isDisposed() && !lastItem.equals(item)) {
>+					boolean redraw = lastItem.getData(ID_HOVER) != NodeState.LESS;
> 					lastItem.setData(ID_HOVER, NodeState.LESS);
>+					if (redraw) {// hide the + immediately
>+						redrawTree(lastItem);
>+					}
> 				}
>-
>-				if (item.getData(ID_HOVER) != NodeState.MORE_ERROR) {
>-					item.setData(ID_HOVER, NodeState.MORE);
>-				}
>-				if (lastItem == null || (!lastItem.isDisposed() && !lastItem.equals(item))) {
>-					redrawTree(lastItem);
>+				currentItem = item;
>+				long currentTime = System.currentTimeMillis();
>+				if (currentTime - lastMoveTime > 250) {// user paused movement
>+					startMoveTime = currentTime;
> 				}
>-				lastItem = item;
>+				lastMoveTime = currentTime;
>+				// be responsive for small moves but delay more for bigger ones
>+				int delay = Math.min(100, (int) ((currentTime - startMoveTime) / 4.0));
>+				PlatformUI.getWorkbench().getDisplay().timerExec(delay, new Runnable() {
>+					public void run() {// do nothing if we aren't using the most recent item
>+						if (currentItem == item && !item.isDisposed()) {
>+							if (item.getData(ID_HOVER) != NodeState.MORE_ERROR) {
>+								item.setData(ID_HOVER, NodeState.MORE);
>+							}
>+							if (lastItem == null || (!lastItem.isDisposed() && !lastItem.equals(item))) {
>+								redrawTree(lastItem);
>+								redrawTree(item);
>+							}
>+							lastItem = item;
>+						}
>+					}
>+				});
> 			} else {
> 				if (lastItem != null && !lastItem.isDisposed() && !lastItem.equals(item)) {
> 					lastItem.setData(ID_HOVER, NodeState.LESS);

Flags:

shawn.minto: iplog+

Actions: View | Diff

Attachments on bug 175655: 95148 | 188864 | 188865 | 188935 | 188936 | 188948 | 188949 | 188965 | 188966 | 189205 | 189232 | 189452