Attachment 186774 Details for Bug 334306 – Proposed fix

[patch] Proposed fix

patch_334306.txt (text/plain), 1.62 KB, created by Olivier Thomann

on 2011-01-13 15:16:35 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2011-01-13 15:16:35 EST

Size: 1.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java,v
>retrieving revision 1.121
>diff -u -r1.121 MethodVerifier15.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java	17 Dec 2010 06:40:13 -0000	1.121
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/MethodVerifier15.java	13 Jan 2011 20:11:45 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2010 IBM Corporation and others.
>+ * Copyright (c) 2000, 2011 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -235,7 +235,11 @@
> 	//		class A implements I<Integer> { public void test(Integer i) {} }
> 	//		class B extends A { public void test(Comparable i) {} }
> 
>-	if (currentMethod.declaringClass.isInterface() || inheritedMethod.isStatic()) return;
>+	if (currentMethod.declaringClass.isInterface() || inheritedMethod.isStatic()) {
>+		if (this.environment.globalOptions.complianceLevel <= ClassFileConstants.JDK1_6) {
>+			return;
>+		}
>+	}
> 
> 	if (!detectNameClash(currentMethod, inheritedMethod, false)) { // check up the hierarchy for skipped inherited methods
> 		TypeBinding[] currentParams = currentMethod.parameters;

Actions: View | Diff

Attachments on bug 334306: 186774 | 186775 | 195734