Attachment 182924 Details for Bug 287123 – proposed fix for the null initializer case

[patch] proposed fix for the null initializer case

joindecl.txt (text/plain), 1.23 KB, created by Deepak Azad

on 2010-11-11 12:44:21 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Deepak Azad

Created: 2010-11-11 12:44:21 EST

Size: 1.23 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.ui
>Index: ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java,v
>retrieving revision 1.164
>diff -u -r1.164 QuickAssistProcessor.java
>--- ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java	9 Sep 2010 19:03:57 -0000	1.164
>+++ ui/org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessor.java	11 Nov 2010 17:37:58 -0000
>@@ -474,7 +474,8 @@
> 		}
> 
> 		IVariableBinding binding= fragment.resolveBinding();
>-		if (fragment.getInitializer() != null || binding == null || binding.isField()) {
>+		Expression initializer= fragment.getInitializer();
>+		if ((initializer != null && initializer.getNodeType() != ASTNode.NULL_LITERAL) || binding == null || binding.isField()) {
> 			return false;
> 		}
> 
>@@ -548,7 +549,8 @@
> 			return false;
> 		}
> 
>-		if (fragment.getInitializer() == null) {
>+		Expression initializer= fragment.getInitializer();
>+		if (initializer == null || initializer.getNodeType() == ASTNode.NULL_LITERAL) {
> 			return false;
> 		}
>

Actions: View | Diff

Attachments on bug 287123: 182924 | 182946 | 183903