Attachment 173743 Details for Bug 219589 – Proposed fix

[patch] Proposed fix

219589.patch (text/plain), 1.27 KB, created by Anton Leherbauer

on 2010-07-08 03:41:57 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Anton Leherbauer

Created: 2010-07-08 03:41:57 EDT

Size: 1.27 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tm.terminal
>Index: src/org/eclipse/tm/internal/terminal/textcanvas/TextCanvas.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.core/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/textcanvas/TextCanvas.java,v
>retrieving revision 1.20
>diff -u -r1.20 TextCanvas.java
>--- src/org/eclipse/tm/internal/terminal/textcanvas/TextCanvas.java	4 Jun 2010 13:37:23 -0000	1.20
>+++ src/org/eclipse/tm/internal/terminal/textcanvas/TextCanvas.java	8 Jul 2010 07:36:26 -0000
>@@ -162,10 +162,13 @@
> 	void setSelection(Point p) {
> 		if (fDraggingStart !=null && !p.equals(fDraggingEnd)) {
> 			fDraggingEnd = p;
>+			// bug 219589 - make sure selection bounds are non-negative
>+			int endColumn = Math.max(p.x, 0);
>+			int endRow = Math.max(p.y, 0);
> 			if (compare(p, fDraggingStart) < 0) {
>-				fCellCanvasModel.setSelection(p.y, fDraggingStart.y, p.x, fDraggingStart.x);
>+				fCellCanvasModel.setSelection(endRow, fDraggingStart.y, endColumn, fDraggingStart.x);
> 			} else {
>-				fCellCanvasModel.setSelection(fDraggingStart.y, p.y, fDraggingStart.x, p.x);
>+				fCellCanvasModel.setSelection(fDraggingStart.y, endRow, fDraggingStart.x, endColumn);
> 
> 			}
> 		}

Actions: View | Diff

Attachments on bug 219589: 146616 | 146617 | 173743 | 173839