Attachment 169857 Details for Bug 306464 – Proposed fix + regression test

[patch] Proposed fix + regression test

patch_306464.txt (text/plain), 21.66 KB, created by Olivier Thomann

on 2010-05-25 13:02:11 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2010-05-25 13:02:11 EDT

Size: 21.66 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/ParameterizedMethodBinding.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/ParameterizedMethodBinding.java,v
>retrieving revision 1.30
>diff -u -r1.30 ParameterizedMethodBinding.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/ParameterizedMethodBinding.java	9 Feb 2010 05:14:15 -0000	1.30
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/ParameterizedMethodBinding.java	25 May 2010 16:46:10 -0000
>@@ -29,12 +29,15 @@
> 		super(
> 				originalMethod.modifiers,
> 				originalMethod.selector,
>-				 originalMethod.returnType,
>+				originalMethod.returnType,
> 				originalMethod.parameters,
> 				originalMethod.thrownExceptions,
> 				parameterizedDeclaringClass);
> 		this.originalMethod = originalMethod;
>-		this.tagBits = originalMethod.tagBits;
>+		/* missing type bit cannot be copied as is it might come from the return type or a parameter type that
>+		 * is substituted by a raw type.
>+		 */
>+		this.tagBits = originalMethod.tagBits & ~TagBits.HasMissingType;
> 
> 		final TypeVariableBinding[] originalVariables = originalMethod.typeVariables;
> 		Substitution substitution = null;
>@@ -61,13 +64,13 @@
> 					return !isStatic && parameterizedDeclaringClass.isRawSubstitution();
> 				}
> 				public TypeBinding substitute(TypeVariableBinding typeVariable) {
>-			        // check this variable can be substituted given copied variables
>-			        if (typeVariable.rank < length && originalVariables[typeVariable.rank] == typeVariable) {
>+					// check this variable can be substituted given copied variables
>+					if (typeVariable.rank < length && originalVariables[typeVariable.rank] == typeVariable) {
> 						return substitutedVariables[typeVariable.rank];
>-			        }
>-			        if (!isStatic)
>+					}
>+					if (!isStatic)
> 						return parameterizedDeclaringClass.substitute(typeVariable);
>-			        return typeVariable;
>+					return typeVariable;
> 				}
> 			};
> 
>@@ -105,8 +108,8 @@
> 			this.returnType = Scope.substitute(substitution, this.returnType);
> 			this.parameters = Scope.substitute(substitution, this.parameters);
> 			this.thrownExceptions = Scope.substitute(substitution, this.thrownExceptions);
>-		    // error case where exception type variable would have been substituted by a non-reference type (207573)
>-		    if (this.thrownExceptions == null) this.thrownExceptions = Binding.NO_EXCEPTIONS;
>+			// error case where exception type variable would have been substituted by a non-reference type (207573)
>+			if (this.thrownExceptions == null) this.thrownExceptions = Binding.NO_EXCEPTIONS;
> 		}
> 		checkMissingType: {
> 			if ((this.tagBits & TagBits.HasMissingType) != 0)
>@@ -143,7 +146,10 @@
> 				originalMethod.thrownExceptions,
> 				declaringClass);
> 		this.originalMethod = originalMethod;
>-		this.tagBits = originalMethod.tagBits;
>+		/* missing type bit cannot be copied as is it might come from the return type or a parameter type that
>+		 * is substituted by a raw type.
>+		 */
>+		this.tagBits = originalMethod.tagBits & ~TagBits.HasMissingType;
> 
> 		final TypeVariableBinding[] originalVariables = originalMethod.typeVariables;
> 		Substitution substitution = null;
>Index: compiler/org/eclipse/jdt/internal/compiler/lookup/RawTypeBinding.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/lookup/RawTypeBinding.java,v
>retrieving revision 1.40
>diff -u -r1.40 RawTypeBinding.java
>--- compiler/org/eclipse/jdt/internal/compiler/lookup/RawTypeBinding.java	6 Oct 2008 13:23:51 -0000	1.40
>+++ compiler/org/eclipse/jdt/internal/compiler/lookup/RawTypeBinding.java	25 May 2010 16:46:10 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2008 IBM Corporation and others.
>+ * Copyright (c) 2000, 2010 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -26,8 +26,30 @@
>      */
> 	public RawTypeBinding(ReferenceBinding type, ReferenceBinding enclosingType, LookupEnvironment environment){
> 		super(type, null, enclosingType, environment);
>-		if (enclosingType == null || (enclosingType.modifiers & ExtraCompilerModifiers.AccGenericSignature) == 0)
>+		this.tagBits &= ~TagBits.HasMissingType;
>+		if ((type.tagBits & TagBits.HasMissingType) != 0) {
>+			if (type instanceof MissingTypeBinding) {
>+				this.tagBits |= TagBits.HasMissingType;
>+			} else if (type instanceof ParameterizedTypeBinding) {
>+				ParameterizedTypeBinding parameterizedTypeBinding = (ParameterizedTypeBinding) type;
>+				if (parameterizedTypeBinding.genericType() instanceof MissingTypeBinding) {
>+					this.tagBits |= TagBits.HasMissingType;
>+				}
>+			}
>+		}
>+		if (enclosingType != null && (enclosingType.tagBits & TagBits.HasMissingType) != 0) {
>+			if (enclosingType instanceof MissingTypeBinding) {
>+				this.tagBits |= TagBits.HasMissingType;
>+			} else if (enclosingType instanceof ParameterizedTypeBinding) {
>+				ParameterizedTypeBinding parameterizedTypeBinding = (ParameterizedTypeBinding) enclosingType;
>+				if (parameterizedTypeBinding.genericType() instanceof MissingTypeBinding) {
>+					this.tagBits |= TagBits.HasMissingType;
>+				}
>+			}
>+		}
>+		if (enclosingType == null || (enclosingType.modifiers & ExtraCompilerModifiers.AccGenericSignature) == 0) {
> 			this.modifiers &= ~ExtraCompilerModifiers.AccGenericSignature; // only need signature if enclosing needs one
>+		}
> 	}
> 
> 	public char[] computeUniqueKey(boolean isLeaf) {
>#P org.eclipse.jdt.core.tests.compiler
>Index: src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java,v
>retrieving revision 1.819
>diff -u -r1.819 GenericTypeTest.java
>--- src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java	13 Apr 2010 06:25:01 -0000	1.819
>+++ src/org/eclipse/jdt/core/tests/compiler/regression/GenericTypeTest.java	25 May 2010 16:46:46 -0000
>@@ -31,7 +31,7 @@
> 	// All specified tests which does not belong to the class are skipped...
> 	static {
> //		TESTS_NAMES = new String[] { "test1245" };
>-//		TESTS_NUMBERS = new int[] { 1460 };
>+//		TESTS_NUMBERS = new int[] { 1461 };
> //		TESTS_RANGE = new int[] { 1097, -1 };
> 	}
> 	public static Test suite() {
>@@ -50165,4 +50165,323 @@
> 		"Cannot perform instanceof check against parameterized type Test<A>.MyEntry. Use the form Test.MyEntry instead since further generic type information will be erased at runtime\n" + 
> 		"----------\n");
> }
>+//https://bugs.eclipse.org/bugs/show_bug.cgi?id=306464
>+public void test1461() {
>+	this.runNegativeTest(
>+		new String[] {
>+			"JoinImpl.java",
>+			"import javax.persistence.criteria.Expression;\n" + 
>+			"import javax.persistence.criteria.Fetch;\n" + 
>+			"import javax.persistence.criteria.From;\n" + 
>+			"import javax.persistence.criteria.Join;\n" + 
>+			"import javax.persistence.criteria.JoinType;\n" + 
>+			"import javax.persistence.criteria.Path;\n" + 
>+			"import javax.persistence.metamodel.Attribute;\n" + 
>+			"import javax.persistence.metamodel.Bindable;\n" + 
>+			"import javax.persistence.metamodel.ManagedType;\n" + 
>+			"import javax.persistence.metamodel.Metamodel;\n" + 
>+			"public class JoinImpl<Z, X> extends FromImpl<Z, X> implements Join<Z, X>, Fetch<Z, X> {\n" + 
>+			"}",
>+			"FromImpl.java",
>+			"import java.util.ArrayList;\n" + 
>+			"import java.util.HashSet;\n" + 
>+			"import java.util.List;\n" + 
>+			"import java.util.Set;\n" + 
>+			"import java.util.Stack;\n" + 
>+			"\n" + 
>+			"import javax.persistence.criteria.CollectionJoin;\n" + 
>+			"import javax.persistence.criteria.Expression;\n" + 
>+			"import javax.persistence.criteria.Fetch;\n" + 
>+			"import javax.persistence.criteria.From;\n" + 
>+			"import javax.persistence.criteria.Join;\n" + 
>+			"import javax.persistence.criteria.JoinType;\n" + 
>+			"import javax.persistence.criteria.ListJoin;\n" + 
>+			"import javax.persistence.criteria.MapJoin;\n" + 
>+			"import javax.persistence.criteria.Path;\n" + 
>+			"import javax.persistence.criteria.SetJoin;\n" + 
>+			"import javax.persistence.metamodel.Attribute;\n" + 
>+			"import javax.persistence.metamodel.Bindable;\n" + 
>+			"import javax.persistence.metamodel.CollectionAttribute;\n" + 
>+			"import javax.persistence.metamodel.ListAttribute;\n" + 
>+			"import javax.persistence.metamodel.ManagedType;\n" + 
>+			"import javax.persistence.metamodel.MapAttribute;\n" + 
>+			"import javax.persistence.metamodel.Metamodel;\n" + 
>+			"import javax.persistence.metamodel.PluralAttribute;\n" + 
>+			"import javax.persistence.metamodel.SingularAttribute;\n" + 
>+			"import javax.persistence.metamodel.Attribute.PersistentAttributeType;\n" + 
>+			"import javax.persistence.metamodel.PluralAttribute.CollectionType;\n" + 
>+			"import javax.persistence.metamodel.Type.PersistenceType;\n" + 
>+			"\n" + 
>+			"import org.eclipse.persistence.internal.helper.ClassConstants;\n" + 
>+			"import org.eclipse.persistence.internal.localization.ExceptionLocalization;\n" + 
>+			"\n" + 
>+			"public class FromImpl<Z, X>  extends PathImpl<X> implements javax.persistence.criteria.From<Z, X> {\n" + 
>+			"\n" + 
>+			"    protected Set<Join<X, ?>> joins;\n" + 
>+			"    \n" + 
>+			"    public Set<Join<X, ?>> getJoins() {\n" + 
>+			"        return joins;\n" + 
>+			"    }\n" + 
>+			"\n" + 
>+			"    public void findJoins(AbstractQueryImpl query){\n" + 
>+			"        Stack stack = new Stack();\n" + 
>+			"        stack.push(this);\n" + 
>+			"        while(!stack.isEmpty()){\n" + 
>+			"            FromImpl currentJoin = (FromImpl) stack.pop();\n" + 
>+			"            stack.addAll(currentJoin.getJoins());\n" + 
>+			"            if (currentJoin.isLeaf){\n" + 
>+			"                    query.addJoin(currentJoin);\n" + 
>+			"                }\n" + 
>+			"        }\n" + 
>+			"    }\n" + 
>+			"}"
>+		},
>+		"----------\n" + 
>+		"1. ERROR in JoinImpl.java (at line 1)\n" + 
>+		"	import javax.persistence.criteria.Expression;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"2. ERROR in JoinImpl.java (at line 2)\n" + 
>+		"	import javax.persistence.criteria.Fetch;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"3. ERROR in JoinImpl.java (at line 3)\n" + 
>+		"	import javax.persistence.criteria.From;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"4. ERROR in JoinImpl.java (at line 4)\n" + 
>+		"	import javax.persistence.criteria.Join;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"5. ERROR in JoinImpl.java (at line 5)\n" + 
>+		"	import javax.persistence.criteria.JoinType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"6. ERROR in JoinImpl.java (at line 6)\n" + 
>+		"	import javax.persistence.criteria.Path;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"7. ERROR in JoinImpl.java (at line 7)\n" + 
>+		"	import javax.persistence.metamodel.Attribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"8. ERROR in JoinImpl.java (at line 8)\n" + 
>+		"	import javax.persistence.metamodel.Bindable;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"9. ERROR in JoinImpl.java (at line 9)\n" + 
>+		"	import javax.persistence.metamodel.ManagedType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"10. ERROR in JoinImpl.java (at line 10)\n" + 
>+		"	import javax.persistence.metamodel.Metamodel;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"11. ERROR in JoinImpl.java (at line 11)\n" + 
>+		"	public class JoinImpl<Z, X> extends FromImpl<Z, X> implements Join<Z, X>, Fetch<Z, X> {\n" + 
>+		"	                                                              ^^^^\n" + 
>+		"Join cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"12. ERROR in JoinImpl.java (at line 11)\n" + 
>+		"	public class JoinImpl<Z, X> extends FromImpl<Z, X> implements Join<Z, X>, Fetch<Z, X> {\n" + 
>+		"	                                                                          ^^^^^\n" + 
>+		"Fetch cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"----------\n" + 
>+		"1. ERROR in FromImpl.java (at line 7)\n" + 
>+		"	import javax.persistence.criteria.CollectionJoin;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"2. ERROR in FromImpl.java (at line 8)\n" + 
>+		"	import javax.persistence.criteria.Expression;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"3. ERROR in FromImpl.java (at line 9)\n" + 
>+		"	import javax.persistence.criteria.Fetch;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"4. ERROR in FromImpl.java (at line 10)\n" + 
>+		"	import javax.persistence.criteria.From;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"5. ERROR in FromImpl.java (at line 11)\n" + 
>+		"	import javax.persistence.criteria.Join;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"6. ERROR in FromImpl.java (at line 12)\n" + 
>+		"	import javax.persistence.criteria.JoinType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"7. ERROR in FromImpl.java (at line 13)\n" + 
>+		"	import javax.persistence.criteria.ListJoin;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"8. ERROR in FromImpl.java (at line 14)\n" + 
>+		"	import javax.persistence.criteria.MapJoin;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"9. ERROR in FromImpl.java (at line 15)\n" + 
>+		"	import javax.persistence.criteria.Path;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"10. ERROR in FromImpl.java (at line 16)\n" + 
>+		"	import javax.persistence.criteria.SetJoin;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"11. ERROR in FromImpl.java (at line 17)\n" + 
>+		"	import javax.persistence.metamodel.Attribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"12. ERROR in FromImpl.java (at line 18)\n" + 
>+		"	import javax.persistence.metamodel.Bindable;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"13. ERROR in FromImpl.java (at line 19)\n" + 
>+		"	import javax.persistence.metamodel.CollectionAttribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"14. ERROR in FromImpl.java (at line 20)\n" + 
>+		"	import javax.persistence.metamodel.ListAttribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"15. ERROR in FromImpl.java (at line 21)\n" + 
>+		"	import javax.persistence.metamodel.ManagedType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"16. ERROR in FromImpl.java (at line 22)\n" + 
>+		"	import javax.persistence.metamodel.MapAttribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"17. ERROR in FromImpl.java (at line 23)\n" + 
>+		"	import javax.persistence.metamodel.Metamodel;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"18. ERROR in FromImpl.java (at line 24)\n" + 
>+		"	import javax.persistence.metamodel.PluralAttribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"19. ERROR in FromImpl.java (at line 25)\n" + 
>+		"	import javax.persistence.metamodel.SingularAttribute;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"20. ERROR in FromImpl.java (at line 26)\n" + 
>+		"	import javax.persistence.metamodel.Attribute.PersistentAttributeType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"21. ERROR in FromImpl.java (at line 27)\n" + 
>+		"	import javax.persistence.metamodel.PluralAttribute.CollectionType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"22. ERROR in FromImpl.java (at line 28)\n" + 
>+		"	import javax.persistence.metamodel.Type.PersistenceType;\n" + 
>+		"	       ^^^^^^^^^^^^^^^^^\n" + 
>+		"The import javax.persistence cannot be resolved\n" + 
>+		"----------\n" + 
>+		"23. ERROR in FromImpl.java (at line 30)\n" + 
>+		"	import org.eclipse.persistence.internal.helper.ClassConstants;\n" + 
>+		"	       ^^^^^^^^^^^\n" + 
>+		"The import org.eclipse cannot be resolved\n" + 
>+		"----------\n" + 
>+		"24. ERROR in FromImpl.java (at line 31)\n" + 
>+		"	import org.eclipse.persistence.internal.localization.ExceptionLocalization;\n" + 
>+		"	       ^^^^^^^^^^^\n" + 
>+		"The import org.eclipse cannot be resolved\n" + 
>+		"----------\n" + 
>+		"25. ERROR in FromImpl.java (at line 33)\n" + 
>+		"	public class FromImpl<Z, X>  extends PathImpl<X> implements javax.persistence.criteria.From<Z, X> {\n" + 
>+		"	                                     ^^^^^^^^\n" + 
>+		"PathImpl cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"26. ERROR in FromImpl.java (at line 33)\n" + 
>+		"	public class FromImpl<Z, X>  extends PathImpl<X> implements javax.persistence.criteria.From<Z, X> {\n" + 
>+		"	                                                            ^^^^^^^^^^^^^^^^^\n" + 
>+		"javax.persistence cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"27. ERROR in FromImpl.java (at line 35)\n" + 
>+		"	protected Set<Join<X, ?>> joins;\n" + 
>+		"	              ^^^^\n" + 
>+		"Join cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"28. ERROR in FromImpl.java (at line 37)\n" + 
>+		"	public Set<Join<X, ?>> getJoins() {\n" + 
>+		"	           ^^^^\n" + 
>+		"Join cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"29. ERROR in FromImpl.java (at line 38)\n" + 
>+		"	return joins;\n" + 
>+		"	       ^^^^^\n" + 
>+		"Join cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"30. ERROR in FromImpl.java (at line 41)\n" + 
>+		"	public void findJoins(AbstractQueryImpl query){\n" + 
>+		"	                      ^^^^^^^^^^^^^^^^^\n" + 
>+		"AbstractQueryImpl cannot be resolved to a type\n" + 
>+		"----------\n" + 
>+		"31. WARNING in FromImpl.java (at line 42)\n" + 
>+		"	Stack stack = new Stack();\n" + 
>+		"	^^^^^\n" + 
>+		"Stack is a raw type. References to generic type Stack<E> should be parameterized\n" + 
>+		"----------\n" + 
>+		"32. WARNING in FromImpl.java (at line 42)\n" + 
>+		"	Stack stack = new Stack();\n" + 
>+		"	                  ^^^^^\n" + 
>+		"Stack is a raw type. References to generic type Stack<E> should be parameterized\n" + 
>+		"----------\n" + 
>+		"33. WARNING in FromImpl.java (at line 43)\n" + 
>+		"	stack.push(this);\n" + 
>+		"	^^^^^^^^^^^^^^^^\n" + 
>+		"Type safety: The method push(Object) belongs to the raw type Stack. References to generic type Stack<E> should be parameterized\n" + 
>+		"----------\n" + 
>+		"34. WARNING in FromImpl.java (at line 45)\n" + 
>+		"	FromImpl currentJoin = (FromImpl) stack.pop();\n" + 
>+		"	^^^^^^^^\n" + 
>+		"FromImpl is a raw type. References to generic type FromImpl<Z,X> should be parameterized\n" + 
>+		"----------\n" + 
>+		"35. WARNING in FromImpl.java (at line 45)\n" + 
>+		"	FromImpl currentJoin = (FromImpl) stack.pop();\n" + 
>+		"	                        ^^^^^^^^\n" + 
>+		"FromImpl is a raw type. References to generic type FromImpl<Z,X> should be parameterized\n" + 
>+		"----------\n" + 
>+		"36. WARNING in FromImpl.java (at line 46)\n" + 
>+		"	stack.addAll(currentJoin.getJoins());\n" + 
>+		"	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n" + 
>+		"Type safety: The method addAll(Collection) belongs to the raw type Vector. References to generic type Vector<E> should be parameterized\n" + 
>+		"----------\n" + 
>+		"37. ERROR in FromImpl.java (at line 47)\n" + 
>+		"	if (currentJoin.isLeaf){\n" + 
>+		"	                ^^^^^^\n" + 
>+		"isLeaf cannot be resolved or is not a field\n" + 
>+		"----------\n");
>+}
> }
>\ No newline at end of file

Actions: View | Diff

Attachments on bug 306464: 165033 | 165843 | 169560 | 169857 | 170031