Attachment 162692 Details for Bug 245569 – patch for cocoa and carbon

[patch] patch for cocoa and carbon

PR245569_caron_cocoa.patch (text/plain), 2.03 KB, created by Silenio Quarti

on 2010-03-22 12:30:46 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Silenio Quarti

Created: 2010-03-22 12:30:46 EDT

Size: 2.03 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.swt
>Index: Eclipse SWT/carbon/org/eclipse/swt/widgets/Combo.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/carbon/org/eclipse/swt/widgets/Combo.java,v
>retrieving revision 1.120
>diff -u -r1.120 Combo.java
>--- Eclipse SWT/carbon/org/eclipse/swt/widgets/Combo.java	29 Oct 2009 16:05:38 -0000	1.120
>+++ Eclipse SWT/carbon/org/eclipse/swt/widgets/Combo.java	22 Mar 2010 16:29:18 -0000
>@@ -66,6 +66,8 @@
> 	String lastText = "";
> 	ControlEditTextSelectionRec selection;
> 
>+	static final int VISIBLE_COUNT = 10;
>+
> 	/**
> 	 * the operating system limit for the number of characters
> 	 * that the text field in an instance of this class can hold
>@@ -518,6 +520,7 @@
> 		if (outControl [0] == 0) error (SWT.ERROR_NO_HANDLES);
> 		handle = outControl [0];
> 		OS.SetControlData (handle, (short)OS.kHIComboBoxEditTextPart, OS.kTXNDrawCaretWhenInactiveTag, 4, new byte [ ]{0});
>+		OS.SetControlData (handle, OS.kControlEntireControl, OS.kHIComboBoxNumVisibleItemsTag, 4, new int[] {VISIBLE_COUNT});
> 		OS.HIViewSetVisible (handle, true);
> 	}
> }
>Index: Eclipse SWT/cocoa/org/eclipse/swt/widgets/Combo.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Combo.java,v
>retrieving revision 1.75
>diff -u -r1.75 Combo.java
>--- Eclipse SWT/cocoa/org/eclipse/swt/widgets/Combo.java	23 Oct 2009 19:16:19 -0000	1.75
>+++ Eclipse SWT/cocoa/org/eclipse/swt/widgets/Combo.java	22 Mar 2010 16:29:18 -0000
>@@ -62,6 +62,8 @@
> 	boolean ignoreSetObject, ignoreSelection;
> 	NSRange selectionRange;
> 
>+	static final int VISIBLE_COUNT = 10;
>+
> 	/**
> 	 * the operating system limit for the number of characters
> 	 * that the text field in an instance of this class can hold
>@@ -429,6 +431,7 @@
> 	} else {
> 		NSComboBox widget = (NSComboBox)new SWTComboBox().alloc();
> 		widget.init();
>+		widget.setNumberOfVisibleItems(VISIBLE_COUNT);
> 		widget.setDelegate(widget);
> 		view = widget;
> 	}

Actions: View | Diff

Attachments on bug 245569: 162691 | 162692 | 163307