Attachment 149513 Details for Bug 292239 – Amalgam of files to test aspectj advice.

Amalgam of files to test aspectj advice.

AdviceFailure.txt (text/plain), 2.15 KB, created by Steve Powell

on 2009-10-14 07:16:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Steve Powell

Created: 2009-10-14 07:16:00 EDT

Size: 2.15 KB

patch

obsolete

>=======================================================MXBeanExceptionCatcher.aj====================================================
>package mypackage;
>
>import org.slf4j.LoggerFactory;
>
>import javax.management.MXBean;
>
>/**
> * An aspect that catches all {@link Exception}s thrown through @{@link MXBean} annotated interfaces.
> */
>public aspect MXBeanExceptionCatcher {
>
>    /**
>     * All implementations of @{@link MXBean} annotated interface methods:
>     */
>    pointcut exposedViaJmx(Object o) : this(o) && execution(* (@MXBean *).*(..));
>
>    /**
>     * Catch {@link Exception}s and remove references to a cause they might have embedded.
>     * {@link Throwable}s are trapped, so we can advise methods that do not declare a throws, but {@link Exception}s are filtered out.
>     */
>    after(Object o) throwing(Exception e) : exposedViaJmx(o) {
>        LoggerFactory.getLogger(o.getClass()).error("Exception issued by JMX invocation", e);
>    }
>}
>=======================================================JmxExceptionCatcherTestInterface.java=========================================
>package mypackage;
>
>import javax.management.MXBean;
>
>/**
> * This is an annotated @{@link MXBean} interface for testing the {@link MXBeanExceptionCatcher} aspect.
> */
>@MXBean
>public interface JmxExceptionCatcherTestInterface {
>    
>    public void caughtMethod() throws Exception;
>    
>    public void anotherCaughtMethod();
>
>}
>=======================================================MXBeanImplementationTest.java================================================
>package mypackage;
>
>/**
> * Implement the MXBean interface for the Catcher test.
> */
>public class MXBeanImplementationTest implements JmxExceptionCatcherTestInterface {
>
>    // unCaughtMethod is not advised -- it is not in the pointcut
>    public void unCaughtMethod() throws Exception { throw new RuntimeException("unCaughtMethod"); }
>
>	// caughtMethod is advised -- correctly
>    public void caughtMethod() throws Exception { throw new RuntimeException("caughtMethod"); }
>        
>	// anotherCaughtMethod is NOT advised -- <<< ERROR <<< this should be advised
>    public void anotherCaughtMethod() { throw new RuntimeException("anotherCaughtMethod"); }
>
>}

Actions: View

Attachments on bug 292239: 149513