Attachment 134970 Details for Bug 272884 – Better Fix (same as before but fixed broken comment)

Better Fix (same as before but fixed broken comment)

patch.txt (text/plain), 4.45 KB, created by Dani Megert

on 2009-05-08 10:07:14 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dani Megert

Created: 2009-05-08 10:07:14 EDT

Size: 4.45 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java,v
>retrieving revision 1.324
>diff -u -r1.324 WorkbenchPage.java
>--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	29 Apr 2009 14:01:12 -0000	1.324
>+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	8 May 2009 14:07:36 -0000
>@@ -23,6 +23,16 @@
> import java.util.Set;
> import java.util.StringTokenizer;
> 
>+import org.eclipse.osgi.util.NLS;
>+
>+import org.eclipse.swt.SWT;
>+import org.eclipse.swt.custom.BusyIndicator;
>+import org.eclipse.swt.graphics.Rectangle;
>+import org.eclipse.swt.widgets.Composite;
>+import org.eclipse.swt.widgets.Control;
>+import org.eclipse.swt.widgets.Display;
>+import org.eclipse.swt.widgets.Shell;
>+
> import org.eclipse.core.runtime.Assert;
> import org.eclipse.core.runtime.IAdaptable;
> import org.eclipse.core.runtime.IConfigurationElement;
>@@ -37,6 +47,7 @@
> import org.eclipse.core.runtime.dynamichelpers.ExtensionTracker;
> import org.eclipse.core.runtime.dynamichelpers.IExtensionChangeHandler;
> import org.eclipse.core.runtime.dynamichelpers.IExtensionTracker;
>+
> import org.eclipse.jface.dialogs.ErrorDialog;
> import org.eclipse.jface.dialogs.IDialogConstants;
> import org.eclipse.jface.dialogs.MessageDialog;
>@@ -47,14 +58,7 @@
> import org.eclipse.jface.util.SafeRunnable;
> import org.eclipse.jface.viewers.ISelection;
> import org.eclipse.jface.window.Window;
>-import org.eclipse.osgi.util.NLS;
>-import org.eclipse.swt.SWT;
>-import org.eclipse.swt.custom.BusyIndicator;
>-import org.eclipse.swt.graphics.Rectangle;
>-import org.eclipse.swt.widgets.Composite;
>-import org.eclipse.swt.widgets.Control;
>-import org.eclipse.swt.widgets.Display;
>-import org.eclipse.swt.widgets.Shell;
>+
> import org.eclipse.ui.IActionBars;
> import org.eclipse.ui.IEditorDescriptor;
> import org.eclipse.ui.IEditorInput;
>@@ -5075,11 +5079,11 @@
> 						workbench.largeUpdateStart();
> 						try {
> 							deferUpdates(true);
>-							for (int i = inputs.length - 1; i >= 0; i--) {
>+							for (int i = 0; i < inputs.length; i++) {
> 							   if (inputs[i] == null || editorIDs[i] == null)
> 							        throw new IllegalArgumentException();
>-								// activate the first editor
>-								boolean activate = (i == 0);
>+								// activate the last editor
>+								boolean activate = (i == inputs.length - 1);
> 								try {
> 									// check if there is an editor we can reuse
> 							        IEditorReference ref = batchReuseEditor(inputs[i], editorIDs[i], 
>@@ -5095,7 +5099,7 @@
> 							deferUpdates(false);
> 							// Update activation history. This can't be done
> 							// "as we go" or editors will be materialized.
>-							for (int i = inputs.length - 1; i >= 0; i--) {
>+							for (int i = 0; i < inputs.length; i++) {
> 								if (results[i] == null)
> 									continue;
> 								activationList.bringToTop(results[i]);
>Index: Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java,v
>retrieving revision 1.23
>diff -u -r1.23 PresentablePartFolder.java
>--- Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java	21 Oct 2008 12:44:33 -0000	1.23
>+++ Eclipse UI/org/eclipse/ui/internal/presentations/util/PresentablePartFolder.java	8 May 2009 14:07:36 -0000
>@@ -16,8 +16,6 @@
> import java.util.Iterator;
> import java.util.List;
> 
>-import org.eclipse.core.runtime.Assert;
>-import org.eclipse.jface.util.Geometry;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.ControlEvent;
> import org.eclipse.swt.events.ControlListener;
>@@ -30,6 +28,11 @@
> import org.eclipse.swt.graphics.Rectangle;
> import org.eclipse.swt.widgets.Composite;
> import org.eclipse.swt.widgets.Control;
>+
>+import org.eclipse.core.runtime.Assert;
>+
>+import org.eclipse.jface.util.Geometry;
>+
> import org.eclipse.ui.IPropertyListener;
> import org.eclipse.ui.internal.dnd.DragUtil;
> import org.eclipse.ui.internal.dnd.SwtUtil;
>@@ -189,7 +192,7 @@
>         }
>         
>         item = folder.add(idx, style);
>-
>+		folder.setSelection(item);
>         item.setData(part);
> 
>         initTab(item, part);

Actions: View

Attachments on bug 272884: 133178 | 133179 | 133538 | 133539 | 133540 | 133780 | 134969 | 134970 | 143938 | 147360 | 147361 | 153115