Attachment 130024 Details for Bug 164221 – patch for 3.2

[patch] patch for 3.2

patch164221.txt (text/plain), 2.58 KB, created by Frank Becker

on 2009-03-26 18:19:27 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2009-03-26 18:19:27 EDT

Size: 2.58 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java,v
>retrieving revision 1.41
>diff -u -r1.41 BugzillaConnectorUi.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java	21 Feb 2009 02:05:48 -0000	1.41
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/tasklist/BugzillaConnectorUi.java	26 Mar 2009 22:19:35 -0000
>@@ -49,7 +49,7 @@
>  */
> public class BugzillaConnectorUi extends AbstractRepositoryConnectorUi {
> 
>-	private static final String regexp = "(duplicate of|bug|task)( ?#? ?)(\\d+)"; //$NON-NLS-1$
>+	private static final String regexp = "(duplicate of|bug|task)( ?#? ?)(\\d+)((\\s)*(comment|c)(\\s#|#|#\\s|\\s|)(\\s\\d+|\\d+))?"; //$NON-NLS-1$
> 
> 	private static final Pattern PATTERN = Pattern.compile(regexp, Pattern.CASE_INSENSITIVE);
> 
>@@ -202,11 +202,17 @@
> 		try {
> 
> 			String bugId = m.group(TASK_NUM_GROUP).trim();
>+			String commentNumber;
>+			try {
>+				commentNumber = m.group(7);
>+			} catch (IndexOutOfBoundsException e) {
>+				commentNumber = null;
>+			}
> 			start += regionOffset;
> 			end += regionOffset;
> 
> 			IRegion sregion = new Region(start, end - start);
>-			return new TaskHyperlink(sregion, repository, bugId);
>+			return new TaskHyperlink(sregion, repository, bugId, commentNumber);
> 
> 		} catch (NumberFormatException e) {
> 			return null;
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/TaskHyperlink.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/TaskHyperlink.java,v
>retrieving revision 1.14
>diff -u -r1.14 TaskHyperlink.java
>--- src/org/eclipse/mylyn/tasks/ui/TaskHyperlink.java	4 Dec 2008 05:33:18 -0000	1.14
>+++ src/org/eclipse/mylyn/tasks/ui/TaskHyperlink.java	26 Mar 2009 22:19:36 -0000
>@@ -35,10 +35,20 @@
> 
> 	private final String taskId;
> 
>+	private final String commentNumber;
>+
> 	public TaskHyperlink(IRegion region, TaskRepository repository, String taskId) {
>+		this(region, repository, taskId, null);
>+	}
>+
>+	/**
>+	 * @since 3.2
>+	 */
>+	public TaskHyperlink(IRegion region, TaskRepository repository, String taskId, String commentNumber) {
> 		this.region = region;
> 		this.repository = repository;
> 		this.taskId = taskId;
>+		this.commentNumber = commentNumber;
> 	}
> 
> 	public IRegion getHyperlinkRegion() {

Actions: View | Diff

Attachments on bug 164221: 98332 | 98523 | 98524 | 105284 | 105285 | 130024 | 130025 | 160844 | 160845