Attachment 128999 Details for Bug 262284 – Patch

[patch] Patch

clipboard.txt (text/plain), 90.15 KB, created by Matthew Hall

on 2009-03-16 17:08:45 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matthew Hall

Created: 2009-03-16 17:08:45 EDT

Size: 90.15 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jface.examples.databinding
>Index: src/org/eclipse/jface/examples/databinding/snippets/Snippet026AnonymousBeanProperties.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.examples.databinding/src/org/eclipse/jface/examples/databinding/snippets/Snippet026AnonymousBeanProperties.java,v
>retrieving revision 1.5
>diff -u -r1.5 Snippet026AnonymousBeanProperties.java
>--- src/org/eclipse/jface/examples/databinding/snippets/Snippet026AnonymousBeanProperties.java	4 Mar 2009 01:04:02 -0000	1.5
>+++ src/org/eclipse/jface/examples/databinding/snippets/Snippet026AnonymousBeanProperties.java	16 Mar 2009 21:06:19 -0000
>@@ -222,6 +222,10 @@
> 	 * and removeContact methods.
> 	 */
> 	public static class ContactGroupContactsProperty extends SimpleSetProperty {
>+		public Object getSourceType() {
>+			return ContactGroup.class;
>+		}
>+
> 		public Object getElementType() {
> 			return Contact.class;
> 		}
>#P org.eclipse.core.databinding.beans
>Index: src/org/eclipse/core/internal/databinding/beans/BeanSetProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanSetProperty.java,v
>retrieving revision 1.5
>diff -u -r1.5 BeanSetProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/BeanSetProperty.java	4 Mar 2009 01:04:03 -0000	1.5
>+++ src/org/eclipse/core/internal/databinding/beans/BeanSetProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -31,21 +31,28 @@
>  * 
>  */
> public class BeanSetProperty extends SimpleSetProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class elementType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param elementType
> 	 */
>-	public BeanSetProperty(PropertyDescriptor propertyDescriptor,
>-			Class elementType) {
>+	public BeanSetProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class elementType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.elementType = elementType == null ? BeanPropertyHelper
> 				.getCollectionPropertyElementType(propertyDescriptor)
> 				: elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java,v
>retrieving revision 1.5
>diff -u -r1.5 BeanPropertyHelper.java
>--- src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java	5 Mar 2009 19:12:01 -0000	1.5
>+++ src/org/eclipse/core/internal/databinding/beans/BeanPropertyHelper.java	16 Mar 2009 21:06:21 -0000
>@@ -209,7 +209,7 @@
> 	 * @param propertyName
> 	 * @return property descriptor or <code>null</code>
> 	 */
>-	/* package */public static PropertyDescriptor getValueTypePropertyDescriptor(
>+	public static PropertyDescriptor getValueTypePropertyDescriptor(
> 			IObservableValue observable, String propertyName) {
> 		if (observable.getValueType() != null)
> 			return getPropertyDescriptor((Class) observable.getValueType(),
>Index: src/org/eclipse/core/internal/databinding/beans/PojoValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/PojoValueProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 PojoValueProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/PojoValueProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/PojoValueProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -23,20 +23,27 @@
>  * 
>  */
> public class PojoValueProperty extends SimpleValueProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class valueType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param valueType
> 	 */
>-	public PojoValueProperty(PropertyDescriptor propertyDescriptor,
>-			Class valueType) {
>+	public PojoValueProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class valueType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.valueType = valueType == null ? propertyDescriptor
> 				.getPropertyType() : valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getValueType() {
> 		return valueType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/PojoSetProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/PojoSetProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 PojoSetProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/PojoSetProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/PojoSetProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -29,21 +29,28 @@
>  * 
>  */
> public class PojoSetProperty extends SimpleSetProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class elementType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param elementType
> 	 */
>-	public PojoSetProperty(PropertyDescriptor propertyDescriptor,
>-			Class elementType) {
>+	public PojoSetProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class elementType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.elementType = elementType == null ? BeanPropertyHelper
> 				.getCollectionPropertyElementType(propertyDescriptor)
> 				: elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/BeanListProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanListProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 BeanListProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/BeanListProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/BeanListProperty.java	16 Mar 2009 21:06:20 -0000
>@@ -30,21 +30,28 @@
>  * 
>  */
> public class BeanListProperty extends SimpleListProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class elementType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param elementType
> 	 */
>-	public BeanListProperty(PropertyDescriptor propertyDescriptor,
>-			Class elementType) {
>+	public BeanListProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class elementType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.elementType = elementType == null ? BeanPropertyHelper
> 				.getCollectionPropertyElementType(propertyDescriptor)
> 				: elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/PojoMapProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/PojoMapProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 PojoMapProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/PojoMapProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/PojoMapProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -26,22 +26,30 @@
>  * 
>  */
> public class PojoMapProperty extends SimpleMapProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class keyType;
> 	private final Class valueType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param keyType
> 	 * @param valueType
> 	 */
>-	public PojoMapProperty(PropertyDescriptor propertyDescriptor,
>-			Class keyType, Class valueType) {
>+	public PojoMapProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class keyType,
>+			Class valueType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.keyType = keyType;
> 		this.valueType = valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getKeyType() {
> 		return keyType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/BeanMapProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanMapProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 BeanMapProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/BeanMapProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/BeanMapProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -28,22 +28,30 @@
>  * 
>  */
> public class BeanMapProperty extends SimpleMapProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class keyType;
> 	private final Class valueType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param keyType
> 	 * @param valueType
> 	 */
>-	public BeanMapProperty(PropertyDescriptor propertyDescriptor,
>-			Class keyType, Class valueType) {
>+	public BeanMapProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class keyType,
>+			Class valueType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.keyType = keyType;
> 		this.valueType = valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getKeyType() {
> 		return keyType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/PojoListProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/PojoListProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 PojoListProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/PojoListProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/PojoListProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -28,21 +28,28 @@
>  * 
>  */
> public class PojoListProperty extends SimpleListProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class elementType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param elementType
> 	 */
>-	public PojoListProperty(PropertyDescriptor propertyDescriptor,
>-			Class elementType) {
>+	public PojoListProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class elementType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.elementType = elementType == null ? BeanPropertyHelper
> 				.getCollectionPropertyElementType(propertyDescriptor)
> 				: elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/beans/BeanValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/internal/databinding/beans/BeanValueProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 BeanValueProperty.java
>--- src/org/eclipse/core/internal/databinding/beans/BeanValueProperty.java	4 Mar 2009 01:04:03 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/beans/BeanValueProperty.java	16 Mar 2009 21:06:21 -0000
>@@ -25,20 +25,27 @@
>  * 
>  */
> public class BeanValueProperty extends SimpleValueProperty {
>+	private final Class beanClass;
> 	private final PropertyDescriptor propertyDescriptor;
> 	private final Class valueType;
> 
> 	/**
>+	 * @param beanClass
> 	 * @param propertyDescriptor
> 	 * @param valueType
> 	 */
>-	public BeanValueProperty(PropertyDescriptor propertyDescriptor,
>-			Class valueType) {
>+	public BeanValueProperty(Class beanClass,
>+			PropertyDescriptor propertyDescriptor, Class valueType) {
>+		this.beanClass = beanClass;
> 		this.propertyDescriptor = propertyDescriptor;
> 		this.valueType = valueType == null ? propertyDescriptor
> 				.getPropertyType() : valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return beanClass;
>+	}
>+
> 	public Object getValueType() {
> 		return valueType;
> 	}
>Index: src/org/eclipse/core/databinding/beans/PojoProperties.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/databinding/beans/PojoProperties.java,v
>retrieving revision 1.4
>diff -u -r1.4 PojoProperties.java
>--- src/org/eclipse/core/databinding/beans/PojoProperties.java	10 Feb 2009 08:15:14 -0000	1.4
>+++ src/org/eclipse/core/databinding/beans/PojoProperties.java	16 Mar 2009 21:06:20 -0000
>@@ -118,7 +118,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyNames[0]);
>-			property = new PojoValueProperty(propertyDescriptor, valueType);
>+			property = new PojoValueProperty(beanClass, propertyDescriptor,
>+					valueType);
> 		}
> 
> 		IBeanValueProperty beanProperty = new PojoValuePropertyDecorator(
>@@ -243,7 +244,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new PojoSetProperty(propertyDescriptor, elementType);
>+			property = new PojoSetProperty(beanClass, propertyDescriptor,
>+					elementType);
> 		}
> 		return new PojoSetPropertyDecorator(property, propertyDescriptor);
> 	}
>@@ -316,7 +318,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new PojoListProperty(propertyDescriptor, elementType);
>+			property = new PojoListProperty(beanClass, propertyDescriptor,
>+					elementType);
> 		}
> 		return new PojoListPropertyDecorator(property, propertyDescriptor);
> 	}
>@@ -395,8 +398,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new PojoMapProperty(propertyDescriptor, keyType,
>-					valueType);
>+			property = new PojoMapProperty(beanClass, propertyDescriptor,
>+					keyType, valueType);
> 		}
> 		return new PojoMapPropertyDecorator(property, propertyDescriptor);
> 	}
>Index: src/org/eclipse/core/databinding/beans/BeanProperties.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.beans/src/org/eclipse/core/databinding/beans/BeanProperties.java,v
>retrieving revision 1.4
>diff -u -r1.4 BeanProperties.java
>--- src/org/eclipse/core/databinding/beans/BeanProperties.java	10 Feb 2009 08:15:14 -0000	1.4
>+++ src/org/eclipse/core/databinding/beans/BeanProperties.java	16 Mar 2009 21:06:20 -0000
>@@ -115,7 +115,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyNames[0]);
>-			property = new BeanValueProperty(propertyDescriptor, valueType);
>+			property = new BeanValueProperty(beanClass, propertyDescriptor,
>+					valueType);
> 		}
> 
> 		IBeanValueProperty beanProperty = new BeanValuePropertyDecorator(
>@@ -240,7 +241,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new BeanSetProperty(propertyDescriptor, elementType);
>+			property = new BeanSetProperty(beanClass, propertyDescriptor,
>+					elementType);
> 		}
> 		return new BeanSetPropertyDecorator(property, propertyDescriptor);
> 	}
>@@ -313,7 +315,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new BeanListProperty(propertyDescriptor, elementType);
>+			property = new BeanListProperty(beanClass, propertyDescriptor,
>+					elementType);
> 		}
> 		return new BeanListPropertyDecorator(property, propertyDescriptor);
> 	}
>@@ -392,8 +395,8 @@
> 		} else {
> 			propertyDescriptor = BeanPropertyHelper.getPropertyDescriptor(
> 					beanClass, propertyName);
>-			property = new BeanMapProperty(propertyDescriptor, keyType,
>-					valueType);
>+			property = new BeanMapProperty(beanClass, propertyDescriptor,
>+					keyType, valueType);
> 		}
> 		return new BeanMapPropertyDecorator(property, propertyDescriptor);
> 	}
>#P org.eclipse.jface.databinding
>Index: src/org/eclipse/jface/databinding/util/JFaceProperties.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/util/JFaceProperties.java,v
>retrieving revision 1.1
>diff -u -r1.1 JFaceProperties.java
>--- src/org/eclipse/jface/databinding/util/JFaceProperties.java	8 Mar 2009 16:44:40 -0000	1.1
>+++ src/org/eclipse/jface/databinding/util/JFaceProperties.java	16 Mar 2009 21:06:22 -0000
>@@ -41,7 +41,7 @@
> 	 */
> 	public static IValueProperty value(Class clazz, String fieldName,
> 			String propertyName) {
>-		return new JFaceProperty(fieldName, propertyName, clazz);
>+		return new JFaceProperty(clazz, fieldName, propertyName);
> 	}
> 
> }
>Index: src/org/eclipse/jface/internal/databinding/swt/ComboSingleSelectionIndexProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ComboSingleSelectionIndexProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ComboSingleSelectionIndexProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ComboSingleSelectionIndexProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ComboSingleSelectionIndexProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(new int[] { SWT.Selection, SWT.DefaultSelection });
> 	}
> 
>+	public Object getSourceType() {
>+		return Combo.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Combo) source).getSelectionIndex();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TextTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TextTextProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 TextTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TextTextProperty.java	4 Mar 2009 01:03:58 -0000	1.4
>+++ src/org/eclipse/jface/internal/databinding/swt/TextTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -59,6 +59,10 @@
> 		return new int[] { SWT.Modify };
> 	}
> 
>+	public Object getSourceType() {
>+		return Text.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Text) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TrayItemTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TrayItemTooltipTextProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 TrayItemTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TrayItemTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/TrayItemTooltipTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class TrayItemTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return TrayItem.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((TrayItem) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ItemTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ItemTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ItemTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ItemTextProperty.java	20 Jan 2009 23:21:14 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ItemTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ItemTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Item.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Item) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlVisibleProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlVisibleProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ControlVisibleProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlVisibleProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlVisibleProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ControlVisibleProperty extends WidgetBooleanValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	boolean doGetBooleanValue(Object source) {
> 		return ((Control) source).getVisible();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlEnabledProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlEnabledProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ControlEnabledProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlEnabledProperty.java	20 Jan 2009 23:21:14 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlEnabledProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ControlEnabledProperty extends WidgetBooleanValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public boolean doGetBooleanValue(Object source) {
> 		return ((Control) source).getEnabled();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ToolTipMessageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ToolTipMessageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 ToolTipMessageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ToolTipMessageProperty.java	2 Mar 2009 23:11:51 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/ToolTipMessageProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ToolTipMessageProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return ToolTip.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((ToolTip) source).getMessage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ListSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ListSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ListSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ListSelectionProperty.java	20 Jan 2009 23:21:14 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ListSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Selection);
> 	}
> 
>+	public Object getSourceType() {
>+		return List.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		List list = (List) source;
> 		int index = list.getSelectionIndex();
>Index: src/org/eclipse/jface/internal/databinding/swt/ButtonSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ButtonSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ButtonSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ButtonSelectionProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ButtonSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Selection);
> 	}
> 
>+	public Object getSourceType() {
>+		return Button.class;
>+	}
>+
> 	boolean doGetBooleanValue(Object source) {
> 		return ((Button) source).getSelection();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/LabelImageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/LabelImageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 LabelImageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/LabelImageProperty.java	25 Jan 2009 18:38:39 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/LabelImageProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class LabelImageProperty extends WidgetImageValueProperty {
>+	public Object getSourceType() {
>+		return Label.class;
>+	}
>+
> 	Image doGetImageValue(Object source) {
> 		return ((Label) source).getImage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TextMessageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TextMessageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 TextMessageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TextMessageProperty.java	2 Mar 2009 23:11:51 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/TextMessageProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class TextMessageProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Text.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Text) source).getMessage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TableColumnTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TableColumnTooltipTextProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 TableColumnTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TableColumnTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/TableColumnTooltipTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class TableColumnTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return TableColumn.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((TableColumn) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlLocationProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlLocationProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlLocationProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlLocationProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlLocationProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -30,6 +30,10 @@
> 		super(SWT.Move);
> 	}
> 
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Point.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlForegroundProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlForegroundProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlForegroundProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlForegroundProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlForegroundProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -21,6 +21,10 @@
>  * 
>  */
> public class ControlForegroundProperty extends WidgetValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Color.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TreeColumnTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TreeColumnTooltipTextProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 TreeColumnTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TreeColumnTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/TreeColumnTooltipTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class TreeColumnTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return TreeColumn.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((TreeColumn) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TextEditableProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TextEditableProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 TextEditableProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TextEditableProperty.java	20 Jan 2009 23:21:18 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/TextEditableProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class TextEditableProperty extends WidgetBooleanValueProperty {
>+	public Object getSourceType() {
>+		return Text.class;
>+	}
>+
> 	boolean doGetBooleanValue(Object source) {
> 		return ((Text) source).getEditable();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ComboItemsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ComboItemsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ComboItemsProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ComboItemsProperty.java	24 Jan 2009 01:23:04 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ComboItemsProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class ComboItemsProperty extends ControlStringListProperty {
>+	public Object getSourceType() {
>+		return Combo.class;
>+	}
>+
> 	protected void doSetStringList(final Control control, String[] list,
> 			ListDiff diff) {
> 		diff.accept(new ListDiffVisitor() {
>Index: src/org/eclipse/jface/internal/databinding/swt/CLabelTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CLabelTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 CLabelTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CLabelTextProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/CLabelTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class CLabelTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return CLabel.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((CLabel) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/LabelTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/LabelTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 LabelTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/LabelTextProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/LabelTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class LabelTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Label.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Label) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ListSingleSelectionIndexProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ListSingleSelectionIndexProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ListSingleSelectionIndexProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ListSingleSelectionIndexProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ListSingleSelectionIndexProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(new int[] { SWT.Selection, SWT.DefaultSelection });
> 	}
> 
>+	public Object getSourceType() {
>+		return List.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((List) source).getSelectionIndex();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CComboSingleSelectionIndexProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CComboSingleSelectionIndexProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 CComboSingleSelectionIndexProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CComboSingleSelectionIndexProperty.java	20 Jan 2009 23:21:18 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/CComboSingleSelectionIndexProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(new int[] { SWT.Selection, SWT.DefaultSelection });
> 	}
> 
>+	public Object getSourceType() {
>+		return CCombo.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((CCombo) source).getSelectionIndex();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlSizeProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlSizeProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlSizeProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlSizeProperty.java	3 Feb 2009 15:20:10 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlSizeProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -30,6 +30,10 @@
> 		super(SWT.Resize);
> 	}
> 
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Point.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/StyledTextTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/StyledTextTextProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 StyledTextTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/StyledTextTextProperty.java	4 Mar 2009 01:03:58 -0000	1.4
>+++ src/org/eclipse/jface/internal/databinding/swt/StyledTextTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -59,6 +59,10 @@
> 		return new int[] { SWT.Modify };
> 	}
> 
>+	public Object getSourceType() {
>+		return StyledText.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((StyledText) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ButtonImageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ButtonImageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 ButtonImageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ButtonImageProperty.java	25 Jan 2009 18:38:39 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/ButtonImageProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class ButtonImageProperty extends WidgetImageValueProperty {
>+	public Object getSourceType() {
>+		return Button.class;
>+	}
>+
> 	Image doGetImageValue(Object source) {
> 		return ((Button) source).getImage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CComboItemsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CComboItemsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 CComboItemsProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CComboItemsProperty.java	24 Jan 2009 01:23:04 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/CComboItemsProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class CComboItemsProperty extends ControlStringListProperty {
>+	public Object getSourceType() {
>+		return CCombo.class;
>+	}
>+
> 	protected void doSetStringList(final Control control, String[] list,
> 			ListDiff diff) {
> 		diff.accept(new ListDiffVisitor() {
>Index: src/org/eclipse/jface/internal/databinding/swt/TableSingleSelectionIndexProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TableSingleSelectionIndexProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 TableSingleSelectionIndexProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TableSingleSelectionIndexProperty.java	20 Jan 2009 23:21:18 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/TableSingleSelectionIndexProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -26,6 +26,10 @@
> 		super(new int[] { SWT.Selection, SWT.DefaultSelection });
> 	}
> 
>+	public Object getSourceType() {
>+		return Table.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Table) source).getSelectionIndex();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/SpinnerSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/SpinnerSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SpinnerSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/SpinnerSelectionProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/SpinnerSelectionProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Modify);
> 	}
> 
>+	public Object getSourceType() {
>+		return Spinner.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Spinner) source).getSelection();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ScaleMinimumProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ScaleMinimumProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ScaleMinimumProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ScaleMinimumProperty.java	20 Jan 2009 23:21:18 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ScaleMinimumProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ScaleMinimumProperty extends WidgetIntValueProperty {
>+	public Object getSourceType() {
>+		return Scale.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Scale) source).getMinimum();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CLabelImageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CLabelImageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 CLabelImageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CLabelImageProperty.java	25 Jan 2009 18:38:39 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/CLabelImageProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class CLabelImageProperty extends WidgetImageValueProperty {
>+	public Object getSourceType() {
>+		return CLabel.class;
>+	}
>+
> 	Image doGetImageValue(Object source) {
> 		return ((CLabel) source).getImage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/SpinnerMaximumProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/SpinnerMaximumProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SpinnerMaximumProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/SpinnerMaximumProperty.java	20 Jan 2009 23:21:18 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/SpinnerMaximumProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class SpinnerMaximumProperty extends WidgetIntValueProperty {
>+	public Object getSourceType() {
>+		return Spinner.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Spinner) source).getMaximum();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/SpinnerMinimumProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/SpinnerMinimumProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SpinnerMinimumProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/SpinnerMinimumProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/SpinnerMinimumProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class SpinnerMinimumProperty extends WidgetIntValueProperty {
>+	public Object getSourceType() {
>+		return Spinner.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Spinner) source).getMinimum();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlFocusedProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlFocusedProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ControlFocusedProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlFocusedProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlFocusedProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -27,6 +27,10 @@
> 		super(new int[] { SWT.FocusIn, SWT.FocusOut });
> 	}
> 
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public boolean doGetBooleanValue(Object source) {
> 		return ((Control) source).isFocusControl();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CComboTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CComboTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 CComboTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CComboTextProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/CComboTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Modify);
> 	}
> 
>+	public Object getSourceType() {
>+		return CCombo.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((CCombo) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ComboTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ComboTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ComboTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ComboTextProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ComboTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Modify);
> 	}
> 
>+	public Object getSourceType() {
>+		return Combo.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Combo) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlFontProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlFontProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlFontProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlFontProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlFontProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -21,6 +21,10 @@
>  * 
>  */
> public class ControlFontProperty extends WidgetValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Font.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ItemImageProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ItemImageProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 ItemImageProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ItemImageProperty.java	25 Jan 2009 18:55:22 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/ItemImageProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class ItemImageProperty extends WidgetImageValueProperty {
>+	public Object getSourceType() {
>+		return Item.class;
>+	}
>+
> 	Image doGetImageValue(Object source) {
> 		return ((Item) source).getImage();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CTabItemTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CTabItemTooltipTextProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 CTabItemTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CTabItemTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/CTabItemTooltipTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class CTabItemTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return CTabItem.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((CTabItem) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ButtonTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ButtonTextProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 ButtonTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ButtonTextProperty.java	25 Jan 2009 18:38:39 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/ButtonTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ButtonTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Button.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Button) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ShellTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ShellTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ShellTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ShellTextProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ShellTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ShellTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Shell.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Shell) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/LinkTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/LinkTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 LinkTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/LinkTextProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/LinkTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class LinkTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Link.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Link) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ToolItemTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ToolItemTooltipTextProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ToolItemTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ToolItemTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ToolItemTooltipTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class ToolItemTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return ToolItem.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((ToolItem) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/DateTimeSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/DateTimeSelectionProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 DateTimeSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/DateTimeSelectionProperty.java	3 Mar 2009 19:54:24 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/swt/DateTimeSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -30,6 +30,10 @@
> 		super(SWT.Selection);
> 	}
> 
>+	public Object getSourceType() {
>+		return DateTime.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Date.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlBackgroundProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlBackgroundProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlBackgroundProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlBackgroundProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlBackgroundProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -21,6 +21,10 @@
>  * 
>  */
> public class ControlBackgroundProperty extends WidgetValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Color.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/TabItemTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/TabItemTooltipTextProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 TabItemTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/TabItemTooltipTextProperty.java	30 Jan 2009 03:40:30 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/TabItemTooltipTextProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -19,6 +19,10 @@
>  * 
>  */
> public class TabItemTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return TabItem.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((TabItem) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlTooltipTextProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlTooltipTextProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ControlTooltipTextProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlTooltipTextProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlTooltipTextProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ControlTooltipTextProperty extends WidgetStringValueProperty {
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Control) source).getToolTipText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ControlBoundsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ControlBoundsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ControlBoundsProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ControlBoundsProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ControlBoundsProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -30,6 +30,10 @@
> 		super(new int[] { SWT.Resize, SWT.Move });
> 	}
> 
>+	public Object getSourceType() {
>+		return Control.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Rectangle.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ScaleMaximumProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ScaleMaximumProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ScaleMaximumProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ScaleMaximumProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ScaleMaximumProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -18,6 +18,10 @@
>  * 
>  */
> public class ScaleMaximumProperty extends WidgetIntValueProperty {
>+	public Object getSourceType() {
>+		return Scale.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Scale) source).getMaximum();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ScaleSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ScaleSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ScaleSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ScaleSelectionProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ScaleSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Selection);
> 	}
> 
>+	public Object getSourceType() {
>+		return Scale.class;
>+	}
>+
> 	int doGetIntValue(Object source) {
> 		return ((Scale) source).getSelection();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/CComboSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/CComboSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 CComboSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/CComboSelectionProperty.java	20 Jan 2009 23:21:17 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/CComboSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Modify);
> 	}
> 
>+	public Object getSourceType() {
>+		return CCombo.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((CCombo) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/swt/ListItemsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ListItemsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ListItemsProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ListItemsProperty.java	24 Jan 2009 01:23:04 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/swt/ListItemsProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class ListItemsProperty extends ControlStringListProperty {
>+	public Object getSourceType() {
>+		return List.class;
>+	}
>+
> 	protected void doSetStringList(final Control control, String[] items,
> 			ListDiff diff) {
> 		diff.accept(new ListDiffVisitor() {
>Index: src/org/eclipse/jface/internal/databinding/swt/ComboSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/swt/ComboSelectionProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ComboSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/swt/ComboSelectionProperty.java	20 Jan 2009 23:21:16 -0000	1.2
>+++ src/org/eclipse/jface/internal/databinding/swt/ComboSelectionProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -26,6 +26,10 @@
> 		super(SWT.Modify);
> 	}
> 
>+	public Object getSourceType() {
>+		return Combo.class;
>+	}
>+
> 	String doGetStringValue(Object source) {
> 		return ((Combo) source).getText();
> 	}
>Index: src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderSingleSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderSingleSelectionProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SelectionProviderSingleSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderSingleSelectionProperty.java	4 Mar 2009 01:03:58 -0000	1.4
>+++ src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderSingleSelectionProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -26,6 +26,10 @@
>  */
> public class SelectionProviderSingleSelectionProperty extends
> 		ViewerValueProperty {
>+	public Object getSourceType() {
>+		return ISelectionProvider.class;
>+	}
>+
> 	public Object getValueType() {
> 		return null;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/viewers/ViewerInputProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/ViewerInputProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 ViewerInputProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/ViewerInputProperty.java	3 Feb 2009 15:20:09 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/viewers/ViewerInputProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class ViewerInputProperty extends ViewerValueProperty {
>+	public Object getSourceType() {
>+		return Viewer.class;
>+	}
>+
> 	public Object getValueType() {
> 		return null;
> 	}
>@@ -39,13 +43,6 @@
> 		return null;
> 	}
> 
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
>-
> 	public String toString() {
> 		return "Viewer.input"; //$NON-NLS-1$
> 	}
>Index: src/org/eclipse/jface/internal/databinding/viewers/StructuredViewerFiltersProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/StructuredViewerFiltersProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 StructuredViewerFiltersProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/StructuredViewerFiltersProperty.java	4 Mar 2009 01:03:58 -0000	1.4
>+++ src/org/eclipse/jface/internal/databinding/viewers/StructuredViewerFiltersProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -28,6 +28,10 @@
>  * 
>  */
> public class StructuredViewerFiltersProperty extends ViewerSetProperty {
>+	public Object getSourceType() {
>+		return StructuredViewer.class;
>+	}
>+
> 	public Object getElementType() {
> 		return ViewerFilter.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderMultipleSelectionProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderMultipleSelectionProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SelectionProviderMultipleSelectionProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderMultipleSelectionProperty.java	4 Mar 2009 01:03:58 -0000	1.4
>+++ src/org/eclipse/jface/internal/databinding/viewers/SelectionProviderMultipleSelectionProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -30,6 +30,10 @@
>  */
> public class SelectionProviderMultipleSelectionProperty extends
> 		ViewerListProperty {
>+	public Object getSourceType() {
>+		return ISelectionProvider.class;
>+	}
>+
> 	public Object getElementType() {
> 		return Object.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/viewers/CheckboxTreeViewerCheckedElementsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/CheckboxTreeViewerCheckedElementsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 CheckboxTreeViewerCheckedElementsProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/CheckboxTreeViewerCheckedElementsProperty.java	24 Jan 2009 15:12:21 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/viewers/CheckboxTreeViewerCheckedElementsProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -31,6 +31,10 @@
> 		super(elementType);
> 	}
> 
>+	public Object getSourceType() {
>+		return CheckboxTreeViewer.class;
>+	}
>+
> 	protected Set doGetSet(Object source) {
> 		CheckboxTreeViewer viewer = (CheckboxTreeViewer) source;
> 		Set set = createElementSet(viewer);
>Index: src/org/eclipse/jface/internal/databinding/viewers/CheckboxTableViewerCheckedElementsProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/CheckboxTableViewerCheckedElementsProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 CheckboxTableViewerCheckedElementsProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/CheckboxTableViewerCheckedElementsProperty.java	24 Jan 2009 15:12:21 -0000	1.3
>+++ src/org/eclipse/jface/internal/databinding/viewers/CheckboxTableViewerCheckedElementsProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -31,6 +31,10 @@
> 		super(elementType);
> 	}
> 
>+	public Object getSourceType() {
>+		return CheckboxTableViewer.class;
>+	}
>+
> 	protected Set doGetSet(Object source) {
> 		CheckboxTableViewer viewer = (CheckboxTableViewer) source;
> 		Set set = createElementSet(viewer);
>Index: src/org/eclipse/jface/internal/databinding/viewers/CellEditorControlProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/viewers/CellEditorControlProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 CellEditorControlProperty.java
>--- src/org/eclipse/jface/internal/databinding/viewers/CellEditorControlProperty.java	10 Mar 2009 03:29:36 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/viewers/CellEditorControlProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class CellEditorControlProperty extends SimpleValueProperty {
>+	public Object getSourceType() {
>+		return CellEditor.class;
>+	}
>+
> 	public Object getValueType() {
> 		return Control.class;
> 	}
>Index: src/org/eclipse/jface/internal/databinding/util/JFaceProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/internal/databinding/util/JFaceProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 JFaceProperty.java
>--- src/org/eclipse/jface/internal/databinding/util/JFaceProperty.java	7 Mar 2009 13:29:12 -0000	1.1
>+++ src/org/eclipse/jface/internal/databinding/util/JFaceProperty.java	16 Mar 2009 21:06:23 -0000
>@@ -28,6 +28,7 @@
>  */
> public class JFaceProperty extends SimpleValueProperty {
> 
>+	private final Class sourceType;
> 	private Class returnType;
> 	private Method setterMethod;
> 	private Method getterMethod;
>@@ -92,29 +93,30 @@
> 	}
> 
> 	/**
>+	 * @param sourceType
> 	 * @param fieldName
> 	 * @param property
>-	 * @param clazz
> 	 */
>-	public JFaceProperty(String fieldName, String property, Class clazz) {
>+	public JFaceProperty(Class sourceType, String fieldName, String property) {
>+		this.sourceType = sourceType;
> 		this.property = property;
> 		// Create all the necessary method ahead of time to ensure they are
> 		// available
> 		try {
> 			try {
> 				String getterName = getGetterName(fieldName);
>-				getterMethod = clazz.getMethod(getterName, new Class[] {});
>+				getterMethod = sourceType.getMethod(getterName, new Class[] {});
> 			} catch (NoSuchMethodException e) {
> 				String getterName = getBooleanGetterName(fieldName);
>-				getterMethod = clazz.getMethod(getterName, new Class[] {});
>+				getterMethod = sourceType.getMethod(getterName, new Class[] {});
> 			}
> 			returnType = getterMethod.getReturnType();
>-			setterMethod = clazz.getMethod(getSetterName(fieldName),
>+			setterMethod = sourceType.getMethod(getSetterName(fieldName),
> 					new Class[] { returnType });
>-			addPropertyListenerMethod = clazz
>+			addPropertyListenerMethod = sourceType
> 					.getMethod(
> 							"addPropertyChangeListener", new Class[] { IPropertyChangeListener.class }); //$NON-NLS-1$
>-			removePropertyListenerMethod = clazz
>+			removePropertyListenerMethod = sourceType
> 					.getMethod(
> 							"removePropertyChangeListener", new Class[] { IPropertyChangeListener.class }); //$NON-NLS-1$
> 		} catch (SecurityException e) {
>@@ -124,6 +126,10 @@
> 		}
> 	}
> 
>+	public Object getSourceType() {
>+		return sourceType;
>+	}
>+
> 	public INativePropertyListener adaptListener(
> 			ISimplePropertyListener listener) {
> 		return new Listener(listener);
>Index: src/org/eclipse/jface/databinding/swt/WidgetListProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/swt/WidgetListProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 WidgetListProperty.java
>--- src/org/eclipse/jface/databinding/swt/WidgetListProperty.java	10 Feb 2009 18:53:04 -0000	1.2
>+++ src/org/eclipse/jface/databinding/swt/WidgetListProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -34,10 +34,7 @@
> public abstract class WidgetListProperty extends SimpleListProperty implements
> 		IWidgetListProperty {
> 	public IObservableList observe(Object source) {
>-		if (source instanceof Widget) {
>-			return observe((Widget) source);
>-		}
>-		return super.observe(source);
>+		return observe((Widget) source);
> 	}
> 
> 	public IObservableList observe(Realm realm, Object source) {
>Index: src/org/eclipse/jface/databinding/swt/WidgetValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/swt/WidgetValueProperty.java,v
>retrieving revision 1.3
>diff -u -r1.3 WidgetValueProperty.java
>--- src/org/eclipse/jface/databinding/swt/WidgetValueProperty.java	4 Mar 2009 01:03:58 -0000	1.3
>+++ src/org/eclipse/jface/databinding/swt/WidgetValueProperty.java	16 Mar 2009 21:06:22 -0000
>@@ -164,10 +164,7 @@
> 	}
> 
> 	public IObservableValue observe(Object source) {
>-		if (source instanceof Widget) {
>-			return observe((Widget) source);
>-		}
>-		return super.observe(source);
>+		return observe((Widget) source);
> 	}
> 
> 	public IObservableValue observe(Realm realm, Object source) {
>#P org.eclipse.core.databinding.property
>Index: src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimplePropertyObservableSet.java
>--- src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java	11 Mar 2009 21:51:48 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/property/set/SimplePropertyObservableSet.java	16 Mar 2009 21:06:25 -0000
>@@ -53,8 +53,8 @@
> 	 * @param source
> 	 * @param property
> 	 */
>-	public SimplePropertyObservableSet(Realm realm, Object source,
>-			SimpleSetProperty property) {
>+	public SimplePropertyObservableSet(Realm realm, final Object source,
>+			final SimpleSetProperty property) {
> 		super(realm);
> 		this.source = source;
> 		this.property = property;
>Index: src/org/eclipse/core/internal/databinding/property/set/SelfSetProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/set/SelfSetProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SelfSetProperty.java
>--- src/org/eclipse/core/internal/databinding/property/set/SelfSetProperty.java	11 Mar 2009 21:51:48 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/property/set/SelfSetProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -33,6 +33,10 @@
> 		this.elementType = elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return Set.class;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>@@ -49,11 +53,4 @@
> 			ISimplePropertyListener listener) {
> 		return null; // no listener API
> 	}
>-
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
> }
>\ No newline at end of file
>Index: src/org/eclipse/core/databinding/property/value/SimpleValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/value/SimpleValueProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimpleValueProperty.java
>--- src/org/eclipse/core/databinding/property/value/SimpleValueProperty.java	4 Mar 2009 01:04:00 -0000	1.4
>+++ src/org/eclipse/core/databinding/property/value/SimpleValueProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -23,6 +23,7 @@
> import org.eclipse.core.internal.databinding.property.value.MapSimpleValueObservableMap;
> import org.eclipse.core.internal.databinding.property.value.SetSimpleValueObservableMap;
> import org.eclipse.core.internal.databinding.property.value.SimplePropertyObservableValue;
>+import org.eclipse.core.runtime.Assert;
> 
> /**
>  * Simplified abstract implementation of IValueProperty. This class takes care
>@@ -44,6 +45,15 @@
>  */
> public abstract class SimpleValueProperty extends ValueProperty {
> 	/**
>+	 * Returns the type of source object this property may be used with.
>+	 * 
>+	 * @return the type of source object this property may be used with.
>+	 */
>+	public Object getSourceType() {
>+		return null;
>+	}
>+
>+	/**
> 	 * Returns the value of the property on the specified source object
> 	 * 
> 	 * @param source
>@@ -101,6 +111,7 @@
> 			ISimplePropertyListener listener);
> 
> 	public IObservableValue observe(Realm realm, Object source) {
>+		checkSourceType(source);
> 		return new SimplePropertyObservableValue(realm, source, this);
> 	}
> 
>@@ -115,4 +126,15 @@
> 	public IObservableMap observeDetail(IObservableMap master) {
> 		return new MapSimpleValueObservableMap(master, this);
> 	}
>+
>+	protected void checkSourceType(Object source) {
>+		if (source == null)
>+			return;
>+		Object sourceType = getSourceType();
>+		if (sourceType instanceof Class) {
>+			Class sourceClass = (Class) sourceType;
>+			Assert.isTrue(sourceClass.isInstance(source), "The source object " //$NON-NLS-1$
>+					+ source + " is not an instance of " + sourceClass); //$NON-NLS-1$
>+		}
>+	}
> }
>\ No newline at end of file
>Index: src/org/eclipse/core/internal/databinding/property/value/SelfValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SelfValueProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 SelfValueProperty.java
>--- src/org/eclipse/core/internal/databinding/property/value/SelfValueProperty.java	6 Feb 2009 23:21:05 -0000	1.1
>+++ src/org/eclipse/core/internal/databinding/property/value/SelfValueProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -20,17 +20,21 @@
>  * 
>  */
> public final class SelfValueProperty extends SimpleValueProperty {
>-	private final Object valueType;
>+	private final Object selfType;
> 
> 	/**
>-	 * @param valueType
>+	 * @param selfType
> 	 */
>-	public SelfValueProperty(Object valueType) {
>-		this.valueType = valueType;
>+	public SelfValueProperty(Object selfType) {
>+		this.selfType = selfType;
>+	}
>+
>+	public Object getSourceType() {
>+		return selfType;
> 	}
> 
> 	public Object getValueType() {
>-		return valueType;
>+		return selfType;
> 	}
> 
> 	protected Object doGetValue(Object source) {
>@@ -44,11 +48,4 @@
> 			ISimplePropertyListener listener) {
> 		return null;
> 	}
>-
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
> }
>\ No newline at end of file
>Index: src/org/eclipse/core/internal/databinding/property/value/ObservableValueProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/ObservableValueProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 ObservableValueProperty.java
>--- src/org/eclipse/core/internal/databinding/property/value/ObservableValueProperty.java	4 Mar 2009 01:04:00 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/property/value/ObservableValueProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -45,6 +45,10 @@
> 		this.valueType = valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return IObservableValue.class;
>+	}
>+
> 	public Object getValueType() {
> 		return valueType;
> 	}
>Index: src/org/eclipse/core/internal/databinding/property/value/SimplePropertyObservableValue.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/value/SimplePropertyObservableValue.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimplePropertyObservableValue.java
>--- src/org/eclipse/core/internal/databinding/property/value/SimplePropertyObservableValue.java	4 Mar 2009 22:35:16 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/property/value/SimplePropertyObservableValue.java	16 Mar 2009 21:06:25 -0000
>@@ -45,8 +45,8 @@
> 	 * @param source
> 	 * @param property
> 	 */
>-	public SimplePropertyObservableValue(Realm realm, Object source,
>-			SimpleValueProperty property) {
>+	public SimplePropertyObservableValue(Realm realm, final Object source,
>+			final SimpleValueProperty property) {
> 		super(realm);
> 		this.source = source;
> 		this.property = property;
>Index: src/org/eclipse/core/databinding/property/list/SimpleListProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/list/SimpleListProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimpleListProperty.java
>--- src/org/eclipse/core/databinding/property/list/SimpleListProperty.java	4 Mar 2009 01:04:00 -0000	1.4
>+++ src/org/eclipse/core/databinding/property/list/SimpleListProperty.java	16 Mar 2009 21:06:24 -0000
>@@ -21,6 +21,7 @@
> import org.eclipse.core.databinding.property.INativePropertyListener;
> import org.eclipse.core.databinding.property.ISimplePropertyListener;
> import org.eclipse.core.internal.databinding.property.list.SimplePropertyObservableList;
>+import org.eclipse.core.runtime.Assert;
> 
> /**
>  * Simplified abstract implementation of IListProperty. This class takes care of
>@@ -42,12 +43,33 @@
>  */
> public abstract class SimpleListProperty extends ListProperty {
> 	public IObservableList observe(Realm realm, Object source) {
>+		checkSourceType(source);
> 		return new SimplePropertyObservableList(realm, source, this);
> 	}
> 
>+	protected void checkSourceType(Object source) {
>+		if (source == null)
>+			return;
>+		Object sourceType = getSourceType();
>+		if (sourceType instanceof Class) {
>+			Class sourceClass = (Class) sourceType;
>+			Assert.isTrue(sourceClass.isInstance(source), "The source object " //$NON-NLS-1$
>+					+ source + " is not an instance of " + sourceClass); //$NON-NLS-1$
>+		}
>+	}
>+
> 	// Accessors
> 
> 	/**
>+	 * Returns the type of source object this property may be used with.
>+	 * 
>+	 * @return the type of source object this property may be used with.
>+	 */
>+	public Object getSourceType() {
>+		return null;
>+	}
>+
>+	/**
> 	 * Returns an unmodifiable List with the current contents of the source's
> 	 * list property
> 	 * 
>Index: src/org/eclipse/core/internal/databinding/property/map/SelfMapProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/map/SelfMapProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SelfMapProperty.java
>--- src/org/eclipse/core/internal/databinding/property/map/SelfMapProperty.java	11 Mar 2009 21:51:48 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/property/map/SelfMapProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -36,6 +36,10 @@
> 		this.valueType = valueType;
> 	}
> 
>+	public Object getSourceType() {
>+		return Map.class;
>+	}
>+
> 	public Object getKeyType() {
> 		return keyType;
> 	}
>@@ -56,11 +60,4 @@
> 			ISimplePropertyListener listener) {
> 		return null; // no listener API
> 	}
>-
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
> }
>\ No newline at end of file
>Index: src/org/eclipse/core/internal/databinding/property/map/SimplePropertyObservableMap.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/map/SimplePropertyObservableMap.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimplePropertyObservableMap.java
>--- src/org/eclipse/core/internal/databinding/property/map/SimplePropertyObservableMap.java	11 Mar 2009 21:51:48 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/property/map/SimplePropertyObservableMap.java	16 Mar 2009 21:06:25 -0000
>@@ -56,8 +56,8 @@
> 	 * @param source
> 	 * @param property
> 	 */
>-	public SimplePropertyObservableMap(Realm realm, Object source,
>-			SimpleMapProperty property) {
>+	public SimplePropertyObservableMap(Realm realm, final Object source,
>+			final SimpleMapProperty property) {
> 		super(realm);
> 		this.source = source;
> 		this.property = property;
>Index: src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimplePropertyObservableList.java
>--- src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java	11 Mar 2009 21:51:48 -0000	1.4
>+++ src/org/eclipse/core/internal/databinding/property/list/SimplePropertyObservableList.java	16 Mar 2009 21:06:25 -0000
>@@ -56,8 +56,8 @@
> 	 * @param source
> 	 * @param property
> 	 */
>-	public SimplePropertyObservableList(Realm realm, Object source,
>-			SimpleListProperty property) {
>+	public SimplePropertyObservableList(Realm realm, final Object source,
>+			final SimpleListProperty property) {
> 		super(realm);
> 		this.source = source;
> 		this.property = property;
>Index: src/org/eclipse/core/internal/databinding/property/list/SelfListProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/internal/databinding/property/list/SelfListProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 SelfListProperty.java
>--- src/org/eclipse/core/internal/databinding/property/list/SelfListProperty.java	11 Mar 2009 21:51:48 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/property/list/SelfListProperty.java	16 Mar 2009 21:06:25 -0000
>@@ -33,6 +33,10 @@
> 		this.elementType = elementType;
> 	}
> 
>+	public Object getSourceType() {
>+		return List.class;
>+	}
>+
> 	public Object getElementType() {
> 		return elementType;
> 	}
>@@ -49,11 +53,4 @@
> 			ISimplePropertyListener listener) {
> 		return null; // no listener API
> 	}
>-
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
> }
>\ No newline at end of file
>Index: src/org/eclipse/core/databinding/property/map/SimpleMapProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/map/SimpleMapProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimpleMapProperty.java
>--- src/org/eclipse/core/databinding/property/map/SimpleMapProperty.java	4 Mar 2009 01:04:00 -0000	1.4
>+++ src/org/eclipse/core/databinding/property/map/SimpleMapProperty.java	16 Mar 2009 21:06:24 -0000
>@@ -21,6 +21,7 @@
> import org.eclipse.core.databinding.property.INativePropertyListener;
> import org.eclipse.core.databinding.property.ISimplePropertyListener;
> import org.eclipse.core.internal.databinding.property.map.SimplePropertyObservableMap;
>+import org.eclipse.core.runtime.Assert;
> 
> /**
>  * Simplified abstract implementation of IMapProperty. This class takes care of
>@@ -43,12 +44,33 @@
>  */
> public abstract class SimpleMapProperty extends MapProperty {
> 	public IObservableMap observe(Realm realm, Object source) {
>+		checkSourceType(source);
> 		return new SimplePropertyObservableMap(realm, source, this);
> 	}
> 
>+	protected void checkSourceType(Object source) {
>+		if (source == null)
>+			return;
>+		Object sourceType = getSourceType();
>+		if (sourceType instanceof Class) {
>+			Class sourceClass = (Class) sourceType;
>+			Assert.isTrue(sourceClass.isInstance(source), "The source object " //$NON-NLS-1$
>+					+ source + " is not an instance of " + sourceClass); //$NON-NLS-1$
>+		}
>+	}
>+
> 	// Accessors
> 
> 	/**
>+	 * Returns the type of source object this property may be used with.
>+	 * 
>+	 * @return the type of source object this property may be used with.
>+	 */
>+	public Object getSourceType() {
>+		return null;
>+	}
>+
>+	/**
> 	 * Returns an unmodifiable Map with the current contents of the source's map
> 	 * property.
> 	 * 
>Index: src/org/eclipse/core/databinding/property/set/SimpleSetProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/set/SimpleSetProperty.java,v
>retrieving revision 1.4
>diff -u -r1.4 SimpleSetProperty.java
>--- src/org/eclipse/core/databinding/property/set/SimpleSetProperty.java	4 Mar 2009 01:04:00 -0000	1.4
>+++ src/org/eclipse/core/databinding/property/set/SimpleSetProperty.java	16 Mar 2009 21:06:24 -0000
>@@ -21,6 +21,7 @@
> import org.eclipse.core.databinding.property.INativePropertyListener;
> import org.eclipse.core.databinding.property.ISimplePropertyListener;
> import org.eclipse.core.internal.databinding.property.set.SimplePropertyObservableSet;
>+import org.eclipse.core.runtime.Assert;
> 
> /**
>  * Simplified abstract implementation of ISetProperty. This class takes care of
>@@ -42,12 +43,33 @@
>  */
> public abstract class SimpleSetProperty extends SetProperty {
> 	public IObservableSet observe(Realm realm, Object source) {
>+		checkSourceType(source);
> 		return new SimplePropertyObservableSet(realm, source, this);
> 	}
> 
>+	protected void checkSourceType(Object source) {
>+		if (source == null)
>+			return;
>+		Object sourceType = getSourceType();
>+		if (sourceType instanceof Class) {
>+			Class sourceClass = (Class) sourceType;
>+			Assert.isTrue(sourceClass.isInstance(source), "The source object " //$NON-NLS-1$
>+					+ source + " is not an instance of " + sourceClass); //$NON-NLS-1$
>+		}
>+	}
>+
> 	// Accessors
> 
> 	/**
>+	 * Returns the type of source object this property may be used with.
>+	 * 
>+	 * @return the type of source object this property may be used with.
>+	 */
>+	public Object getSourceType() {
>+		return null;
>+	}
>+
>+	/**
> 	 * Returns a Set with the current contents of the source's set property
> 	 * 
> 	 * @param source
>#P org.eclipse.core.databinding
>Index: src/org/eclipse/core/internal/databinding/BindingModelProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/BindingModelProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 BindingModelProperty.java
>--- src/org/eclipse/core/internal/databinding/BindingModelProperty.java	5 Mar 2009 19:12:09 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/BindingModelProperty.java	16 Mar 2009 21:06:26 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class BindingModelProperty extends SimpleValueProperty {
>+	public Object getSourceType() {
>+		return Binding.class;
>+	}
>+
> 	public Object getValueType() {
> 		return IObservable.class;
> 	}
>@@ -40,13 +44,6 @@
> 		return null;
> 	}
> 
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
>-
> 	public String toString() {
> 		return "Binding#model <IObservable>"; //$NON-NLS-1$
> 	}
>Index: src/org/eclipse/core/internal/databinding/BindingTargetProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/BindingTargetProperty.java,v
>retrieving revision 1.2
>diff -u -r1.2 BindingTargetProperty.java
>--- src/org/eclipse/core/internal/databinding/BindingTargetProperty.java	5 Mar 2009 19:12:09 -0000	1.2
>+++ src/org/eclipse/core/internal/databinding/BindingTargetProperty.java	16 Mar 2009 21:06:26 -0000
>@@ -22,6 +22,10 @@
>  * 
>  */
> public class BindingTargetProperty extends SimpleValueProperty {
>+	public Object getSourceType() {
>+		return Binding.class;
>+	}
>+
> 	public Object getValueType() {
> 		return IObservable.class;
> 	}
>@@ -40,13 +44,6 @@
> 		return null;
> 	}
> 
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
>-
> 	public String toString() {
> 		return "Binding#target <IObservable>"; //$NON-NLS-1$
> 	}
>Index: src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.databinding/src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java,v
>retrieving revision 1.1
>diff -u -r1.1 ValidationStatusProviderValidationStatusProperty.java
>--- src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java	7 Feb 2009 00:39:25 -0000	1.1
>+++ src/org/eclipse/core/internal/databinding/ValidationStatusProviderValidationStatusProperty.java	16 Mar 2009 21:06:26 -0000
>@@ -23,6 +23,10 @@
>  */
> public final class ValidationStatusProviderValidationStatusProperty extends
> 		SimpleValueProperty {
>+	public Object getSourceType() {
>+		return ValidationStatusProvider.class;
>+	}
>+
> 	public Object getValueType() {
> 		return IObservableValue.class;
> 	}
>@@ -41,13 +45,6 @@
> 		return null;
> 	}
> 
>-	protected void doAddListener(Object source, INativePropertyListener listener) {
>-	}
>-
>-	protected void doRemoveListener(Object source,
>-			INativePropertyListener listener) {
>-	}
>-
> 	public String toString() {
> 		return "ValidationStatusProvider#validationStatus <IObservableValue>"; //$NON-NLS-1$
> 	}

Actions: View | Diff

Attachments on bug 262284: 128961 | 128962 | 128999 | 129000 | 129001 | 129002