Attachment 126410 Details for Bug 249240 – proposed IRemoteServiceID and additions to IRemoteServiceRegistration, IRemoteServiceReference and IRemoteServiceContainerAdapter

[patch] proposed IRemoteServiceID and additions to IRemoteServiceRegistration, IRemoteServiceReference and IRemoteServiceContainerAdapter

remoteserviceid.patch (text/plain), 6.72 KB, created by Scott Lewis

on 2009-02-22 14:10:15 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Scott Lewis

Created: 2009-02-22 14:10:15 EST

Size: 6.72 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ecf.remoteservice
>Index: src/org/eclipse/ecf/remoteservice/IRemoteServiceReference.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.ecf/framework/bundles/org.eclipse.ecf.remoteservice/src/org/eclipse/ecf/remoteservice/IRemoteServiceReference.java,v
>retrieving revision 1.11
>diff -u -r1.11 IRemoteServiceReference.java
>--- src/org/eclipse/ecf/remoteservice/IRemoteServiceReference.java	11 Feb 2009 22:10:55 -0000	1.11
>+++ src/org/eclipse/ecf/remoteservice/IRemoteServiceReference.java	22 Feb 2009 19:07:44 -0000
>@@ -23,6 +23,14 @@
>  */
> public interface IRemoteServiceReference {
> 	/**
>+	 * Get the remote service ID for this reference.  Will not return <code>null</code>.
>+	 * 
>+	 * @return IRemoteServiceID the id for the remote service associated with this
>+	 * reference.
>+	 */
>+	public IRemoteServiceID getID();
>+
>+	/**
> 	 * Get container ID for remote service
> 	 * 
> 	 * @return ID the containerID for this reference (where the service is
>Index: src/org/eclipse/ecf/remoteservice/IRemoteServiceRegistration.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.ecf/framework/bundles/org.eclipse.ecf.remoteservice/src/org/eclipse/ecf/remoteservice/IRemoteServiceRegistration.java,v
>retrieving revision 1.7
>diff -u -r1.7 IRemoteServiceRegistration.java
>--- src/org/eclipse/ecf/remoteservice/IRemoteServiceRegistration.java	11 Feb 2009 22:10:55 -0000	1.7
>+++ src/org/eclipse/ecf/remoteservice/IRemoteServiceRegistration.java	22 Feb 2009 19:07:44 -0000
>@@ -12,7 +12,6 @@
> package org.eclipse.ecf.remoteservice;
> 
> import java.util.Dictionary;
>-
> import org.eclipse.ecf.core.identity.ID;
> 
> /**
>@@ -23,6 +22,15 @@
>  * 
>  */
> public interface IRemoteServiceRegistration {
>+
>+	/**
>+	 * Get the remote service ID for this registration.  Will not return <code>null</code>.
>+	 * 
>+	 * @return IRemoteServiceID the id for the remote service associated with this
>+	 * registration.
>+	 */
>+	public IRemoteServiceID getID();
>+
> 	/**
> 	 * Get the container ID for the registration
> 	 * 
>Index: src/org/eclipse/ecf/remoteservice/IRemoteServiceContainerAdapter.java
>===================================================================
>RCS file: /cvsroot/rt/org.eclipse.ecf/framework/bundles/org.eclipse.ecf.remoteservice/src/org/eclipse/ecf/remoteservice/IRemoteServiceContainerAdapter.java,v
>retrieving revision 1.12
>diff -u -r1.12 IRemoteServiceContainerAdapter.java
>--- src/org/eclipse/ecf/remoteservice/IRemoteServiceContainerAdapter.java	11 Feb 2009 22:10:55 -0000	1.12
>+++ src/org/eclipse/ecf/remoteservice/IRemoteServiceContainerAdapter.java	22 Feb 2009 19:07:44 -0000
>@@ -13,8 +13,7 @@
> 
> import java.util.Dictionary;
> import org.eclipse.core.runtime.IAdaptable;
>-import org.eclipse.ecf.core.identity.ID;
>-import org.eclipse.ecf.core.identity.Namespace;
>+import org.eclipse.ecf.core.identity.*;
> import org.eclipse.equinox.concurrent.future.IFuture;
> import org.osgi.framework.*;
> 
>@@ -161,6 +160,33 @@
> 	public IFuture asyncGetRemoteServiceReferences(ID[] idFilter, String clazz, String filter);
> 
> 	/**
>+	 * Get namespace to use for this remote service provider.
>+	 * @return Namespace to use for creating IRemoteServiceID for this remote service provider.  Will
>+	 * not return <code>null</code>.
>+	 * @since 3.0
>+	 */
>+	public Namespace getRemoteServiceNamespace();
>+
>+	/**
>+	 * Create a remote service ID from a containerID and a containerRelative identifier.
>+	 * 
>+	 * @param containerID the containerID to use to create the IRemoteServiceID.  Cannot be <code>null</code>.
>+	 * @param containerRelativeID the containerRelativeID to use to create the IRemoteServiceID.
>+	 * @return IRemoteServiceID created
>+	 */
>+	public IRemoteServiceID createRemoteServiceID(ID containerID, int containerRelativeID) throws IDCreateException;
>+
>+	/**
>+	 * Get the remote service reference known to this container for the given IRemoteServiceID.  Note that
>+	 * this method must be guaranteed not to block by the provider implementation.
>+	 * 
>+	 * @param serviceID the serviceID to retrieve the IRemoteServiceReference for.
>+	 * @return IRemoteServiceReference the remote service reference associated with the given serviceID.
>+	 * Will return <code>null</code> if no IRemoteServiceReference found for the given serviceID.
>+	 */
>+	public IRemoteServiceReference getRemoteServiceReference(IRemoteServiceID serviceID);
>+
>+	/**
> 	 * Get remote service for given IRemoteServiceReference. Note that clients
> 	 * that call this method successfully should later call
> 	 * {@link IRemoteServiceContainerAdapter#ungetRemoteService(IRemoteServiceReference)}
>@@ -197,14 +223,6 @@
> 	public boolean ungetRemoteService(IRemoteServiceReference reference);
> 
> 	/**
>-	 * Get namespace to use for this remote service provider.
>-	 * @return Namespace to use for creating IDs for this remote service provider.  Will
>-	 * not return <code>null</code>.
>-	 * @since 3.0
>-	 */
>-	public Namespace getRemoteServiceNamespace();
>-
>-	/**
> 	 * Creates a <code>IRemoteFilter</code> object. This <code>IRemoteFilter</code> object may
> 	 * be used to match a <code>IRemoteServiceReference</code> object or a
> 	 * <code>Dictionary</code> object.
>Index: src/org/eclipse/ecf/remoteservice/IRemoteServiceID.java
>===================================================================
>RCS file: src/org/eclipse/ecf/remoteservice/IRemoteServiceID.java
>diff -N src/org/eclipse/ecf/remoteservice/IRemoteServiceID.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/ecf/remoteservice/IRemoteServiceID.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,26 @@
>+/*******************************************************************************
>+* Copyright (c) 2009 EclipseSource and others. All rights reserved. This
>+* program and the accompanying materials are made available under the terms of
>+* the Eclipse Public License v1.0 which accompanies this distribution, and is
>+* available at http://www.eclipse.org/legal/epl-v10.html
>+*
>+* Contributors:
>+*   EclipseSource - initial API and implementation
>+******************************************************************************/
>+package org.eclipse.ecf.remoteservice;
>+
>+import org.eclipse.ecf.core.identity.ID;
>+
>+public interface IRemoteServiceID extends ID {
>+	/**
>+	 * Get the container ID for this remote service.  Will not return <code>null</code>.
>+	 * @return ID the ID for the container associated with this remote service.  Will not return <code>null</code>.
>+	 */
>+	public ID getContainerID();
>+
>+	/**
>+	 * Get container-relative ID for the remote service identified
>+	 * @return int the container-relative ID.  
>+	 */
>+	public int getContainerRelativeID();
>+}

Actions: View | Diff

Attachments on bug 249240: 123177 | 126410 | 126703 | 128704 | 128705 | 131191 | 134797