Attachment 118444 Details for Bug 255840 – Proposed patch

[patch] Proposed patch

v00.txt (text/plain), 2.62 KB, created by Frederic Fusier

on 2008-11-21 05:03:39 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2008-11-21 05:03:39 EST

Size: 2.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.test.performance
>Index: src/org/eclipse/test/internal/performance/InternalPerformanceMeter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.test.performance/src/org/eclipse/test/internal/performance/InternalPerformanceMeter.java,v
>retrieving revision 1.19
>diff -u -r1.19 InternalPerformanceMeter.java
>--- src/org/eclipse/test/internal/performance/InternalPerformanceMeter.java	1 Feb 2008 17:17:44 -0000	1.19
>+++ src/org/eclipse/test/internal/performance/InternalPerformanceMeter.java	21 Nov 2008 09:07:06 -0000
>@@ -122,27 +122,36 @@
> 					String nameString= "  " + dimension.getName() + ":"; //$NON-NLS-1$ //$NON-NLS-2$
> 					String meanString= dimension.getDisplayValue(mean);
> 					int align= firstNonDigit(meanString);
>-					meanString= spaces.substring(0, 30 - align - nameString.length()) + meanString;
>+					int endIndex = 30 - align - nameString.length();
>+					if (endIndex > 0) meanString= spaces.substring(0, endIndex) + meanString;
> 
> 					align= nameString.length() + meanString.length();
> 
> 					Percentile percentile= StatisticsUtil.T95;
> 					double[] confidenceInterval= s.getConfidenceInterval(dimension, percentile);
> 
>-					String confidenceString= n <= 2
>-					? " (no confidence)" //$NON-NLS-1$
>-							: spaces.substring(0, 40 - align) + format.format(new Object[] {new Double(percentile.inside()), dimension.getDisplayValue(confidenceInterval[0]), dimension.getDisplayValue(confidenceInterval[1])});
>+					StringBuffer printBuffer;
>+					if (n <= 2) {
>+						printBuffer = new StringBuffer(" (no confidence)"); //$NON-NLS-1$
>+					} else {
>+						printBuffer = new StringBuffer();
>+						int ns = align;
>+						while (ns++ < 40) printBuffer.append(' ');
>+						printBuffer.append(format.format(new Object[] {new Double(percentile.inside()), dimension.getDisplayValue(confidenceInterval[0]), dimension.getDisplayValue(confidenceInterval[1])}));
>+					}
> 
>-					align+= confidenceString.length();
>-					String sizeWarning;
>+					align+= printBuffer.length();
> 					try {
>-						sizeWarning= spaces.substring(0, 70 - align) + checkSampleSize(s, sample, dimension);
>+						while (align++ < 70) printBuffer.append(' ');
>+						printBuffer.append(checkSampleSize(s, sample, dimension));
> 					} catch (CoreException x) {
> 						badDimensions.add(dimension);
> 						continue;
> 					}
> 
>-					ps.println(nameString + meanString + confidenceString + sizeWarning);
>+					ps.print(nameString);
>+					ps.print(meanString);
>+					ps.println(printBuffer);
> 				}
> 				
> 				if (!badDimensions.isEmpty()) {

Actions: View | Diff

Attachments on bug 255840: 118444