Attachment 118135 Details for Bug 255641 – Proposed patch

[patch] Proposed patch

v00.txt (text/plain), 2.88 KB, created by Frederic Fusier

on 2008-11-18 09:01:53 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Frederic Fusier

Created: 2008-11-18 09:01:53 EST

Size: 2.88 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.test.performance.ui
>Index: src/org/eclipse/test/performance/ui/Main.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.releng.basebuilder/plugins/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/Main.java,v
>retrieving revision 1.54
>diff -u -r1.54 Main.java
>--- src/org/eclipse/test/performance/ui/Main.java	8 Nov 2008 12:49:04 -0000	1.54
>+++ src/org/eclipse/test/performance/ui/Main.java	18 Nov 2008 14:00:33 -0000
>@@ -553,9 +553,9 @@
> 	// Print reference to global results
> 	if (!isGlobal) {
> 		stream.print("<?php\n");
>-		stream.print("	$type=$QUERY_STRING;\n");
>+		stream.print("	$type=$_SERVER['QUERY_STRING'];\n");
> 		stream.print("	if ($type==\"\") {\n");
>-		stream.print("        $type=\"fp_type=0\";\n");
>+		stream.print("		$type=\"fp_type=0\";\n");
> 		stream.print("	}\n");
> 		stream.print("	$href=\"<a href=\\\"performance.php?\";\n");
> 		stream.print("	$href=$href . $type . \"\\\">Back to global results</a><br><br>\";\n");
>Index: src/org/eclipse/test/performance/ui/FingerPrint.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.releng.basebuilder/plugins/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrint.java,v
>retrieving revision 1.30
>diff -u -r1.30 FingerPrint.java
>--- src/org/eclipse/test/performance/ui/FingerPrint.java	8 Nov 2008 11:06:27 -0000	1.30
>+++ src/org/eclipse/test/performance/ui/FingerPrint.java	18 Nov 2008 14:00:33 -0000
>@@ -162,7 +162,8 @@
> 			this.stream.print(boxName);
> 			this.stream.print("</h4>\n");
> 			this.stream.print("<?php\n");
>-			this.stream.print("	if ($QUERY_STRING==\"\" || $QUERY_STRING==\"fp_type=0\") {\n");
>+			this.stream.print("	$type=$_SERVER['QUERY_STRING'];\n");
>+			this.stream.print("	if ($type==\"\" || $type==\"fp_type=0\") {\n");
> 			this.stream.print("		echo '<img src=\"");
> 			this.stream.print(fileName);
> 			this.stream.print(".gif\" usemap=\"#");
>Index: src/org/eclipse/test/performance/ui/FingerPrintGraph.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.releng.basebuilder/plugins/org.eclipse.test.performance.ui/src/org/eclipse/test/performance/ui/FingerPrintGraph.java,v
>retrieving revision 1.1
>diff -u -r1.1 FingerPrintGraph.java
>--- src/org/eclipse/test/performance/ui/FingerPrintGraph.java	8 Nov 2008 11:06:27 -0000	1.1
>+++ src/org/eclipse/test/performance/ui/FingerPrintGraph.java	18 Nov 2008 14:00:33 -0000
>@@ -635,7 +635,7 @@
> 
> void print(int kind, PrintStream stream) {
> 	String imgName = getImageName(kind);
>-	stream.print("	if ($QUERY_STRING==\"fp_type="+kind+"\") {\n");
>+	stream.print("	if ($type==\"fp_type="+kind+"\") {\n");
> 	stream.print("		echo '<img src=\"");
> 	stream.print(imgName);
> 	stream.print(".gif\" usemap=\"#");

Actions: View | Diff

Attachments on bug 255641: 118135