Attachment 117559 Details for Bug 242431 – Updated patch

[patch] Updated patch

patch.txt (text/plain), 9.69 KB, created by Kevin Doyle

on 2008-11-11 11:33:06 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2008-11-11 11:33:06 EST

Size: 9.69 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/internal/ui/view/search/SystemSearchViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/search/SystemSearchViewPart.java,v
>retrieving revision 1.6
>diff -u -r1.6 SystemSearchViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/search/SystemSearchViewPart.java	15 May 2007 23:54:30 -0000	1.6
>+++ UI/org/eclipse/rse/internal/ui/view/search/SystemSearchViewPart.java	11 Nov 2008 16:31:50 -0000
>@@ -13,6 +13,7 @@
>  * Contributors:
>  * Martin Oberhuber (Wind River) - [168975] Move RSE Events API to Core
>  * Martin Oberhuber (Wind River) - [186773] split ISystemRegistryUI from ISystemRegistry
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view.search;
>@@ -535,6 +536,7 @@
> 		SystemSearchTableView viewer = new SystemSearchTableView(tabletree, resultSet, this);
> 		
> 		getSite().registerContextMenu(viewer.getContextMenuManager(), viewer);
>+		getSite().registerContextMenu(ISystemContextMenuConstants.RSE_CONTEXT_MENU, viewer.getContextMenuManager(), viewer);
> 		return viewer;
> 	}
> 
>Index: UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java,v
>retrieving revision 1.41
>diff -u -r1.41 SystemTableViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java	23 May 2008 20:08:18 -0000	1.41
>+++ UI/org/eclipse/rse/internal/ui/view/SystemTableViewPart.java	11 Nov 2008 16:31:49 -0000
>@@ -39,6 +39,7 @@
>  * David McKnight   (IBM)        - [232320] remote system details view restore problem
>  * David McKnight   (IBM)        - [233578] Promptable Filter Displayed 3 times when clicking cancel
>  * David Dykstal (IBM) - [233678] title string is constructed by concatenation, should be substituted
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
> *******************************************************/
> 
> package org.eclipse.rse.internal.ui.view;
>@@ -92,6 +93,7 @@
> import org.eclipse.rse.internal.ui.actions.SystemCommonDeleteAction;
> import org.eclipse.rse.internal.ui.actions.SystemCommonRenameAction;
> import org.eclipse.rse.services.clientserver.messages.SystemMessage;
>+import org.eclipse.rse.ui.ISystemContextMenuConstants;
> import org.eclipse.rse.ui.ISystemIconConstants;
> import org.eclipse.rse.ui.RSEUIPlugin;
> import org.eclipse.rse.ui.SystemActionViewerFilter;
>@@ -1271,6 +1273,7 @@
> 		SystemWidgetHelpers.setHelp(_viewer.getControl(), RSEUIPlugin.HELPPREFIX + "sysd0000"); //$NON-NLS-1$
> 
> 		getSite().registerContextMenu(_viewer.getContextMenuManager(), _viewer);
>+		getSite().registerContextMenu(ISystemContextMenuConstants.RSE_CONTEXT_MENU, _viewer.getContextMenuManager(), _viewer);
> 	}
> 
> 	public void selectionChanged(IWorkbenchPart part, ISelection sel)
>Index: UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java,v
>retrieving revision 1.41
>diff -u -r1.41 SystemViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	25 Sep 2008 17:46:33 -0000	1.41
>+++ UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	11 Nov 2008 16:31:50 -0000
>@@ -34,6 +34,7 @@
>  * Kevin Doyle 	 (IBM) - [186769] Enable Contributions to Drop Down menu of Remote Systems view -> Preferences
>  * David McKnight (IBM)  - [244807] System view does not handle restore from cache
>  * David McKnight (IBM)  - [247544] [performance] Restoring Selection on Restart can cause the UI to freeze
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
>  *******************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view;
>@@ -397,6 +398,7 @@
> 		// Enable right-click popup menu
> 		// -----------------------------
> 		getSite().registerContextMenu(systemView.getContextMenuManager(), systemView);
>+		getSite().registerContextMenu(ISystemContextMenuConstants.RSE_CONTEXT_MENU, systemView.getContextMenuManager(), systemView);
> 
> 		// ----------------------------------------------------------------------
> 		// Enable property sheet updates when tree items are selected.
>Index: UI/org/eclipse/rse/internal/ui/view/scratchpad/SystemScratchpadViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/scratchpad/SystemScratchpadViewPart.java,v
>retrieving revision 1.11
>diff -u -r1.11 SystemScratchpadViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/scratchpad/SystemScratchpadViewPart.java	2 Aug 2007 16:40:30 -0000	1.11
>+++ UI/org/eclipse/rse/internal/ui/view/scratchpad/SystemScratchpadViewPart.java	11 Nov 2008 16:31:50 -0000
>@@ -17,6 +17,7 @@
>  * Kevin Doyle (IBM) - [195543] Double Clicking expands wrong folder when duplicate elements shown
>  * Kevin Doyle (IBM) - [193155] Double Clicking on a String in Scratchpad Errors
>  * Kevin Doyle (IBM) - [194867] Remote Scratchpad should have Refresh Action on toolbar
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view.scratchpad;
>@@ -43,6 +44,7 @@
> import org.eclipse.rse.internal.ui.actions.SystemCommonDeleteAction;
> import org.eclipse.rse.internal.ui.actions.SystemCommonRenameAction;
> import org.eclipse.rse.services.clientserver.messages.SystemMessage;
>+import org.eclipse.rse.ui.ISystemContextMenuConstants;
> import org.eclipse.rse.ui.RSEUIPlugin;
> import org.eclipse.rse.ui.SystemWidgetHelpers;
> import org.eclipse.rse.ui.actions.SystemCopyToClipboardAction;
>@@ -158,6 +160,7 @@
> 		setInput(SystemRegistryUI.getInstance().getSystemScratchPad());
> 		
> 		getSite().registerContextMenu(_viewer.getContextMenuManager(), _viewer);
>+		getSite().registerContextMenu(ISystemContextMenuConstants.RSE_CONTEXT_MENU, _viewer.getContextMenuManager(), _viewer);
> 	}
> 
> 	public void selectionChanged(IWorkbenchPart part, ISelection sel)
>Index: UI/org/eclipse/rse/internal/ui/view/monitor/MonitorViewWorkbook.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/monitor/MonitorViewWorkbook.java,v
>retrieving revision 1.3
>diff -u -r1.3 MonitorViewWorkbook.java
>--- UI/org/eclipse/rse/internal/ui/view/monitor/MonitorViewWorkbook.java	28 Jun 2007 19:53:13 -0000	1.3
>+++ UI/org/eclipse/rse/internal/ui/view/monitor/MonitorViewWorkbook.java	11 Nov 2008 16:31:50 -0000
>@@ -14,12 +14,14 @@
>  * Contributors:
>  * {Name} (company) - description of contribution.
>  * Kevin Doyle (IBM) - [177587] createTabItem sets the wrapped selection provider
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
>  *******************************************************************************/
> 
> package org.eclipse.rse.internal.ui.view.monitor;
> 
> import org.eclipse.core.runtime.IAdaptable;
> import org.eclipse.rse.core.subsystems.ISubSystem;
>+import org.eclipse.rse.ui.ISystemContextMenuConstants;
> import org.eclipse.rse.ui.view.ISystemViewElementAdapter;
> import org.eclipse.rse.ui.view.SystemTableView;
> import org.eclipse.swt.SWT;
>@@ -234,6 +236,7 @@
> 		{
> 			_viewPart.setActiveViewerSelectionProvider(viewer);
> 			_viewPart.getSite().registerContextMenu(viewer.getContextMenuManager(), viewer);
>+			_viewPart.getSite().registerContextMenu(ISystemContextMenuConstants.RSE_CONTEXT_MENU, viewer.getContextMenuManager(), viewer);
> 		}
> 		monitorViewPage.setFocus();
> 	}
>Index: UI/org/eclipse/rse/ui/ISystemContextMenuConstants.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/ISystemContextMenuConstants.java,v
>retrieving revision 1.2
>diff -u -r1.2 ISystemContextMenuConstants.java
>--- UI/org/eclipse/rse/ui/ISystemContextMenuConstants.java	4 Dec 2006 21:10:34 -0000	1.2
>+++ UI/org/eclipse/rse/ui/ISystemContextMenuConstants.java	11 Nov 2008 16:31:50 -0000
>@@ -12,6 +12,7 @@
>  * 
>  * Contributors:
>  * {Name} (company) - description of contribution.
>+ * Kevin Doyle 		(IBM)		 - [242431] Register a new unique context menu id, so contributions can be made to all our views
>  ********************************************************************************/
> 
> package org.eclipse.rse.ui;
>@@ -45,6 +46,17 @@
>  */
> public interface ISystemContextMenuConstants
> {
>+	
>+	/**
>+	 * Context menu id used by all RSE views, such that menu's can be contributed
>+	 * to all views.
>+	 *
>+	 * RSE Views: Remote Systems, Remote System Details, Monitor, and Scratchpad
>+	 * Note: This does does not work with dialog's which have the SystemView 
>+	 * embedded in them.
>+	 */
>+	public static final String RSE_CONTEXT_MENU = "org.eclipse.rse.views.common"; //$NON-NLS-1$
>+	
> 	/**
> 	 * Pop-up menu: name of group for goto actions (value <code>"group.goto"</code>).
> 	 * <p>

Actions: View | Diff

Attachments on bug 242431: 117550 | 117559