Attachment 116309 Details for Bug 237503 – patch that delays reflow on resize

[patch] patch that delays reflow on resize

editor-reflow-optimization.patch (text/plain), 1.79 KB, created by David Green

on 2008-10-28 11:52:18 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Green

Created: 2008-10-28 11:52:18 EDT

Size: 1.79 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java,v
>retrieving revision 1.86
>diff -u -r1.86 AbstractTaskEditorPage.java
>--- src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java	17 Oct 2008 05:38:21 -0000	1.86
>+++ src/org/eclipse/mylyn/tasks/ui/editors/AbstractTaskEditorPage.java	28 Oct 2008 15:50:55 -0000
>@@ -159,6 +159,30 @@
>  */
> public abstract class AbstractTaskEditorPage extends FormPage implements ISelectionProvider, ISelectionChangedListener {
> 
>+	/**
>+	 * a resize listener that causes the form page to reflow
>+	 */
>+	private final class ParentResizeHandler implements Listener {
>+		private int generation = 0;
>+
>+		public void handleEvent(Event event) {
>+			// bug 237503: delay the reflow as an optimization
>+			++generation;
>+
>+			Display.getCurrent().timerExec(150, new Runnable() {
>+				int scheduledGeneration = generation;
>+
>+				public void run() {
>+					// Only reflow if this is the latest generation.  This prevents
>+					// unnecessary reflows
>+					if (scheduledGeneration == generation) {
>+						getManagedForm().reflow(true);
>+					}
>+				}
>+			});
>+		}
>+	}
>+
> 	private class SubmitTaskJobListener extends SubmitJobListener {
> 
> 		private final boolean attachContext;
>@@ -497,11 +521,7 @@
> 
> 	@Override
> 	public void createPartControl(Composite parent) {
>-		parent.addListener(SWT.Resize, new Listener() {
>-			public void handleEvent(Event event) {
>-				getManagedForm().reflow(true);
>-			}
>-		});
>+		parent.addListener(SWT.Resize, new ParentResizeHandler());
> 		super.createPartControl(parent);
> 	}
>

Actions: View | Diff

Attachments on bug 237503: 105187 | 105303 | 105304 | 105305 | 105557 | 105660 | 105661 | 105668 | 105673 | 105675 | 105676 | 105771 | 106983 | 106984 | 107152 | 107213 | 110406 | 110407 | 113955 | 113956 | 116251 | 116309