Attachment 112070 Details for Bug 73923 – patch #6

[patch] patch #6

patch-external-6.txt (text/plain), 28.21 KB, created by Aleksandra Wozniak

on 2008-09-09 07:14:03 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aleksandra Wozniak

Created: 2008-09-09 07:14:03 EDT

Size: 28.21 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.compare
>Index: compare/org/eclipse/compare/internal/CompareWithOtherResourceAction.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.compare/plugins/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareWithOtherResourceAction.java,v
>retrieving revision 1.2
>diff -u -r1.2 CompareWithOtherResourceAction.java
>--- compare/org/eclipse/compare/internal/CompareWithOtherResourceAction.java	19 Aug 2008 07:58:04 -0000	1.2
>+++ compare/org/eclipse/compare/internal/CompareWithOtherResourceAction.java	9 Sep 2008 11:11:32 -0000
>@@ -23,6 +23,8 @@
> 		// Show CompareWithOtherResourceDialog which return resources to compare
> 		// and ancestor if specified. Don't need to display the other dialog
> 		showSelectAncestorDialog = false;
>+		// prevent reusing old temporary files
>+		CompareWithOtherResourceDialog.cleanup();
> 		super.run(selection);
> 	}
> 
>Index: compare/org/eclipse/compare/internal/CompareMessages.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.compare/plugins/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.java,v
>retrieving revision 1.18
>diff -u -r1.18 CompareMessages.java
>--- compare/org/eclipse/compare/internal/CompareMessages.java	19 Aug 2008 07:58:04 -0000	1.18
>+++ compare/org/eclipse/compare/internal/CompareMessages.java	9 Sep 2008 11:11:32 -0000
>@@ -118,8 +118,18 @@
> 	public static String CompareWithOther_error_not_comparable;
> 	public static String CompareWithOther_error_empty;
> 	public static String CompareWithOther_clear;
>-	public static String CompareWithOther_warning_two_way;
> 	public static String CompareWithOther_info;
>+	public static String CompareWithOther_externalFileButton;
>+	public static String CompareWithOther_externalFile_errorTitle;
>+	public static String CompareWithOther_externalFile_errorMessage;
>+	public static String CompareWithOther_pathLabel;
>+	public static String CompareWithOther_externalFolderBUtton;
>+	public static String CompareWithOtherResourceDialog_externalFileMainButton;
>+	public static String CompareWithOtherResourceDialog_externalFileRadioButton;
>+	public static String CompareWithOtherResourceDialog_externalFolderMainButton;
>+	public static String CompareWithOtherResourceDialog_externalFolderRadioButton;
>+	public static String CompareWithOtherResourceDialog_workspaceMainButton;
>+	public static String CompareWithOtherResourceDialog_workspaceRadioButton;
> 
> 	static {
> 		NLS.initializeMessages(BUNDLE_NAME, CompareMessages.class);
>Index: compare/org/eclipse/compare/internal/CompareWithOtherResourceDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.compare/plugins/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareWithOtherResourceDialog.java,v
>retrieving revision 1.4
>diff -u -r1.4 CompareWithOtherResourceDialog.java
>--- compare/org/eclipse/compare/internal/CompareWithOtherResourceDialog.java	20 Aug 2008 08:47:36 -0000	1.4
>+++ compare/org/eclipse/compare/internal/CompareWithOtherResourceDialog.java	9 Sep 2008 11:11:32 -0000
>@@ -10,12 +10,25 @@
>  *******************************************************************************/
> package org.eclipse.compare.internal;
> 
>+import java.io.FileOutputStream;
>+import java.io.IOException;
>+
> import org.eclipse.compare.CompareConfiguration;
>+import org.eclipse.compare.CompareUI;
>+import org.eclipse.core.resources.IFile;
>+import org.eclipse.core.resources.IFolder;
>+import org.eclipse.core.resources.IProject;
>+import org.eclipse.core.resources.IProjectDescription;
> import org.eclipse.core.resources.IResource;
>+import org.eclipse.core.resources.IWorkspace;
> import org.eclipse.core.resources.IWorkspaceRoot;
> import org.eclipse.core.resources.ResourcesPlugin;
>+import org.eclipse.core.runtime.CoreException;
>+import org.eclipse.core.runtime.IPath;
>+import org.eclipse.core.runtime.Path;
> import org.eclipse.jface.dialogs.IDialogConstants;
> import org.eclipse.jface.dialogs.IMessageProvider;
>+import org.eclipse.jface.dialogs.MessageDialog;
> import org.eclipse.jface.dialogs.TitleAreaDialog;
> import org.eclipse.jface.viewers.ISelection;
> import org.eclipse.jface.viewers.StructuredSelection;
>@@ -38,8 +51,11 @@
> import org.eclipse.swt.widgets.Button;
> import org.eclipse.swt.widgets.Composite;
> import org.eclipse.swt.widgets.Control;
>+import org.eclipse.swt.widgets.DirectoryDialog;
>+import org.eclipse.swt.widgets.Event;
>+import org.eclipse.swt.widgets.FileDialog;
> import org.eclipse.swt.widgets.Group;
>-import org.eclipse.swt.widgets.Label;
>+import org.eclipse.swt.widgets.Listener;
> import org.eclipse.swt.widgets.Shell;
> import org.eclipse.swt.widgets.Text;
> import org.eclipse.ui.forms.events.ExpansionAdapter;
>@@ -53,41 +69,53 @@
>  * @since 3.4
>  */
> public class CompareWithOtherResourceDialog extends TitleAreaDialog {
>-
>-	private int CLEAR_RETURN_CODE = 150; // any number != 0
>+	
> 	private int MIN_WIDTH = 300;
> 	private int MIN_HEIGHT = 175;
>+	
>+	public static final String TMP_PROJECT_NAME = ".org.eclipse.compare.tmp"; //$NON-NLS-1$
>+	private final static String TMP_PROJECT_FILE = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n" //$NON-NLS-1$
>+			+ "<projectDescription>\n" //$NON-NLS-1$
>+			+ "\t<name>" + TMP_PROJECT_NAME + "\t</name>\n" //$NON-NLS-1$ //$NON-NLS-2$
>+			+ "\t<comment></comment>\n" //$NON-NLS-1$
>+			+ "\t<projects>\n" //$NON-NLS-1$
>+			+ "\t</projects>\n" //$NON-NLS-1$
>+			+ "\t<buildSpec>\n" //$NON-NLS-1$
>+			+ "\t</buildSpec>\n" //$NON-NLS-1$
>+			+ "\t<natures>\n" + "\t</natures>\n" //$NON-NLS-1$//$NON-NLS-2$
>+			+ "</projectDescription>"; //$NON-NLS-1$
>+	private final static String EXTERNAL_FILES_FOLDER_NAME = "ExternalFilesFolder"; //$NON-NLS-1$
> 
> 	private class FileTextDragListener implements DragSourceListener {
> 
>-		private InternalSection section;
>+		private ContentTypeElement element;
> 
>-		public FileTextDragListener(InternalSection section) {
>-			this.section = section;
>+		public FileTextDragListener(ContentTypeElement element) {
>+			this.element = element;
> 		}
> 
> 		public void dragFinished(DragSourceEvent event) {
>-			section.fileText.setText(""); //$NON-NLS-1$
>+			element.setText(""); //$NON-NLS-1$
> 		}
> 
> 		public void dragSetData(DragSourceEvent event) {
>-			event.data = section.fileText.getText();
>+			event.data = element.getText();
> 		}
> 
> 		public void dragStart(DragSourceEvent event) {
>-			if (section.fileText.getText() == null)
>+			if (element.getText() == null)
> 				event.doit = false;
> 		}
> 	}
> 
> 	private class FileTextDropListener implements DropTargetListener {
> 
>-		private InternalSection section;
>+		private ContentTypeElement element;
> 		private ResourceTransfer resourceTransfer;
> 		private TextTransfer textTransfer;
> 
>-		public FileTextDropListener(InternalSection section) {
>-			this.section = section;
>+		public FileTextDropListener(ContentTypeElement element) {
>+			this.element = element;
> 			resourceTransfer = ResourceTransfer.getInstance();
> 			textTransfer = TextTransfer.getInstance();
> 		}
>@@ -139,13 +167,13 @@
> 				String txt = (String) event.data;
> 				IResource r = ResourcesPlugin.getWorkspace().getRoot().findMember(txt);
> 				if (r != null)
>-					section.setResource(r);
>+					element.setResource(r);
> 			} else if (resourceTransfer.isSupportedType(event.currentDataType)) {
> 				IResource[] files = (IResource[]) event.data;
>-				section.setResource(files[0]);
>+				if (files.length > 0)
>+					element.setResource(files[0]);
> 			}
> 
>-			updateErrorInfo();
> 		}
> 
> 		public void dropAccept(DropTargetEvent event) {
>@@ -153,57 +181,128 @@
> 		}
> 
> 	}
>-
>-	private abstract class InternalSection {
>-
>-		protected Group group;
>-		protected Text fileText;
>+	
>+	private abstract class ContentTypeElement {
>+		
>+		private Button radioButton;
>+		protected Button mainButton;
>+		protected Text text;
>+		private String type;
>+		protected InternalSection section;
> 		private IResource resource;
>-
>-		public InternalSection(Composite parent) {
>+		
>+		public ContentTypeElement(Composite parent, String type, InternalSection section) {
>+			this.type = type;
>+			this.section = section;
> 			createContents(parent);
> 		}
>-
>-		private InternalSection() {
>-			// not to instantiate
>+		
>+		private void createContents(Composite parent) {
>+			createRadioButton(parent);
>+			createText(parent);
>+			createMainButton(parent);
>+		}
>+		
>+		private void createRadioButton(Composite parent) {
>+			radioButton = new Button(parent, SWT.RADIO);
>+			radioButton.setText(type);
>+		}
>+
>+		protected void createText(Composite parent) {
>+			text = new Text(parent, SWT.BORDER);
>+			text.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, true));
>+			text.setEditable(false);
>+		}
>+		
>+		protected void createMainButton(Composite parent) {
>+			mainButton = new Button(parent, SWT.PUSH);
>+			mainButton.setLayoutData(new GridData(SWT.FILL, SWT.FILL, false, false));
>+		}
>+		
>+		protected Button getRadioButton() {
>+			return radioButton;
>+		}
>+		
>+		protected String getText() {
>+			return text.getText();
>+		}
>+		
>+		protected void setText(String string) {
>+			text.setText(string);
>+		}
>+		
>+		protected InternalSection getSection() {
>+			return section;
>+		}
>+		
>+		protected void setEnabled(boolean enabled) {
>+			radioButton.setSelection(enabled);
>+			mainButton.setEnabled(enabled);
>+			text.setEnabled(enabled);
> 		}
>-
>-		public void createContents(Composite parent) {
>-			createGroup(parent);
>-			createFileLabel();
>-			createFileCombo();
>-			initDrag();
>-			initDrop();
>+		
>+		protected void setResource(IResource resource) {
>+			this.resource = resource;
>+			section.setResource(resource);
> 		}
> 
> 		public IResource getResource() {
> 			return resource;
> 		}
>-
>-		public void setResource(IResource resource) {
>-			this.resource = resource;
>-			String txt = resource.getFullPath().toString();
>-			fileText.setText(txt);
>+		
>+		void clearResource() {
>+			resource = null;
>+			text.setText(""); //$NON-NLS-1$
> 		}
>+		
>+	}
>+	
>+	private class WorkspaceContent extends ContentTypeElement {
>+		
>+		public WorkspaceContent(Composite parent, InternalSection section) {
>+			super(parent, CompareMessages.CompareWithOtherResourceDialog_workspaceRadioButton, section);
>+		}
>+		
>+		protected void createMainButton(Composite parent) {
>+			super.createMainButton(parent);
>+			mainButton.setText(CompareMessages.CompareWithOtherResourceDialog_workspaceMainButton);
>+			// temporarily hide this button. For more information about supporting for browsing workspace see bug 243744.
>+			mainButton.setVisible(false);
>+		}
>+		
>+		protected void createText(Composite parent) {
>+			
>+			super.createText(parent);
>+			text.setEditable(true);
>+			
>+			text.addModifyListener(new ModifyListener() {
>+				public void modifyText(ModifyEvent e) {
>+					section.setResource(text.getText());
>+					updateErrorInfo();
>+				}
>+			});
> 
>-		public void setResource(String s) {
>-			IResource tmp = ResourcesPlugin.getWorkspace().getRoot()
>-					.findMember(s);
>-			if (tmp instanceof IWorkspaceRoot)
>-				resource = null;
>-			else
>-				resource = tmp;
>-
>+			text.addSelectionListener(new SelectionListener() {
>+				public void widgetDefaultSelected(SelectionEvent e) {
>+					widgetSelected(e);
>+				}
>+				public void widgetSelected(SelectionEvent e) {
>+					section.setResource(text.getText());
>+					updateErrorInfo();
>+				}
>+			});
>+			
>+			initDrag();
>+			initDrop();
> 		}
> 
>-		protected void clearResource() {
>-			resource = null;
>-			fileText.setText(""); //$NON-NLS-1$
>-			updateErrorInfo();
>+		protected void setResource(IResource resource) {
>+			super.setResource(resource);
>+			text.setText(resource.getFullPath().toOSString());
> 		}
> 
> 		protected void initDrag() {
>-			DragSource source = new DragSource(fileText, DND.DROP_MOVE
>+			DragSource source = new DragSource(text, DND.DROP_MOVE
> 					| DND.DROP_COPY | DND.DROP_DEFAULT);
> 			Transfer[] types = new Transfer[] { TextTransfer.getInstance(),
> 					ResourceTransfer.getInstance() };
>@@ -212,49 +311,170 @@
> 		}
> 
> 		protected void initDrop() {
>-			DropTarget target = new DropTarget(fileText, DND.DROP_MOVE
>+			DropTarget target = new DropTarget(text, DND.DROP_MOVE
> 					| DND.DROP_COPY | DND.DROP_DEFAULT);
> 			Transfer[] types = new Transfer[] { TextTransfer.getInstance(),
> 					ResourceTransfer.getInstance() };
> 			target.setTransfer(types);
> 			target.addDropListener(new FileTextDropListener(this));
> 		}
>-
>-		protected void createGroup(Composite parent) {
>-			group = new Group(parent, SWT.NONE);
>-			group.setLayout(new GridLayout(3, false));
>-			group.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false));
>-		}
>-
>-		protected void createFileCombo() {
>-			fileText = new Text(group, SWT.BORDER);
>-			fileText
>-					.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false));
>-
>-			fileText.addModifyListener(new ModifyListener() {
>-				public void modifyText(ModifyEvent e) {
>-					setResource(fileText.getText());
>-					updateErrorInfo();
>+		
>+	}
>+	
>+	private class ExternalFileContent extends ContentTypeElement {
>+		
>+		public ExternalFileContent(Composite parent, InternalSection section) {
>+			super(parent, CompareMessages.CompareWithOtherResourceDialog_externalFileRadioButton, section);
>+		}
>+		
>+		protected void createMainButton(Composite parent) {
>+			super.createMainButton(parent);
>+			mainButton.setText(CompareMessages.CompareWithOtherResourceDialog_externalFileMainButton);
>+			mainButton.addSelectionListener(new SelectionListener() {
>+				public void widgetDefaultSelected(SelectionEvent e) {
>+					widgetSelected(e);
>+				}
>+				public void widgetSelected(SelectionEvent e) {
>+					IResource r = getExtenalFile();
>+					if (r == null) 
>+						return;
>+					setResource(r);
> 				}
> 			});
>+		}
> 
>-			fileText.addSelectionListener(new SelectionListener() {
>-
>+		protected void setResource(IResource resource) {
>+			super.setResource(resource);
>+			text.setText(resource.getLocation().toOSString());
>+		}
>+		
>+	}
>+	
>+	private class ExternalFolderContent extends ContentTypeElement {
>+		
>+		public ExternalFolderContent(Composite parent, InternalSection section) {
>+			super(parent, CompareMessages.CompareWithOtherResourceDialog_externalFolderRadioButton, section);
>+		}
>+		
>+		protected void createMainButton(Composite parent) {
>+			super.createMainButton(parent);
>+			mainButton.setText(CompareMessages.CompareWithOtherResourceDialog_externalFolderMainButton);
>+			mainButton.addSelectionListener(new SelectionListener() {
> 				public void widgetDefaultSelected(SelectionEvent e) {
> 					widgetSelected(e);
> 				}
>-
> 				public void widgetSelected(SelectionEvent e) {
>-					setResource(fileText.getText());
>-					updateErrorInfo();
>+					IResource r = getExternalDirectory();
>+					if (r == null)
>+						return;
>+					setResource(r);
> 				}
>-
> 			});
> 		}
> 
>-		protected void createFileLabel() {
>-			final Label fileLabel = new Label(group, SWT.NONE);
>-			fileLabel.setText(CompareMessages.CompareWithOther_fileLabel);
>+		protected void setResource(IResource resource) {
>+			super.setResource(resource);
>+			text.setText(resource.getLocation().toOSString());
>+		}
>+		
>+	}
>+
>+	private abstract class InternalSection {
>+		
>+		// there is no "enum" support in Java 1.4. Sigh...
>+		public static final int WORKSPACE = 0;
>+		public static final int EXTERNAL_FILE = 1;
>+		public static final int EXTERNAL_FOLDER = 2;
>+
>+		protected Group group;
>+		private IResource resource;
>+		
>+		ExternalFileContent externalFileContent;
>+		ExternalFolderContent externalFolderContent;
>+		WorkspaceContent workspaceContent;
>+		
>+		public InternalSection(Composite parent) {
>+			createContents(parent);
>+		}
>+
>+		private InternalSection() {
>+			// not to instantiate
>+		}
>+
>+		protected void createContents(Composite parent) {
>+
>+			group = new Group(parent, SWT.NONE);
>+			group.setLayout(new GridLayout(3, false));
>+			group.setLayoutData(new GridData(SWT.FILL, SWT.FILL, true, false));
>+			
>+			workspaceContent = new WorkspaceContent(group, this);
>+			externalFileContent = new ExternalFileContent(group, this);
>+			externalFolderContent = new ExternalFolderContent(group, this);
>+			
>+			addListenersToRadioButtons();
>+		}
>+		
>+		private void addListenersToRadioButtons() {
>+			final ContentTypeElement[] elements = new ContentTypeElement[] { workspaceContent, 
>+					externalFileContent, externalFolderContent };
>+			for (int i = 0; i < elements.length; i++)
>+				elements[i].getRadioButton().addListener(SWT.Selection, new Listener() {
>+					public void handleEvent(Event event) {
>+						for (int j = 0; j < elements.length; j++)
>+							if (event.widget != elements[j].getRadioButton())
>+								elements[j].setEnabled(false);
>+							else {
>+								elements[j].setEnabled(true);
>+								setResource(elements[j].getResource());
>+							}
>+					}
>+				});
>+		}
>+
>+		protected IResource getResource() {
>+			return resource;
>+		}
>+
>+		protected void setResource(IResource resource) {
>+			this.resource = resource;
>+			updateErrorInfo();
>+		}
>+
>+		protected void setResource(String s) {
>+			IResource tmp = ResourcesPlugin.getWorkspace().getRoot()
>+					.findMember(s);
>+			if (tmp instanceof IWorkspaceRoot) 
>+				resource = null;
>+			else 
>+				resource = tmp;
>+			updateErrorInfo();
>+		}
>+
>+		protected void clearResource() {
>+			resource = null;
>+			workspaceContent.clearResource();
>+			externalFileContent.clearResource();
>+			externalFolderContent.clearResource();
>+			updateErrorInfo();
>+		}
>+		
>+		protected void setContentType(int type) {
>+			switch(type) {
>+			case WORKSPACE: 
>+				workspaceContent.setEnabled(true);
>+				externalFileContent.setEnabled(false);
>+				externalFolderContent.setEnabled(false);
>+				break;
>+			case EXTERNAL_FILE:
>+				workspaceContent.setEnabled(false);
>+				externalFileContent.setEnabled(true);
>+				externalFolderContent.setEnabled(false);
>+				break;
>+			case EXTERNAL_FOLDER:
>+				workspaceContent.setEnabled(false);
>+				externalFileContent.setEnabled(false);
>+				externalFolderContent.setEnabled(true);
>+			}
> 		}
> 	}
> 
>@@ -282,36 +502,28 @@
> 			createContents(parent);
> 		}
> 
>-		public void createContents(Composite parent) {
>-			createGroup(parent);
>-			createFileLabel();
>-			createFileCombo();
>-			createClearButton(group);
>-			initDrag();
>-			initDrop();
>-		}
>-
>-		public void createGroup(Composite parent) {
>+		protected void createContents(Composite parent) {
> 			final Composite p = parent;
> 			expandable = new ExpandableComposite(parent, SWT.NONE,
> 					ExpandableComposite.TREE_NODE | ExpandableComposite.TWISTIE);
>-			super.createGroup(expandable);
>+			super.createContents(expandable);
>+			createClearButton(group);
> 			expandable.setClient(group);
> 			expandable.addExpansionListener(new ExpansionAdapter() {
> 				public void expansionStateChanged(ExpansionEvent e) {
> 					p.layout();
>+					getShell().pack();
> 				}
> 			});
> 		}
> 
>-		protected void createClearButton(Composite parent) {
>-			clearButton = createButton(parent, CLEAR_RETURN_CODE,
>-					CompareMessages.CompareWithOther_clear, false);
>+		private void createClearButton(Composite parent) {
>+			clearButton = new Button(parent, SWT.PUSH);
>+			clearButton.setText(CompareMessages.CompareWithOther_clear);
> 			clearButton.addSelectionListener(new SelectionListener() {
> 				public void widgetDefaultSelected(SelectionEvent e) {
> 					widgetSelected(e);
> 				}
>-
> 				public void widgetSelected(SelectionEvent e) {
> 					clearResource();
> 				}
>@@ -332,6 +544,7 @@
> 	private InternalGroup rightPanel, leftPanel;
> 	private InternalExpandable ancestorPanel;
> 	private ISelection fselection;
>+	private int externalFilesCounter = 0;
> 
> 	/**
> 	 * Creates the dialog.
>@@ -403,30 +616,36 @@
> 		IResource[] selectedResources = Utilities.getResources(selection);
> 		switch (selectedResources.length) {
> 		case 1:
>-			leftPanel.setResource(selectedResources[0]);
>+			leftPanel.workspaceContent.setResource(selectedResources[0]);
> 			break;
> 		case 2:
>-			leftPanel.setResource(selectedResources[0]);
>-			rightPanel.setResource(selectedResources[1]);
>+			leftPanel.workspaceContent.setResource(selectedResources[0]);
>+			rightPanel.workspaceContent.setResource(selectedResources[1]);
> 			break;
> 		case 3:
>-			ancestorPanel.setResource(selectedResources[0]);
>+			ancestorPanel.workspaceContent.setResource(selectedResources[0]);
> 			ancestorPanel.expandable.setExpanded(true);
>-			leftPanel.setResource(selectedResources[1]);
>-			rightPanel.setResource(selectedResources[2]);
>+			leftPanel.workspaceContent.setResource(selectedResources[1]);
>+			rightPanel.workspaceContent.setResource(selectedResources[2]);
> 			break;
> 		}
>+		setInitialContentTypes();
>+	}
>+
>+	private void setInitialContentTypes() {
>+		ancestorPanel.setContentType(InternalSection.WORKSPACE);
>+		leftPanel.setContentType(InternalSection.WORKSPACE);
>+		rightPanel.setContentType(InternalSection.WORKSPACE);
> 	}
> 
> 	private boolean isComparePossible() {
> 		IResource[] resources;
>-		if (ancestorPanel.getResource() == null) {
>+		if (ancestorPanel.getResource() == null)
> 			resources = new IResource[] { leftPanel.getResource(),
> 					rightPanel.getResource() };
>-		} else {
>+		else
> 			resources = new IResource[] { ancestorPanel.getResource(),
> 					leftPanel.getResource(), rightPanel.getResource() };
>-		}
> 
> 		ResourceCompareInput r = new ResourceCompareInput(
> 				new CompareConfiguration());
>@@ -440,11 +659,6 @@
> 				setMessage(CompareMessages.CompareWithOther_error_empty,
> 						IMessageProvider.ERROR);
> 				okButton.setEnabled(false);
>-			} else if (ancestorPanel.getResource() == null
>-					&& ancestorPanel.fileText.getText() != "") { //$NON-NLS-1$
>-				setMessage(CompareMessages.CompareWithOther_warning_two_way,
>-						IMessageProvider.WARNING);
>-				okButton.setEnabled(true);
> 			} else if (!isComparePossible()) {
> 				setMessage(
> 						CompareMessages.CompareWithOther_error_not_comparable,
>@@ -456,6 +670,116 @@
> 			}
> 		}
> 	}
>+	
>+	private IFile getExtenalFile() {
>+		FileDialog dialog = new FileDialog(getShell());
>+		String path = dialog.open();
>+		if (path != null)
>+			return (IFile) getResource(new Path(path), IResource.FILE);
>+		return null;
>+	}
>+
>+	private IFolder getExternalDirectory() {
>+		DirectoryDialog dialog = new DirectoryDialog(getShell());
>+		String path = dialog.open();
>+		if (path != null)
>+			return (IFolder) getResource(new Path(path), IResource.FOLDER);
>+		return null;
>+	}
>+
>+	private IResource getResource(IPath path, int type) {
>+		IResource r = null;
>+		IWorkspace workspace = ResourcesPlugin.getWorkspace();
>+		IWorkspaceRoot root = workspace.getRoot();
>+		IProject project = root.getProject(TMP_PROJECT_NAME);
>+		String resourceName = path.lastSegment();
>+		try {
>+			project = createTmpProject();
>+			if (!project.isOpen())
>+				project.open(null);
>+			IFolder folderForExternal = project.getFolder(EXTERNAL_FILES_FOLDER_NAME);
>+			if (!folderForExternal.exists())
>+				folderForExternal.create(IResource.NONE, true, null);
>+			if (type == IResource.FILE) {
>+				r = folderForExternal.getFile(resourceName);
>+				if (r.exists()) { 	// add a number to file's name when there already is a file with that name in a folder
>+					String extension = path.getFileExtension();
>+					String newName = path.removeFileExtension().lastSegment(); 
>+					newName += "-" + externalFilesCounter + "." + extension; //$NON-NLS-1$ //$NON-NLS-2$
>+					r = folderForExternal.getFile(newName);
>+				}
>+				((IFile)r).createLink(path, IResource.REPLACE, null);
>+				externalFilesCounter++;
>+			}
>+			else {
>+				r = folderForExternal.getFolder(resourceName);
>+				if (r.exists()) {
>+					String newName = resourceName + "-" + externalFilesCounter; //$NON-NLS-1$
>+					r = folderForExternal.getFolder(newName);
>+				}
>+				((IFolder)r).createLink(path, IResource.REPLACE, null);
>+				externalFilesCounter++;
>+			}
>+		} catch (CoreException e) {
>+			CompareUIPlugin.log(e);
>+			MessageDialog.openError(getShell(),
>+							CompareMessages.CompareWithOther_externalFile_errorTitle,
>+							CompareMessages.CompareWithOther_externalFile_errorMessage);
>+		}
>+		return r;
>+	}
>+
>+	/*
>+	 * (non-javadoc)
>+	 *
>+	 * Implementation based on org.eclipse.jdt.internal.core.ExternalFoldersManager#createExternalFoldersProject
>+	 */
>+	private IProject createTmpProject() throws CoreException {
>+		IProject tmpProject = getTmpProject();
>+		if (!tmpProject.isAccessible()) {
>+			try {
>+				if (!tmpProject.exists()) {
>+					IProjectDescription desc = tmpProject.getWorkspace()
>+							.newProjectDescription(tmpProject.getName());
>+					IPath location = CompareUI.getPlugin()
>+							.getStateLocation();
>+					desc.setLocation(location.append(TMP_PROJECT_NAME));
>+					tmpProject.create(desc, null);
>+				}
>+				try {
>+					tmpProject.open(null);
>+				} catch (CoreException e1) { // in case .project file or folder has been deleted
>+					IPath location1 = CompareUI.getPlugin()
>+							.getStateLocation();
>+					IPath projectPath1 = location1.append(TMP_PROJECT_NAME);
>+					projectPath1.toFile().mkdirs();
>+					FileOutputStream output = new FileOutputStream(
>+							projectPath1.append(".project").toOSString()); //$NON-NLS-1$
>+					try {
>+						output.write(TMP_PROJECT_FILE.getBytes());
>+					} finally {
>+						output.close();
>+					}
>+					tmpProject.open(null);
>+				}
>+			} catch (IOException ioe) {
>+				return tmpProject;
>+			} catch (CoreException ce) {
>+				throw new CoreException(ce.getStatus());
>+			}
>+		}
>+		return tmpProject;
>+	}
>+
>+	/*
>+	 * (non-javadoc)
>+	 *
>+	 * Following method is analogical to org.eclipse.jdt.internal
>+	 */
>+	private IProject getTmpProject() {
>+		return ResourcesPlugin.getWorkspace().getRoot().getProject(
>+				TMP_PROJECT_NAME);
>+	}
> 
> 	/**
> 	 * Returns table with selected resources. If any resource wasn't chosen in
>@@ -477,4 +801,18 @@
> 					rightResource };
> 		return resources;
> 	}
>+	
>+	/**
>+	 * Removes temporary files created from clipboard's content or imported to 
>+	 * workspace only for comparing.
>+	 */
>+	public static void cleanup() {
>+		try {
>+			IProject project = ResourcesPlugin.getWorkspace().getRoot()
>+					.getProject(TMP_PROJECT_NAME);
>+			project.delete(true, true, null);
>+		} catch (CoreException e) {
>+			CompareUIPlugin.log(e);
>+		}
>+	}
> }
>Index: compare/org/eclipse/compare/internal/ResourceCompareInput.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.compare/plugins/org.eclipse.compare/compare/org/eclipse/compare/internal/ResourceCompareInput.java,v
>retrieving revision 1.39
>diff -u -r1.39 ResourceCompareInput.java
>--- compare/org/eclipse/compare/internal/ResourceCompareInput.java	19 Aug 2008 07:58:04 -0000	1.39
>+++ compare/org/eclipse/compare/internal/ResourceCompareInput.java	9 Sep 2008 11:11:32 -0000
>@@ -416,6 +416,11 @@
> 	
> 	private String buildLabel(IResource r) {
> 		String n= r.getFullPath().toString();
>+		// if it is a file from outside a current workspace show its location 
>+		// rather than its workspace path
>+		if (n.startsWith(IPath.SEPARATOR + CompareWithOtherResourceDialog.TMP_PROJECT_NAME) || 
>+				n.startsWith(CompareWithOtherResourceDialog.TMP_PROJECT_NAME))
>+			return r.getLocation().toString();
> 		if (n.charAt(0) == IPath.SEPARATOR)
> 			return n.substring(1);
> 		return n;
>Index: compare/org/eclipse/compare/internal/CompareMessages.properties
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.compare/plugins/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties,v
>retrieving revision 1.29
>diff -u -r1.29 CompareMessages.properties
>--- compare/org/eclipse/compare/internal/CompareMessages.properties	19 Aug 2008 07:58:04 -0000	1.29
>+++ compare/org/eclipse/compare/internal/CompareMessages.properties	9 Sep 2008 11:11:32 -0000
>@@ -129,6 +129,16 @@
> CompareWithOther_dialogMessage=Select resources to compare
> CompareWithOther_error_not_comparable=Selected resources are not comparable.
> CompareWithOther_error_empty=Both left and right panel must contain a valid path.
>-CompareWithOther_warning_two_way=Ancestor is not a valid resource. Two-way compare will be performed.
> CompareWithOther_clear=Clear
> CompareWithOther_info=Drag files from a view or between dialog's fields.
>+CompareWithOther_externalFileButton=External file...
>+CompareWithOther_externalFolderBUtton=External folder...
>+CompareWithOther_externalFile_errorTitle=Compare With Other Resource Error
>+CompareWithOther_externalFile_errorMessage=Cannot create a link to an external file.
>+CompareWithOther_pathLabel=Path:
>+CompareWithOtherResourceDialog_externalFileMainButton=Browse...
>+CompareWithOtherResourceDialog_externalFileRadioButton=External file
>+CompareWithOtherResourceDialog_externalFolderMainButton=Browse...
>+CompareWithOtherResourceDialog_externalFolderRadioButton=External folder
>+CompareWithOtherResourceDialog_workspaceMainButton=Browse...
>+CompareWithOtherResourceDialog_workspaceRadioButton=Workspace

Flags:

tomasz.zarna: iplog+

Actions: View | Diff

Attachments on bug 73923: 109656 | 110437 | 110778 | 110788 | 111014 | 111817 | 112070 | 112655 | 112656