Attachment 109987 Details for Bug 244051 – Patch to fix duplicate name checking in the environment variables page

[patch] Patch to fix duplicate name checking in the environment variables page

patch.txt (text/plain), 1.82 KB, created by Justin Lin

on 2008-08-14 10:20:28 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Lin

Created: 2008-08-14 10:20:28 EDT

Size: 1.82 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java,v
>retrieving revision 1.10
>diff -u -r1.10 EnvironmentVariablesForm.java
>--- UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java	14 May 2007 09:00:35 -0000	1.10
>+++ UI/org/eclipse/rse/ui/widgets/EnvironmentVariablesForm.java	14 Aug 2008 14:17:28 -0000
>@@ -12,7 +12,8 @@
>  * 
>  * Contributors:
>  * Martin Oberhuber (Wind River) - [175262] IHost.getSystemType() should return IRSESystemType 
>- * Martin Oberhuber (Wind River) - [186640] Add IRSESystemType.testProperty() 
>+ * Martin Oberhuber (Wind River) - [186640] Add IRSESystemType.testProperty()
>+ * Justin Lin (IBM) - [244051] JJ: Environment Variables property page allows duplicates...
>  ********************************************************************************/
> 
> package org.eclipse.rse.ui.widgets;
>@@ -591,16 +592,15 @@
> 				}
> 						
> 				// next check for duplicate env var names
>-				int numberFound = 0;
> 				int itemCount = envVarTable.getItemCount();
> 				for (int i = 0; i < itemCount; i++) {
> 					TableItem item = envVarTable.getItem(i);
> 					String itemName = item.getText(0);
>-					if (itemName.equals(name)) numberFound++;
>-				}
>-				if (numberFound > 1) {
>-					msg = RSEUIPlugin.getPluginMessage(ISystemMessages.MSG_COMM_ENVVAR_DUPLICATE);
>-					msg.makeSubstitution(name);
>+					if (itemName.equals(name) && i != envVarTable.getSelectionIndex()) {
>+						msg = RSEUIPlugin.getPluginMessage(ISystemMessages.MSG_COMM_ENVVAR_DUPLICATE);
>+						msg.makeSubstitution(name);
>+						break;
>+					}
> 				}
> 			}					
> 		}

Flags:

mober.at+eclipse: iplog+

Actions: View | Diff

Attachments on bug 244051: 109987 | 117661