Attachment 109299 Details for Bug 240856 – Patch

[patch] Patch

240856_v01.txt (text/plain), 2.78 KB, created by Pawel Pogorzelski

on 2008-08-06 09:41:23 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pawel Pogorzelski

Created: 2008-08-06 09:41:23 EDT

Size: 2.78 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.net
>Index: src/org/eclipse/ui/internal/net/ProxyPreferencePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.net/src/org/eclipse/ui/internal/net/ProxyPreferencePage.java,v
>retrieving revision 1.12
>diff -u -r1.12 ProxyPreferencePage.java
>--- src/org/eclipse/ui/internal/net/ProxyPreferencePage.java	5 Jun 2008 17:52:34 -0000	1.12
>+++ src/org/eclipse/ui/internal/net/ProxyPreferencePage.java	6 Aug 2008 13:38:43 -0000
>@@ -262,8 +262,8 @@
> 	}
> 
> 	protected void performDefaults() {
>-		directConnectionToButton.setSelection(true);
>-		systemProxyConfigurationButton.setSelection(false);
>+		directConnectionToButton.setSelection(false);
>+		systemProxyConfigurationButton.setSelection(true);
> 		manualProxyConfigurationButton.setSelection(false);
> 		useSameProxyButton.setSelection(false);
> 		enableProxyAuth.setSelection(false);
>#P org.eclipse.core.net
>Index: src/org/eclipse/core/internal/net/ProxyManager.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.core.net/src/org/eclipse/core/internal/net/ProxyManager.java,v
>retrieving revision 1.14
>diff -u -r1.14 ProxyManager.java
>--- src/org/eclipse/core/internal/net/ProxyManager.java	18 Apr 2008 10:04:49 -0000	1.14
>+++ src/org/eclipse/core/internal/net/ProxyManager.java	6 Aug 2008 13:38:45 -0000
>@@ -218,7 +218,7 @@
> 
> 	private boolean internalIsProxiesEnabled() {
> 		return Activator.getInstance().getPreferences().getBoolean(
>-				PREF_ENABLED, false);
>+				PREF_ENABLED, true);
> 	}
> 
> 	/* (non-Javadoc)
>@@ -412,7 +412,7 @@
> 		}
> 		
> 		// migrate proxy data
>-		boolean proxiesEnabled = netConfigurationPrefs.getBoolean(PREF_ENABLED, false);
>+		boolean proxiesEnabled = netConfigurationPrefs.getBoolean(PREF_ENABLED, true);
> 		for (int i = 0; i < proxies.length; i++) {
> 			ProxyType type = proxies[i];
> 			IProxyData data = type.getProxyData(ProxyType.DO_NOT_VERIFY);
>@@ -496,8 +496,8 @@
> 	public void preferenceChange(PreferenceChangeEvent event) {
> 		if (event.getKey().equals(PREF_ENABLED) || event.getKey().equals(PREF_OS)) {
> 			checkMigrated();
>-			internalSetEnabled(Activator.getInstance().getPreferences().getBoolean(PREF_ENABLED, false),
>-					Activator.getInstance().getPreferences().getBoolean(PREF_OS, false));
>+			internalSetEnabled(Activator.getInstance().getPreferences().getBoolean(PREF_ENABLED, true),
>+					Activator.getInstance().getPreferences().getBoolean(PREF_OS, true));
> 		}
> 	}
> 
>@@ -508,7 +508,7 @@
> 	public boolean isSystemProxiesEnabled() {
> 		checkMigrated();
> 		return Activator.getInstance().getPreferences().getBoolean(PREF_OS,
>-				false);
>+				true);
> 	}
> 
> 	public void setSystemProxiesEnabled(boolean enabled) {

Flags:

pawel.pogorzelski1: iplog+

Actions: View | Diff

Attachments on bug 240856: 109299