Attachment 108914 Details for Bug 175069 – Patch to use Dialog's static applyDialogFont(Control) method.

[patch] Patch to use Dialog's static applyDialogFont(Control) method.

bug175069-patch.txt (text/plain), 5.75 KB, created by Remy Suen

on 2008-07-31 20:20:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Remy Suen

Created: 2008-07-31 20:20:26 EDT

Size: 5.75 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.ide
>Index: src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java,v
>retrieving revision 1.36
>diff -u -r1.36 ResourceInfoPage.java
>--- src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java	25 Sep 2006 14:49:33 -0000	1.36
>+++ src/org/eclipse/ui/internal/ide/dialogs/ResourceInfoPage.java	1 Aug 2008 00:17:38 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2006 IBM Corporation and others.
>+ * Copyright (c) 2000, 2008 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -7,6 +7,7 @@
>  *
>  * Contributors:
>  *     IBM Corporation - initial API and implementation
>+ *     Remy Chi Jian Suen <remy.suen@gmail.com> - Bug 175069 [Preferences] ResourceInfoPage is not setting dialog font on all widgets
>  *******************************************************************************/
> package org.eclipse.ui.internal.ide.dialogs;
> 
>@@ -22,6 +23,7 @@
> import org.eclipse.core.runtime.CoreException;
> import org.eclipse.core.runtime.IPath;
> import org.eclipse.core.runtime.content.IContentDescription;
>+import org.eclipse.jface.dialogs.Dialog;
> import org.eclipse.jface.dialogs.ErrorDialog;
> import org.eclipse.jface.preference.FieldEditor;
> import org.eclipse.jface.util.IPropertyChangeListener;
>@@ -108,9 +110,6 @@
> 	 * @return the composite for the group
> 	 */
> 	private Composite createBasicInfoGroup(Composite parent, IResource resource) {
>-
>-		Font font = parent.getFont();
>-
> 		Composite basicInfoComposite = new Composite(parent, SWT.NULL);
> 		GridLayout layout = new GridLayout();
> 		layout.numColumns = 2;
>@@ -121,7 +120,6 @@
> 		data.verticalAlignment = GridData.FILL;
> 		data.horizontalAlignment = GridData.FILL;
> 		basicInfoComposite.setLayoutData(data);
>-		basicInfoComposite.setFont(font);
> 
> 		// The group for path
> 		Label pathLabel = new Label(basicInfoComposite, SWT.NONE);
>@@ -129,7 +127,6 @@
> 		GridData gd = new GridData();
> 		gd.verticalAlignment = SWT.TOP;
> 		pathLabel.setLayoutData(gd);
>-		pathLabel.setFont(font);
> 
> 		// path value label
> 		Text pathValueText = new Text(basicInfoComposite, SWT.WRAP
>@@ -142,21 +139,18 @@
> 		gd.grabExcessHorizontalSpace = true;
> 		gd.horizontalAlignment = GridData.FILL;
> 		pathValueText.setLayoutData(gd);
>-		pathValueText.setFont(font);
> 		pathValueText.setBackground(pathValueText.getDisplay().getSystemColor(
> 				SWT.COLOR_WIDGET_BACKGROUND));
> 
> 		// The group for types
> 		Label typeTitle = new Label(basicInfoComposite, SWT.LEFT);
> 		typeTitle.setText(TYPE_TITLE);
>-		typeTitle.setFont(font);
> 
> 		Text typeValue = new Text(basicInfoComposite, SWT.LEFT | SWT.READ_ONLY);
> 		typeValue.setText(IDEResourceInfoUtils.getTypeString(resource,
> 				getContentDescription(resource)));
> 		typeValue.setBackground(typeValue.getDisplay().getSystemColor(
> 				SWT.COLOR_WIDGET_BACKGROUND));
>-		typeValue.setFont(font);
> 
> 		// The group for location
> 		Label locationTitle = new Label(basicInfoComposite, SWT.LEFT);
>@@ -164,7 +158,6 @@
> 		gd = new GridData();
> 		gd.verticalAlignment = SWT.TOP;
> 		locationTitle.setLayoutData(gd);
>-		locationTitle.setFont(font);
> 
> 		Text locationValue = new Text(basicInfoComposite, SWT.WRAP
> 				| SWT.READ_ONLY);
>@@ -176,7 +169,6 @@
> 		gd.grabExcessHorizontalSpace = true;
> 		gd.horizontalAlignment = GridData.FILL;
> 		locationValue.setLayoutData(gd);
>-		locationValue.setFont(font);
> 		locationValue.setBackground(locationValue.getDisplay().getSystemColor(
> 				SWT.COLOR_WIDGET_BACKGROUND));
> 
>@@ -187,7 +179,6 @@
> 			gd = new GridData();
> 			gd.verticalAlignment = SWT.TOP;
> 			resolvedLocationTitle.setLayoutData(gd);
>-			resolvedLocationTitle.setFont(font);
> 
> 			Text resolvedLocationValue = new Text(basicInfoComposite, SWT.WRAP
> 					| SWT.READ_ONLY);
>@@ -198,7 +189,6 @@
> 			gd.grabExcessHorizontalSpace = true;
> 			gd.horizontalAlignment = GridData.FILL;
> 			resolvedLocationValue.setLayoutData(gd);
>-			resolvedLocationValue.setFont(font);
> 			resolvedLocationValue.setBackground(resolvedLocationValue
> 					.getDisplay().getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));
> 		}
>@@ -206,7 +196,6 @@
> 			// The group for size
> 			Label sizeTitle = new Label(basicInfoComposite, SWT.LEFT);
> 			sizeTitle.setText(SIZE_TITLE);
>-			sizeTitle.setFont(font);
> 
> 			Text sizeValue = new Text(basicInfoComposite, SWT.LEFT
> 					| SWT.READ_ONLY);
>@@ -216,7 +205,6 @@
> 			gd.grabExcessHorizontalSpace = true;
> 			gd.horizontalAlignment = GridData.FILL;
> 			sizeValue.setLayoutData(gd);
>-			sizeValue.setFont(font);
> 			sizeValue.setBackground(sizeValue.getDisplay().getSystemColor(
> 					SWT.COLOR_WIDGET_BACKGROUND));
> 		}
>@@ -297,6 +285,8 @@
> 			encodingEditor.setEnabled(false, composite);
> 			lineDelimiterEditor.setEnabled(false);
> 		}
>+		
>+		Dialog.applyDialogFont(composite);
> 
> 		return composite;
> 	}
>@@ -431,17 +421,14 @@
> 		GridData data = new GridData();
> 		data.horizontalAlignment = GridData.FILL;
> 		composite.setLayoutData(data);
>-		composite.setFont(font);
> 
> 		Label timeStampLabel = new Label(composite, SWT.NONE);
> 		timeStampLabel.setText(TIMESTAMP_TITLE);
>-		timeStampLabel.setFont(font);
> 
> 		// timeStamp value label
> 		Text timeStampValue = new Text(composite, SWT.READ_ONLY);
> 		timeStampValue.setText(IDEResourceInfoUtils
> 				.getDateStringValue(resource));
>-		timeStampValue.setFont(font);
> 		timeStampValue.setBackground(timeStampValue.getDisplay()
> 				.getSystemColor(SWT.COLOR_WIDGET_BACKGROUND));
> 		timeStampValue.setLayoutData(new GridData(GridData.FILL_HORIZONTAL

Flags:

remy.suen: iplog+

Actions: View | Diff

Attachments on bug 175069: 108914