Attachment 108889 Details for Bug 238202 – candidate patch

[patch] candidate patch

patch-238202.txt (text/plain), 1.19 KB, created by Boris Bokowski

on 2008-07-31 14:33:47 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Boris Bokowski

Created: 2008-07-31 14:33:47 EDT

Size: 1.19 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java,v
>retrieving revision 1.312
>diff -u -r1.312 WorkbenchPage.java
>--- Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	15 Jul 2008 13:02:37 -0000	1.312
>+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java	31 Jul 2008 18:33:00 -0000
>@@ -1239,10 +1239,16 @@
>      * @param ref the editor to make active, or <code>null</code> for no active editor
>      */
>     private void makeActiveEditor(IEditorReference ref) {
>-        if (ref == getActiveEditorReference()) {
>+        IEditorReference oldRef = getActiveEditorReference();
>+		if (ref == oldRef) {
>             return;
>         }
>         
>+        IEditorPart oldPart = (oldRef == null) ? null : oldRef.getEditor(false);
>+        if (oldPart != null) {
>+        	navigationHistory.markLocation(oldPart);
>+        }
>+        
>         IEditorPart part = (ref == null) ? null : ref.getEditor(true);
>         
>         if (part != null) {

Flags:

daniel_megert: review+

Actions: View | Diff

Attachments on bug 238202: 108889 | 121545