Attachment 108250 Details for Bug 241716 – updates local variable to handle potential change in .validate ()

[patch] updates local variable to handle potential change in .validate ()

patch.txt (text/plain), 2.22 KB, created by Richie Yu

on 2008-07-23 14:46:51 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Richie Yu

Created: 2008-07-23 14:46:51 EDT

Size: 2.22 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: subsystems/org/eclipse/rse/ui/subsystems/StandardCredentialsProvider.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/ui/subsystems/StandardCredentialsProvider.java,v
>retrieving revision 1.21
>diff -u -r1.21 StandardCredentialsProvider.java
>--- subsystems/org/eclipse/rse/ui/subsystems/StandardCredentialsProvider.java	5 May 2008 13:53:34 -0000	1.21
>+++ subsystems/org/eclipse/rse/ui/subsystems/StandardCredentialsProvider.java	23 Jul 2008 18:45:01 -0000
>@@ -206,8 +206,11 @@
> 		}
> 		ICredentialsValidator validator = getSignonValidator();
> 		boolean signonValid = true;
>+		ICredentials credentials = getCredentials();
> 		if (validator != null) {
>-			SystemMessage m = validator.validate(getCredentials());
>+			SystemMessage m = validator.validate(credentials);
>+			// update the password incase an expired password was changed in validate () - ry
>+			password = credentials.getPassword();  
> 			signonValid = (m == null);
> 			if (!signonValid) { // If we ran into an invalid stored password we need to tell the user.
> 				Shell shell = getShell();
>Index: UI/org/eclipse/rse/ui/dialogs/SystemPasswordPromptDialog.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/ui/dialogs/SystemPasswordPromptDialog.java,v
>retrieving revision 1.18
>diff -u -r1.18 SystemPasswordPromptDialog.java
>--- UI/org/eclipse/rse/ui/dialogs/SystemPasswordPromptDialog.java	6 Apr 2008 20:39:03 -0000	1.18
>+++ UI/org/eclipse/rse/ui/dialogs/SystemPasswordPromptDialog.java	23 Jul 2008 18:45:01 -0000
>@@ -504,6 +504,8 @@
> 			IRSESystemType systemType = connectorService.getHost().getSystemType();
> 			ICredentials credentials = new SystemSignonInformation(hostName, userId, password, systemType);
> 			SystemMessage m = signonValidator.validate(credentials);
>+			// update the password incase an expired password was changed in validate () - ry
>+			password = credentials.getPassword();  
> 			setErrorMessage(m);
> 		}
> 		boolean closeDialog = (getErrorMessage() == null);

Flags:

ddykstal.eclipse: iplog+

Actions: View | Diff

Attachments on bug 241716: 108245 | 108247 | 108250 | 108251 | 108252