Attachment 107168 Details for Bug 186769 – Example Contribution without API Change

[patch] Example Contribution without API Change

patch.txt (text/plain), 7.26 KB, created by Kevin Doyle

on 2008-07-10 23:57:32 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kevin Doyle

Created: 2008-07-10 23:57:32 EDT

Size: 7.26 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.ui
>Index: UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java,v
>retrieving revision 1.36
>diff -u -r1.36 SystemViewPart.java
>--- UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	28 Apr 2008 18:03:07 -0000	1.36
>+++ UI/org/eclipse/rse/internal/ui/view/SystemViewPart.java	11 Jul 2008 03:55:52 -0000
>@@ -53,6 +53,7 @@
> import org.eclipse.jface.action.IMenuManager;
> import org.eclipse.jface.action.IStatusLineManager;
> import org.eclipse.jface.action.IToolBarManager;
>+import org.eclipse.jface.action.MenuManager;
> import org.eclipse.jface.action.Separator;
> import org.eclipse.jface.resource.ImageDescriptor;
> import org.eclipse.jface.viewers.DoubleClickEvent;
>@@ -84,12 +85,12 @@
> import org.eclipse.rse.core.subsystems.ISubSystemConfiguration;
> import org.eclipse.rse.internal.core.RSEInitJob;
> import org.eclipse.rse.internal.ui.SystemResources;
>-import org.eclipse.rse.internal.ui.actions.SystemCascadingPreferencesAction;
> import org.eclipse.rse.internal.ui.actions.SystemCollapseAllAction;
> import org.eclipse.rse.internal.ui.actions.SystemImportConnectionAction;
> import org.eclipse.rse.internal.ui.actions.SystemPreferenceQualifyConnectionNamesAction;
> import org.eclipse.rse.internal.ui.actions.SystemPreferenceRestoreStateAction;
> import org.eclipse.rse.internal.ui.actions.SystemPreferenceShowFilterPoolsAction;
>+import org.eclipse.rse.internal.ui.actions.SystemShowPreferencesPageAction;
> import org.eclipse.rse.internal.ui.actions.SystemWorkWithProfilesAction;
> import org.eclipse.rse.services.clientserver.messages.SystemMessage;
> import org.eclipse.rse.ui.ISystemContextMenuConstants;
>@@ -679,8 +680,16 @@
> 
> 		// Now display any contributed action shortcuts for bringing up
> 		// a particular preference page...
>-		SystemCascadingPreferencesAction preferencesAction = new SystemCascadingPreferencesAction(shell);
>-		menuMgr.add(preferencesAction.getSubMenu());
>+		MenuManager subMenu = new MenuManager(SystemResources.ACTION_CASCADING_PREFERENCES_LABEL, ISystemContextMenuConstants.MENU_PREFERENCES);
>+		menuMgr.add(subMenu);
>+		
>+		SystemShowPreferencesPageAction action = new SystemShowPreferencesPageAction();
>+		action.setPreferencePageID("org.eclipse.rse.ui.preferences.RemoteSystemsPreferencePage"); //$NON-NLS-1$
>+		action.setText(SystemResources.ACTION_SHOW_PREFERENCEPAGE_LABEL);
>+		action.setToolTipText(SystemResources.ACTION_SHOW_PREFERENCEPAGE_TOOLTIP);
>+		action.setHelp("org.eclipse.rse.ui.aprefrse"); //$NON-NLS-1$
>+		subMenu.add(action);
>+		subMenu.add(new GroupMarker(ISystemContextMenuConstants.GROUP_ADDITIONS));
> 
> 		SystemViewMenuListener menuListener = new SystemViewMenuListener(true); // true says this is a persistent menu
> 		if (viewPart instanceof ISystemMessageLine)
>Index: UI/org/eclipse/rse/internal/ui/actions/SystemShowPreferencesPageAction.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/UI/org/eclipse/rse/internal/ui/actions/SystemShowPreferencesPageAction.java,v
>retrieving revision 1.3
>diff -u -r1.3 SystemShowPreferencesPageAction.java
>--- UI/org/eclipse/rse/internal/ui/actions/SystemShowPreferencesPageAction.java	14 May 2007 11:13:56 -0000	1.3
>+++ UI/org/eclipse/rse/internal/ui/actions/SystemShowPreferencesPageAction.java	11 Jul 2008 03:55:51 -0000
>@@ -127,6 +127,7 @@
> 	
> 		if (pm != null) 
> 		{
>+			shell = RSEUIPlugin.getTheSystemRegistryUI().getShell();
> 			PreferenceDialog d = new WorkbenchPreferenceDialog(shell, pm);
> 			d.create();
> 			// TODO - hack to make this work in  3.1
>Index: plugin.xml
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.ui/plugin.xml,v
>retrieving revision 1.55
>diff -u -r1.55 plugin.xml
>--- plugin.xml	2 Jun 2008 21:41:03 -0000	1.55
>+++ plugin.xml	11 Jul 2008 03:55:51 -0000
>@@ -508,5 +508,45 @@
>               id="org.eclipse.rse.ui.commands.category"
>               name="%View.Category.RemoteSystems">
>         </category>
>-      </extension>  
>+      </extension>
>+     
>+     <extension
>+         point="org.eclipse.ui.commands">
>+ 	<command
>+            categoryId="org.eclipse.rse.ui.commands.category"
>+            defaultHandler="org.eclipse.rse.internal.ui.actions.ShowPreferenceHandler"
>+            id="org.eclipse.rse.internal.ui.actions.ShowRemoteSystemsPref"
>+            name="Show Preference Page">
>+         <commandParameter
>+               id="org.eclipse.rse.internal.ui.actions.preference.page"
>+               name="Preference Page ID"
>+               optional="false">
>+          </commandParameter>
>+      </command>
>+      </extension>
>+     <extension
>+           point="org.eclipse.ui.menus">
>+        <menuContribution
>+              locationURI="menu:menu.preferences?after=additions">
>+           <command
>+                 commandId="org.eclipse.rse.internal.ui.actions.ShowRemoteSystemsPref"
>+                 label="Files..."
>+                 style="push">
>+              <parameter
>+                    name="org.eclipse.rse.internal.ui.actions.preference.page"
>+                    value="org.eclipse.rse.files.ui.UniversalFilesPreferences">
>+              </parameter>
>+           </command>
>+           <command
>+                 commandId="org.eclipse.rse.internal.ui.actions.ShowRemoteSystemsPref"
>+                 label="File Cache...."
>+                 style="push">
>+              <parameter
>+                    name="org.eclipse.rse.internal.ui.actions.preference.page"
>+                    value="org.eclipse.rse.core.ui.preferences.SystemCachePreferencePage">
>+              </parameter>
>+           </command>
>+        </menuContribution>
>+     </extension>
>+
> </plugin>
>Index: UI/org/eclipse/rse/internal/ui/actions/ShowPreferenceHandler.java
>===================================================================
>RCS file: UI/org/eclipse/rse/internal/ui/actions/ShowPreferenceHandler.java
>diff -N UI/org/eclipse/rse/internal/ui/actions/ShowPreferenceHandler.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ UI/org/eclipse/rse/internal/ui/actions/ShowPreferenceHandler.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,27 @@
>+package org.eclipse.rse.internal.ui.actions;
>+
>+import org.eclipse.core.commands.AbstractHandler;
>+import org.eclipse.core.commands.ExecutionEvent;
>+import org.eclipse.core.commands.ExecutionException;
>+import org.eclipse.ui.IWorkbenchWindow;
>+import org.eclipse.ui.handlers.HandlerUtil;
>+
>+public class ShowPreferenceHandler extends AbstractHandler {
>+
>+	private final String PARAM_PREF_PAGE = "org.eclipse.rse.internal.ui.actions.preference.page";
>+	
>+	/*
>+	 * (non-Javadoc)
>+	 * 
>+	 * @see org.eclipse.core.commands.IHandler#execute(org.eclipse.core.commands.ExecutionEvent)
>+	 */
>+	public Object execute(ExecutionEvent event) throws ExecutionException {
>+		String page = (String) event.getParameter(PARAM_PREF_PAGE);
>+		
>+		SystemShowPreferencesPageAction action = new SystemShowPreferencesPageAction();
>+		action.setPreferencePageID(page);
>+		action.run();
>+		return null;
>+	}
>+	
>+}

Actions: View | Diff

Attachments on bug 186769: 107168 | 107279 | 108338